Remove old JS form validations (#1867)
* added new form validation error handling

added tests for orgs controller

converted over remaining controllers to new errors

enhanced message handlers in application controller

finished form validations

* fixed rubocop for all controllers

* Fix broken specs

- Factories needed to be updated to meet new validation requirements
- Spec was broken since error message had changed

* Fix errors and warnings from npm audit
dev
1 parent 2f8ed6c commit 16e12b77b2c62b0d700c8c55859264ea11da267e
@Brian Riley Brian Riley authored on 7 Sep 2018
Gavin Morrice committed on 7 Sep 2018
Showing 113 changed files
View
app/controllers/answers_controller.rb
Too large
View
app/controllers/api/v0/base_controller.rb
Too large
View
app/controllers/api/v0/guidance_groups_controller.rb
Too large
View
app/controllers/api/v0/plans_controller.rb
Too large
View
app/controllers/api/v0/statistics_controller.rb
Too large
View
app/controllers/api/v0/templates_controller.rb
Too large
View
app/controllers/application_controller.rb
Too large
View
app/controllers/concerns/conditional_user_mailer.rb
Too large
View
app/controllers/concerns/paginable.rb
Too large
View
app/controllers/concerns/versionable.rb
Too large
View
app/controllers/contacts_controller.rb
Too large
View
app/controllers/guidance_groups_controller.rb
Too large
View
app/controllers/guidances_controller.rb
Too large
View
app/controllers/home_controller.rb
Too large
View
app/controllers/notes_controller.rb
Too large
View
app/controllers/org_admin/phases_controller.rb
Too large
View
app/controllers/org_admin/plans_controller.rb
Too large
View
app/controllers/org_admin/questions_controller.rb
Too large
View
app/controllers/org_admin/sections_controller.rb
Too large
View
app/controllers/org_admin/template_copies_controller.rb
Too large
View
app/controllers/org_admin/templates_controller.rb
Too large
View
app/controllers/orgs_controller.rb
Too large
View
app/controllers/paginable/guidance_groups_controller.rb
Too large
View
app/controllers/paginable/guidances_controller.rb
Too large
View
app/controllers/paginable/notifications_controller.rb
Too large
View
app/controllers/paginable/orgs_controller.rb
Too large
View
app/controllers/paginable/plans_controller.rb
Too large
View
app/controllers/paginable/templates_controller.rb
Too large
View
app/controllers/paginable/themes_controller.rb
Too large
View
app/controllers/paginable/users_controller.rb
Too large
View
app/controllers/passwords_controller.rb
Too large
View
app/controllers/plan_exports_controller.rb
Too large
View
app/controllers/plans_controller.rb
Too large
View
app/controllers/public_pages_controller.rb
Too large
View
app/controllers/question_formats_controller.rb
Too large
View
app/controllers/registrations_controller.rb
Too large
View
app/controllers/roles_controller.rb
Too large
View
app/controllers/session_locales_controller.rb
Too large
View
app/controllers/sessions_controller.rb
Too large
View
app/controllers/settings.rb
Too large
View
app/controllers/settings/plans_controller.rb
Too large
View
app/controllers/splash_logs_controller.rb
Too large
View
app/controllers/static_pages_controller.rb
Too large
View
app/controllers/super_admin/notifications_controller.rb
Too large
View
app/controllers/super_admin/org_swaps_controller.rb
Too large
View
app/controllers/super_admin/orgs_controller.rb
Too large
View
app/controllers/super_admin/themes_controller.rb
Too large
View
app/controllers/super_admin/users_controller.rb
Too large
View
app/controllers/usage_controller.rb
Too large
View
app/controllers/user_identifiers_controller.rb
Too large
View
app/controllers/users/invitations_controller.rb
Too large
View
app/controllers/users/omniauth_callbacks_controller.rb
Too large
View
app/controllers/users_controller.rb
Too large
View
app/models/guidance.rb
Too large
View
app/models/user.rb
Too large
View
app/views/devise/invitations/edit.html.erb
Too large
View
app/views/guidance_groups/admin_edit.html.erb
Too large
View
app/views/guidance_groups/admin_new.html.erb
Too large
View
app/views/guidances/new_edit.html.erb
Too large
View
app/views/layouts/application.html.erb
Too large
View
app/views/org_admin/shared/_theme_selector.html.erb
Too large
View
app/views/plans/_edit_details.html.erb
Too large
View
app/views/shared/_create_account_form.html.erb
Too large
View
app/views/shared/_links.html.erb
Too large
View
app/views/shared/_my_org.html.erb
Too large
View
app/views/super_admin/notifications/edit.html.erb
Too large
View
app/views/super_admin/notifications/new.html.erb
Too large
View
app/views/super_admin/themes/_form.html.erb 0 → 100644
Too large
View
app/views/super_admin/themes/edit.html.erb 0 → 100644
Too large
View
app/views/super_admin/themes/new.html.erb 0 → 100644
Too large
View
app/views/super_admin/themes/new_edit.html.erb 100644 → 0
Too large
View
app/views/super_admin/users/edit.html.erb
Too large
View
lib/assets/javascripts/application.js
Too large
View
lib/assets/javascripts/locale/de/app.js
Too large
View
lib/assets/javascripts/locale/en_GB/app.js
Too large
View
lib/assets/javascripts/locale/en_US/app.js
Too large
View
lib/assets/javascripts/locale/es/app.js
Too large
View
lib/assets/javascripts/locale/fr/app.js
Too large
View
lib/assets/javascripts/spec/ariatiseFormSpec.js 100644 → 0
Too large
View
lib/assets/javascripts/utils/ariatiseForm.js 100644 → 0
Too large
View
lib/assets/javascripts/utils/links.js
Too large
View
lib/assets/javascripts/utils/requiredField.js 0 → 100644
Too large
View
lib/assets/javascripts/utils/validation.js 100644 → 0
Too large
View
lib/assets/javascripts/views/contacts/new.js 100644 → 0
Too large
View
lib/assets/javascripts/views/devise/invitations/edit.js 100644 → 0
Too large
View
lib/assets/javascripts/views/devise/passwords/edit.js
Too large
View
lib/assets/javascripts/views/devise/passwords/new.js 100644 → 0
Too large
View
lib/assets/javascripts/views/devise/registrations/edit.js
Too large
View
lib/assets/javascripts/views/guidance_groups/admin_edit.js 100644 → 0
Too large
View
lib/assets/javascripts/views/guidance_groups/admin_new.js 100644 → 0
Too large
View
lib/assets/javascripts/views/guidances/new_edit.js
Too large
View
lib/assets/javascripts/views/org_admin/phases/new_edit.js
Too large
View
lib/assets/javascripts/views/org_admin/phases/show.js
Too large
View
lib/assets/javascripts/views/org_admin/sections/index.js
Too large
View
lib/assets/javascripts/views/org_admin/templates/edit.js
Too large
View
lib/assets/javascripts/views/org_admin/templates/new.js
Too large
View
lib/assets/javascripts/views/orgs/admin_edit.js
Too large
View
lib/assets/javascripts/views/orgs/shibboleth_ds.js
Too large
View
lib/assets/javascripts/views/plans/edit_details.js
Too large
View
lib/assets/javascripts/views/plans/new.js
Too large
View
lib/assets/javascripts/views/plans/share.js
Too large
View
lib/assets/javascripts/views/shared/create_account_form.js
Too large
View
lib/assets/javascripts/views/shared/sign_in_form.js
Too large
View
lib/assets/javascripts/views/super_admin/notifications/edit.js
Too large
View
lib/assets/javascripts/views/super_admin/themes/new_edit.js
Too large
View
lib/assets/javascripts/views/super_admin/users/edit.js
Too large
View
lib/assets/package-lock.json
Too large
View
lib/assets/package.json
Too large
View
lib/assets/stylesheets/overrides.scss
Too large
View
spec/factories/guidances.rb
Too large
View
spec/factories/users.rb
Too large
View
spec/features/super_admins/orgs_spec.rb 0 → 100644
Too large
View
spec/support/helpers/links_helper.rb 0 → 100644
Too large