opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / app / models

2018-07-25	Unverified 0d4cdee Browse files » Add extra validations for all models ... - Includes specs using the Shoulda gem - Includes a refactoring of update_numbers to a "sortable" abstraction Bodacious committed on 25 Jul 2018
2018-07-19	4ab2a16 Browse files » fixed issues with saving and displaying of template stack ... Removed comments briley committed on 19 Jul 2018
	5b86355 Browse files » Remove section ordering from Phase assocs Bodacious authored on 13 Jul 2018 briley committed on 19 Jul 2018
	e4e0e57 Browse files » Refactor number update query for MySQL and SQLite Bodacious authored on 13 Jul 2018 briley committed on 19 Jul 2018
	aaf6329 Browse files » fixed critical issue with creating template questions briley committed on 19 Jul 2018
	cf379ca Browse files » Add annotate gem for models and Gemfile Bodacious authored on 12 Jul 2018 briley committed on 19 Jul 2018
	99f751a Browse files » Make sections within a phase sortable Bodacious authored on 12 Jul 2018 briley committed on 19 Jul 2018
	4019a97 Browse files » Remove Rails 3 attr accessible from models (#1691) Gavin Morrice authored on 12 Jul 2018 briley committed on 19 Jul 2018
	36f8e09 Browse files » Fix bug preventing Template model from loading Bodacious authored on 12 Jul 2018 briley committed on 19 Jul 2018
	a8162b2 Browse files » Refactor scopes back into Template model Bodacious authored on 12 Jul 2018 briley committed on 19 Jul 2018
	eb28226 Browse files » Fix rails loading bug on TemplateScope ... Fixes #1658 Bodacious authored on 11 Jul 2018 briley committed on 19 Jul 2018
	7dfe2b8 Browse files » Refactor queries without string interpolation Bodacious authored on 10 Jul 2018 briley committed on 19 Jul 2018
	cea16f8 Browse files » Change Plan readability to read from system config Bodacious authored on 9 Jul 2018 briley committed on 19 Jul 2018
	f29da96 Browse files » Update feeback requests to provide more info ... Issue #1587 Bodacious authored on 4 Jul 2018 briley committed on 19 Jul 2018
2018-06-14	c5c7b5b Browse files » made contact_email an email input type and added validation to model ... fixed issue with app name in tests briley committed on 14 Jun 2018
2018-06-13	Unverified 23f53b7 Browse files » Only email admin helpdesk when plan review requested (not all admins) #1217 (#1597) ... * added gettext markup to 'See full list' link * only email helpdesk on plan review, update preferences in branding_example, add rake task to remove depricated DB preferences * added missing end to upgrade.rake * removed admin options from notification preferences page * Edit project details accessibility changes #1454 (#1590) * Add missing gettext markup to titles and skip main content link issues #1441 and #1442" (#1601) * Add form validations (#1588) removed formtastic added required asterisks to create plan page and updated JS logic of Org selection added namespaces to edit profile, sign in and create account forms to fix duplicate id issue fixed JS behind links and their validation fixed JS behind links and their validation removed console.log statement and added rake tasks for data validation cleanup Add form validations removed formtastic added required asterisks to create plan page and updated JS logic of Org selection added namespaces to edit profile, sign in and create account forms to fix duplicate id issue fixed JS behind links and their validation fixed JS behind links and their validation removed console.log statement and added rake tasks for data validation cleanup made recommended adjustments reverted schema.rb removed unecessary other_org query * only email helpdesk on plan review, update preferences in branding_example, add rake task to remove depricated DB preferences * added missing end to upgrade.rake * removed admin options from notification preferences page * added prefs task to meta-release task * lost an end to the merges Sam Rust authored on 13 Jun 2018 GitHub committed on 13 Jun 2018
2018-06-11	dc48c98 Browse files » Added `rake translatable:find` ... ran gettext:find and fixed up en_US translations added translatable:find task and fixed up a few files added exception to po/pot backup files in gitignore began fixing up pt_BR added pt_BR translations fixed issue with multiline translatable text on help page. reran translatable:find and fixed up app.pot, pt_BR, en_US and en_GB fixed test fixed another test updated author comments added devise and bootstrap translations for pt_BR Brian Riley authored on 25 May 2018 briley committed on 11 Jun 2018
2018-05-23	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
	Unverified a638884 Browse files » Merge pull request #1491 from CDLUC3/contributions ... Final cleanup for Super Admin Notifications PR Brian Riley authored on 23 May 2018 GitHub committed on 23 May 2018
	50067f0 Browse files » Ruby Upgrade v2.4.4 ... ---------------------------------------- cleaning unused gems and upgrade to Ruby v2.4.1 fix node modules issues when running the upgrade update travis.yml to Ruby v2.4.1 Remove Friendly Id gem and related code references. Upgrading the Devise, Omniauth and Pundit gems and removing version numbers Upgrading views related gems like recaptcha, formtastic, dragonfly Upgrade development group gems like kaminari, byebug, better_errors, web-console, binding_of_caller, rack-mini-profiler Upgrade test group gems like racktest, webmock, sqlite, simplecov Upgrading Exporting and Internalization gems in the Gemfile Ruby upgrade to 2.4.4 Fix assert nil warnings in tests reremoved administrate gem fixed merge conflicts bhavi authored on 1 May 2018 briley committed on 23 May 2018
2018-05-16	a30cf7b Browse files » Implemented Notifications ... updated tests to work with current test infrastructure forgot to add test file switched from url to path to correct 'Mixed content https vs http' issues Quentin Sonrel authored on 29 Mar 2018 briley committed on 16 May 2018
2018-04-10	Unverified dd94ff8 Browse files » Resize logo to correct height - fixes #1357 Jimmy Angelakos authored on 10 Apr 2018 GitHub committed on 10 Apr 2018
2018-04-06	7850aea Browse files » added base_template_org and updated write plan to show correct org in guidance tab ... updated example answers logic added missing code to answers conroller and fixed test Brian Riley committed on 6 Apr 2018
2018-04-06	9d5bbaf Browse files » Existing template customisation appears now to be editable. DMPRoadmap/roadmap#1318 Jose Lloret committed on 6 Apr 2018
2018-04-05	4c46272 Browse files » patch to fix issue with default template visibility setting ... added nil check reverted changes to schema.rb briley committed on 5 Apr 2018
2018-03-22	38f87c3 Browse files » fixed merge conflict Jose Lloret committed on 22 Mar 2018
2018-03-21	d07835f Browse files » update question headings for questions with options to display question text xsrust committed on 21 Mar 2018
	702f2e3 Browse files » fix typo xsrust committed on 21 Mar 2018
	17a7b0a Browse files » fixes 1293 and one other reported issue xsrust committed on 21 Mar 2018
2018-03-20	Unverified 8f453a0 Browse files » Merge pull request #1303 from CDLUC3/issue1275 ... Updates to Super Admin Users page Jose Lloret authored on 20 Mar 2018 GitHub committed on 20 Mar 2018