fixed issues with JS and updated other org selection areas to use new JS (#1805) ...

updates to JS for org selection cahnges in PR#1778

Add tests for locale setting (#1823) ...

* Add tests for locale setting

- Adds Faker::Language module for testing languages with real-ish data
- Refactors global constants into Language model (See Issue#1696)
- Add specs to test locale change works

* Clean up language files to remove long names

* Add DB check in FastGettext initializer

* Set Memory cache for temporary caching solution

* Fix bug in Plan Rule

Merge pull request #1822 from DMPRoadmap/issue-1570 ...

Refactor routes for better maintainability

Refactor routes for better maintainability ...

- Remove redundant routes (Fixes #1699, Fixes#1570)
- Remove redundant actions
- Remove redundant policy methods
- Fix invalid actions (public methods defined on controllers)
- Set concern methods as private
- Extract session locale method from ApplicationController into its own controller
- Explicitly define actions in statics controller for better readability

Ensure annotations destroyed when text is blank ...

When a user updates an existing annotation to set its text to blank, this
should destroy that annotation record on the DB—since they can't be valid without
text.

Merge pull request #1807 from DMPRoadmap/feature/validations ...

Feature/validations

Add exit code to assets rake task

Fix lint issues in JS

Merge branch 'feature/validations' of github.com:DMPRoadmap/roadmap into feature/validations

Refactor rule: Plann - fix blank title

Added rake task to check record validity via SQL

Merge branch 'development' into fix/account_creation

Merge branch 'development' into feature/validations

Replace YARD documentation with Tomdoc ...

These changes use the YARD gem, but in the lighter Tomdoc format.

You can read more about Tomdoc here: https://tomdoc.org

Update rake tasks for documentation with Tomdoc

Moved field validation to my_org.js

Update rule for answers with blank user

Rename data cleanup rake task file

Update description on org rules

Add rules to fix invalid Annotation records

Refactor SQL query for rules with missing assoc.

Add rule to remove invalid Org contact_emails

Add rule to strip whitespace from the Org name

Remove ID search from Org abbreviation fix ...

The IDs are different on each DB.

Update rules for fixing duplicate section numbers

Replace boolean DataCleanup rules with migrations ...

Decided it would be a better idea for moving forward if we just constrained these at the DB level.

Add better logging for DataCleanup tasks

Remove unnecessary rake task from upgrade rake ...

This is not needed since we have the DataCleanup suite now. There's also the danger that this task might cause some prepended sections to go missing from their Phases, so safer to remove altogether.

Add RAILS_ENV flag to assets rake task

Merge pull request #1786 from DMPRoadmap/bug/webpack-no-watch ...

Fix bug in webpack --no-watch option