opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / app / models / plan.rb

2019-04-17	e043980 Browse files » Added code to make Search functionality case-insensitive. ... Changes: - relevant models with :search scope updated with lower casing of the column values and the search parameters. - fixed all rubocop warnings on the changed models except "Style/RedundantReturn: Redundant return detected." Note: one could not use 'ILIKE' in WHERE clauses changed as it is not supported by MariaDB and MySql. Hence we use lower() in changed WHERE clauses. Fix for issue #2080 John Pinto committed on 17 Apr 2019
2018-12-11	0b00cad Browse files » added check to feedback_requested (#2012) Brian Riley authored on 11 Dec 2018 Sam Rust committed on 11 Dec 2018
2018-12-11	1e43862 Browse files » fixed query (#2008) Brian Riley authored on 11 Dec 2018 Sam Rust committed on 11 Dec 2018
2018-12-10	0540917 Browse files » updated organisational plans query to only include completed plans to match logic of plan export (#2004) ... refactored plan.visibility_allowed? to call underlying method on phases refactored plan.visibility_allowed? to call underlying method on phases fixed tests Brian Riley authored on 10 Dec 2018 Sam Rust committed on 10 Dec 2018
2018-12-03	872bbd2 Browse files » made recommended adjustments briri committed on 3 Dec 2018
2018-11-30	aacc8e1 Browse files » removed debug statements briri committed on 30 Nov 2018
2018-11-30	ad393ed Browse files » finished up changes to controllers briri committed on 30 Nov 2018
2018-11-29	a5dc80b Browse files » updated Role, Plan logic and fixed tests briri committed on 29 Nov 2018
2018-11-28	82a4ec8 Browse files » refactor plan/role functionality to use flagshihtzu properly briri committed on 28 Nov 2018
2018-08-28	3039ef5 Browse files » Refactor how section ordering is handled (#1837) ... * Extract template customizations into own controller * Refactor Template model methods * Fix view logic in draggable sections * Add button for customising phase * Fix rubocop violations in GuidanceService * Rename GuidanceService to GuidancePresenter * Fix bug in phase preview order sections * Refactor preview action/controller code * Fix Section ordering in various views * Fix rubocop violations * Fix bug forcing Phases to be modifiable * Fix broken tests * Update method to check if section is draggable * Extract copy action into its own resource * Extract customization transfers to own controller * Remove redundant routing condition * Fix Rubocop violation issues * Change condition for section draggable * Refactor instance variable in PlansController * Fix broken tests * Add test support for 'de' locale * Fix merge issue in plans controller * Fix broken specs in plan#request_feedback Gavin Morrice authored on 28 Aug 2018 Sam Rust committed on 28 Aug 2018
2018-08-27	Unverified 4e4b4db Browse files » Issue 1845 (#1846) ... * Fix bug preventing Feedback from being requested * Fix Rubocop violations * Extract feedback requests into own controller * Add test for feedback requests * Fix Rubocop violations Gavin Morrice authored on 27 Aug 2018 GitHub committed on 27 Aug 2018
2018-08-22	Unverified fb69a3c Browse files » Configurable plan access (#1828) ... * added configuration options to branding.yml for plan access, updated links to be dependant on access * updated spec to expect multiple calls to branding Sam Rust authored on 22 Aug 2018 GitHub committed on 22 Aug 2018
2018-08-15	Unverified a4729f7 Browse files » Fix duplicates in guidance group options ... Restructure the `has_many` association to use SQL's DISTINCT function Bodacious committed on 15 Aug 2018
2018-08-14	Unverified d92cfa3 Browse files » Merge pull request #1802 from DMPRoadmap/refactor/database-cleanup ... Remove redundant database tables and columns Brian Riley authored on 14 Aug 2018 GitHub committed on 14 Aug 2018
2018-08-13	Unverified 4bbbe23 Browse files » Remove redundant database tables and columns ... Remove redundant columns and tables listed in #1382 Update models and factories with new schema structure comments. Bodacious committed on 13 Aug 2018
2018-08-13	Unverified 52a160b Browse files » Replace YARD documentation with Tomdoc ... These changes use the YARD gem, but in the lighter Tomdoc format. You can read more about Tomdoc here: https://tomdoc.org Bodacious committed on 13 Aug 2018
2018-08-02	Unverified 4250460 Browse files » Fixed broken Plan specs after model Bodacious committed on 2 Aug 2018
2018-08-01	Unverified f7e3d8b Browse files » Refactored model code for better readability Bodacious committed on 1 Aug 2018
2018-07-25	Unverified 0d4cdee Browse files » Add extra validations for all models ... - Includes specs using the Shoulda gem - Includes a refactoring of update_numbers to a "sortable" abstraction Bodacious committed on 25 Jul 2018
2018-07-12	Unverified c27697d Browse files » Add annotate gem for models and Gemfile Bodacious committed on 12 Jul 2018
	Unverified 3757950 Browse files » Merge pull request #1657 from DigitalCurationCentre/issue-1163 ... Update feeback requests to provide more info Brian Riley authored on 12 Jul 2018 GitHub committed on 12 Jul 2018
	a167b6f Browse files » Remove Rails 3 attr accessible from models (#1691) Gavin Morrice authored on 12 Jul 2018 Sam Rust committed on 12 Jul 2018
	Unverified 2649de1 Browse files » Update feeback requests to provide more info ... Issue #1587 Bodacious committed on 12 Jul 2018
2018-07-09	Unverified b6fbf6a Browse files » Change Plan readability to read from system config Bodacious committed on 9 Jul 2018
2018-06-13	Unverified 23f53b7 Browse files » Only email admin helpdesk when plan review requested (not all admins) #1217 (#1597) ... * added gettext markup to 'See full list' link * only email helpdesk on plan review, update preferences in branding_example, add rake task to remove depricated DB preferences * added missing end to upgrade.rake * removed admin options from notification preferences page * Edit project details accessibility changes #1454 (#1590) * Add missing gettext markup to titles and skip main content link issues #1441 and #1442" (#1601) * Add form validations (#1588) removed formtastic added required asterisks to create plan page and updated JS logic of Org selection added namespaces to edit profile, sign in and create account forms to fix duplicate id issue fixed JS behind links and their validation fixed JS behind links and their validation removed console.log statement and added rake tasks for data validation cleanup Add form validations removed formtastic added required asterisks to create plan page and updated JS logic of Org selection added namespaces to edit profile, sign in and create account forms to fix duplicate id issue fixed JS behind links and their validation fixed JS behind links and their validation removed console.log statement and added rake tasks for data validation cleanup made recommended adjustments reverted schema.rb removed unecessary other_org query * only email helpdesk on plan review, update preferences in branding_example, add rake task to remove depricated DB preferences * added missing end to upgrade.rake * removed admin options from notification preferences page * added prefs task to meta-release task * lost an end to the merges Sam Rust authored on 13 Jun 2018 GitHub committed on 13 Jun 2018
2018-05-23	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
2018-03-15	10aaded Browse files » Workaround for #1292 Jimmy Angelakos committed on 15 Mar 2018
2018-03-13	a097325 Browse files » Select the correct phase for editing in edit plan Jimmy Angelakos committed on 13 Mar 2018
2018-02-28	8e162b8 Browse files » fixed up issues with request feedback emails briley committed on 28 Feb 2018
2018-02-15	b1ec0ae Browse files » Pre-fetching plan and current phase respecting order by number for sections and questions Jose Lloret committed on 15 Feb 2018