opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / app / controllers / plans_controller.rb

2018-08-28	3039ef5 Browse files » Refactor how section ordering is handled (#1837) ... * Extract template customizations into own controller * Refactor Template model methods * Fix view logic in draggable sections * Add button for customising phase * Fix rubocop violations in GuidanceService * Rename GuidanceService to GuidancePresenter * Fix bug in phase preview order sections * Refactor preview action/controller code * Fix Section ordering in various views * Fix rubocop violations * Fix bug forcing Phases to be modifiable * Fix broken tests * Update method to check if section is draggable * Extract copy action into its own resource * Extract customization transfers to own controller * Remove redundant routing condition * Fix Rubocop violation issues * Change condition for section draggable * Refactor instance variable in PlansController * Fix broken tests * Add test support for 'de' locale * Fix merge issue in plans controller * Fix broken specs in plan#request_feedback Gavin Morrice authored on 28 Aug 2018 Sam Rust committed on 28 Aug 2018
2018-08-27	Unverified 4e4b4db Browse files » Issue 1845 (#1846) ... * Fix bug preventing Feedback from being requested * Fix Rubocop violations * Extract feedback requests into own controller * Add test for feedback requests * Fix Rubocop violations Gavin Morrice authored on 27 Aug 2018 GitHub committed on 27 Aug 2018
2018-08-27	3b34a33 Browse files » Exported Plan bug and style fixes: ... - The csv export now shows the project coversheet text when the option is selected. - the text export now shows the questions when question text option selected. John Pinto committed on 27 Aug 2018
2018-08-17	Unverified 14d1c2a Browse files » Refactor routes for better maintainability ... - Remove redundant routes (Fixes #1699, Fixes#1570) - Remove redundant actions - Remove redundant policy methods - Fix invalid actions (public methods defined on controllers) - Set concern methods as private - Extract session locale method from ApplicationController into its own controller - Explicitly define actions in statics controller for better readability Bodacious committed on 17 Aug 2018
2018-08-13	Unverified e98abf2 Browse files » Merge pull request #1800 from DMPRoadmap/refactor/tomdoc ... Rewrite YARD comments as Tomdoc. Brian Riley authored on 13 Aug 2018 GitHub committed on 13 Aug 2018
	694b2d6 Browse files » Fix for "Plan Download". ... This is a clean up of code based on PR comments. Also updated the ExportablePlan helper method as_csv() to work with the selections made on the Plan Download page. Issue #1730 John Pinto committed on 13 Aug 2018
	08ae4a1 Browse files » Fix for "Plan download file not filtering on selection on Download page". ... Issue #1730 Also included is a fix for rendering if saving a new plan or editing a plan that results in errors. John Pinto committed on 13 Aug 2018
	Unverified 52a160b Browse files » Replace YARD documentation with Tomdoc ... These changes use the YARD gem, but in the lighter Tomdoc format. You can read more about Tomdoc here: https://tomdoc.org Bodacious committed on 13 Aug 2018
2018-08-02	Unverified f9c0185 Browse files » Replace deprecated methods with their new alaises Bodacious committed on 2 Aug 2018
2018-08-02	Unverified 95e6359 Browse files » Merge branch 'development' into refactor/rspec-specs Bodacious committed on 2 Aug 2018
2018-08-01	Unverified db81939 Browse files » Remove status action from PlansController Bodacious committed on 1 Aug 2018
2018-08-01	Unverified f7e3d8b Browse files » Refactored model code for better readability Bodacious committed on 1 Aug 2018
2018-07-30	Unverified 08b71b2 Browse files » Fix bug when setting principle investigator phone Bodacious committed on 30 Jul 2018
2018-07-27	Unverified a8eb6b3 Browse files » Add specs for all models Bodacious committed on 27 Jul 2018
2018-07-12	Unverified 2649de1 Browse files » Update feeback requests to provide more info ... Issue #1587 Bodacious committed on 12 Jul 2018
2018-06-15	587160e Browse files » lookup hash guidance groups by org. DMPRoadmap/roadmap#1409 ... GuidanceService for addressing an adequate displaying of guidances and annotations for each question from a plan. DMPRoadmap/roadmap#1409 some public methods for GuidanceService. Integration with views. DMPRoadmap/roadmap#1409 any? method for GuidanceService Jose Lloret committed on 15 Jun 2018
2018-05-23	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
2018-03-22	7917bb4 Browse files » updated plans controller to send user to overview after saving details ... fixed tests Brian Riley committed on 22 Mar 2018
2018-03-08	28d2da2 Browse files » switched to use google fonts ... fixed issue with margins removed old id updated h1 updated h1s briley committed on 8 Mar 2018
2018-03-02	d3ba6c7 Browse files » centered plan title ... fixed issue with pdf fomratting fixed issue with pdf fomratting Brian Riley committed on 2 Mar 2018
2018-02-28	8caa171 Browse files » fixed issue with double plan in docx briley committed on 28 Feb 2018
2018-02-23	89f2509 Browse files » removed side effects when generating or removing API token. Removed org_id method from User and use after_update callback instead. #1060 Jose Lloret committed on 23 Feb 2018
2018-02-21	20c647d Browse files » updated JS to fix guidance selection synchronization. updated controller to just replace guidance list briley committed on 21 Feb 2018
2018-02-20	f2ff19e Browse files » page ALL is retained if latest request contains it. Sort links are now right aligned within the th. #1105 ... default sorting to paginable concern specified through query_params keyword. #1105 paginable plans including default sorting paginable orgs including default sorting. #1105 Jose Lloret committed on 20 Feb 2018
2018-02-15	c01ba32 Browse files » fixes for downloads ... updated security check briley committed on 15 Feb 2018
2018-02-14	Unverified 1bf13b3 Browse files » Merge pull request #1153 from CDLUC3/issue1102 ... updated create plan to allow orgs and institutions in research org list Jose Lloret authored on 14 Feb 2018 GitHub committed on 14 Feb 2018
2018-02-13	e275d1f Browse files » updated create plan to allow orgs and institutions in research org list briley committed on 13 Feb 2018
	c6a63c2 Browse files » fix csv, txt exports briley committed on 13 Feb 2018
	Unverified 0ee252d Browse files » Merge pull request #1143 from CDLUC3/issue1127 ... consolidated plan exports Jose Lloret authored on 13 Feb 2018 GitHub committed on 13 Feb 2018
2018-02-09	db7079a Browse files » consolidated plan exports Brian Riley committed on 9 Feb 2018