opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / lib / assets / javascripts / views / org_admin

2018-08-28	3039ef5 Browse files » Refactor how section ordering is handled (#1837) ... * Extract template customizations into own controller * Refactor Template model methods * Fix view logic in draggable sections * Add button for customising phase * Fix rubocop violations in GuidanceService * Rename GuidanceService to GuidancePresenter * Fix bug in phase preview order sections * Refactor preview action/controller code * Fix Section ordering in various views * Fix rubocop violations * Fix bug forcing Phases to be modifiable * Fix broken tests * Update method to check if section is draggable * Extract copy action into its own resource * Extract customization transfers to own controller * Remove redundant routing condition * Fix Rubocop violation issues * Change condition for section draggable * Refactor instance variable in PlansController * Fix broken tests * Add test support for 'de' locale * Fix merge issue in plans controller * Fix broken specs in plan#request_feedback Gavin Morrice authored on 28 Aug 2018 Sam Rust committed on 28 Aug 2018
2018-08-22	7dcb85e Browse files » Fix TinyMCE JS on forms loaded with DOM (#1827) ... * Fix TinyMCE JS on forms loaded with DOM Fixes #1777 * Fix broken specs * Fix Rubocop style violations Ignored LineLength violations when string is part of FastGettext * Updated rubocop style gem Gavin Morrice authored on 22 Aug 2018 Sam Rust committed on 22 Aug 2018
2018-08-17	Unverified bca4a89 Browse files » Ensure annotations destroyed when text is blank ... When a user updates an existing annotation to set its text to blank, this should destroy that annotation record on the DB—since they can't be valid without text. Bodacious committed on 17 Aug 2018
2018-07-26	Unverified 2a8d7fc Browse files » Update error message when prepending two sections Bodacious committed on 26 Jul 2018
2018-07-25	Unverified 42f164f Browse files » Show alert when dragging section to 1st place Bodacious committed on 25 Jul 2018
	Unverified 35dd2d4 Browse files » Remove wobble effect from failed sort Bodacious committed on 25 Jul 2018
	Unverified de581c0 Browse files » Change sort handle to arrows instead of bars Bodacious committed on 25 Jul 2018
2018-07-18	Unverified 851448b Browse files » Merge pull request #1737 from CDLUC3/fix-attr-issues ... Fixed issues with Template Gavin Morrice authored on 18 Jul 2018 GitHub committed on 18 Jul 2018
2018-07-17	Unverified 3cb9ef8 Browse files » Fix bug causing tooltips to display badly ... Fixes #1739 Bodacious committed on 17 Jul 2018
2018-07-16	ec700a6 Browse files » fixed issues with saving and displaying of template stack ... Removed comments briley committed on 16 Jul 2018
2018-07-13	Unverified 0a6c232 Browse files » Merge pull request #1715 from DMPRoadmap/issue-1371 ... Add ability to sort phase sections by dragging Brian Riley authored on 13 Jul 2018 GitHub committed on 13 Jul 2018
2018-07-13	Unverified 6922ef0 Browse files » Merge pull request #1726 from DigitalCurationCentre/issue-1300 ... Previously, on the "Create a new plan" and "Edit Profile" pages long … Brian Riley authored on 13 Jul 2018 GitHub committed on 13 Jul 2018
2018-07-12	Unverified 5710c8a Browse files » Fix missing semi-colon bug in javascript file Bodacious committed on 12 Jul 2018
2018-07-12	Unverified ca4a6ad Browse files » Make sections within a phase sortable Bodacious committed on 12 Jul 2018
2018-07-03	a8f4da5 Browse files » removed all occurences of toolbar specifications that override default Tinymce toolbar behavior (#1641) Brian Riley authored on 3 Jul 2018 Sam Rust committed on 3 Jul 2018
2018-06-19	f0785a5 Browse files » Fixed issues with Public Template page sorting and form validations (#1621) ... * fixed final issue with public template sort * switched from aria-describedby to validation-help-block * fixed remaining issues Brian Riley authored on 19 Jun 2018 Sam Rust committed on 19 Jun 2018
2018-06-18	74c37ac Browse files » fixed issue with Tinymce toolbar (#1611) ... removed trailing spaces switched selector for notifications tinymce reverted back to passing tollbar Brian Riley authored on 18 Jun 2018 Sam Rust committed on 18 Jun 2018
2018-06-13	f525dac Browse files » Add form validations (#1588) ... removed formtastic added required asterisks to create plan page and updated JS logic of Org selection added namespaces to edit profile, sign in and create account forms to fix duplicate id issue fixed JS behind links and their validation fixed JS behind links and their validation removed console.log statement and added rake tasks for data validation cleanup Add form validations removed formtastic added required asterisks to create plan page and updated JS logic of Org selection added namespaces to edit profile, sign in and create account forms to fix duplicate id issue fixed JS behind links and their validation fixed JS behind links and their validation removed console.log statement and added rake tasks for data validation cleanup made recommended adjustments reverted schema.rb removed unecessary other_org query Brian Riley authored on 13 Jun 2018 Sam Rust committed on 13 Jun 2018
2018-05-23	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
2018-01-08	d8bfb21 Browse files » ajax:before for generating JSON links and trigger URL validations. DMPRoadmap/roadmap#903 ... template dirty for when links hash object is different too. DMPRoadmap/roadmap#903 validation check for link_link and link_text. DMPRoadmap/roadmap#903 Cancel remove link except for when only one link exists. DMPRoadmap/roadmap#903 Jose Lloret committed on 8 Jan 2018
2017-12-22	80076b7 Browse files » Templates table revisions #900 (In Progress) ... added tests updates to controller and model methods updated view tested and adjusted scoping queries added unit tests for new latest customization queries updated tests updated tests and added predefined scopes back to funders templates finialized tests for new template page removed debug statements bhavi authored on 20 Dec 2017 Brian Riley committed on 22 Dec 2017
2017-12-19	eba4ccf Browse files » added all/published/unpublished scopes to the templates tables ... removed debug statements updated main index action optimized query for customizations briley committed on 19 Dec 2017
2017-12-18	96b0d93 Browse files » templates#update ajaxified. DMPRoadmap/roadmap#903 ... fixed alert for when JS displays it. DMPRoadmap/roadmap#903 . removed kernel#puts from templates_controller_test.rb. DMPRoadmap/roadmap#903 Jose Lloret committed on 18 Dec 2017
2017-12-08	00d7e73 Browse files » Make templates page usable for Org Admins and Super Admins ... started work on super admin templates page consolidated org_admin and super_admin templates page moved template logic to org_admin module and consolidated logic for super/org admins switched from submit button click to form submit fixed issue with unused js var fixed broken templates controller tests switched back to submit button updated template_options route in integration test fixed broken integration tests caused by moving templates to org_admin namespace added tests for copy template added button to get back to 'all templates' page from template edit page renamed delete button from 'Cancel' to 'Delete' and added proper cancel button to edit section view made recommended adjustments and accounted for new template visibility functionality switched out scopes in favor of flagshihtzu helpers moved link to Themes to Admin menu fixed broken tests for the public_pages controller fixes for tests refactored template current version queries pulled in customization view changes briley authored on 27 Nov 2017 Brian Riley committed on 8 Dec 2017