Add specs for PDF download link

Fix bug preventing PDF downloads from dashboard

Fix bug preventing plans from downloading

Refactor how section ordering is handled (#1837) ...

* Extract template customizations into own controller

* Refactor Template model methods

* Fix view logic in draggable sections

* Add button for customising phase

* Fix rubocop violations in GuidanceService

* Rename GuidanceService to GuidancePresenter

* Fix bug in phase preview order sections

* Refactor preview action/controller code

* Fix Section ordering in various views

* Fix rubocop violations

* Fix bug forcing Phases to be modifiable

* Fix broken tests

* Update method to check if section is draggable

* Extract copy action into its own resource

* Extract customization transfers to own controller

* Remove redundant routing condition

* Fix Rubocop violation issues

* Change condition for section draggable

* Refactor instance variable in PlansController

* Fix broken tests

* Add test support for 'de' locale

* Fix merge issue in plans controller

* Fix broken specs in plan#request_feedback

Issue 1845 (#1846) ...

* Fix bug preventing Feedback from being requested

* Fix Rubocop violations

* Extract feedback requests into own controller

* Add test for feedback requests

* Fix Rubocop violations

Exported Plan bug and style fixes: ...

- The csv export now shows the project coversheet text when the option is selected.
- the text export now shows the questions when question text option selected.

Configurable plan access (#1828) ...

* added configuration options to branding.yml for plan access, updated links to be dependant on access

* updated spec to expect multiple calls to branding

Fix TinyMCE JS on forms loaded with DOM (#1827) ...

* Fix TinyMCE JS on forms loaded with DOM

Fixes #1777

* Fix broken specs

* Fix Rubocop style violations

Ignored LineLength violations when string is part of FastGettext

* Updated rubocop style gem

Add tests for locale setting (#1823) ...

* Add tests for locale setting

- Adds Faker::Language module for testing languages with real-ish data
- Refactors global constants into Language model (See Issue#1696)
- Add specs to test locale change works

* Clean up language files to remove long names

* Add DB check in FastGettext initializer

* Set Memory cache for temporary caching solution

* Fix bug in Plan Rule

Merge pull request #1814 from DMPRoadmap/issue-1736 ...

Reset other_organisation when User org changes

Ensure annotations destroyed when text is blank ...

When a user updates an existing annotation to set its text to blank, this
should destroy that annotation record on the DB—since they can't be valid without
text.

Fix updating questions when annotation text is nil

Reset other_organisation when User org changes ...

- Refactored how user model defines callbacks
- Add specs

Fix duplicates in guidance group options ...

Restructure the `has_many` association to use SQL's DISTINCT function

Merge branch 'development' into feature/validations

Merge pull request #1802 from DMPRoadmap/refactor/database-cleanup ...

Remove redundant database tables and columns

Merge pull request #1800 from DMPRoadmap/refactor/tomdoc ...

Rewrite YARD comments as Tomdoc.

Fix for "Plan Download". ...

This is a clean up of code based on PR comments.

Also updated the ExportablePlan helper method as_csv() to work with the selections made on the Plan Download page.

Issue #1730

Remove redundant database tables and columns ...

Remove redundant columns and tables listed in #1382

Update models and factories with new schema structure comments.

Fix for "Plan download file not filtering on selection on Download page". ...

Issue #1730

Also included is a fix for rendering if saving a new plan or editing a plan that results in
errors.

Replace YARD documentation with Tomdoc ...

These changes use the YARD gem, but in the lighter Tomdoc format.

You can read more about Tomdoc here: https://tomdoc.org

Update schema annotations on Org model

Remove uniqueness validation from Org abbreviation

Update rules for fixing duplicate section numbers

Replace boolean DataCleanup rules with migrations ...

Decided it would be a better idea for moving forward if we just constrained these at the DB level.

Fix bug caused by blank section number

Merge pull request #1787 from DMPRoadmap/issue-1785 ...

Added missing VALID_FORMATS settings to models/settings/template.rb.

Remove published column from sections table ...

This was no longer required, and caused a bug when trying to create a new section.

Added missing VALID_FORMATS settings to models/settings/template.rb. ...

Update package name for VALID_FORMATS in _download_form.html.erb.

Merge branch 'development' into refactor/rspec-specs