opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / app

2018-05-23	426e61a Browse files » added joins to query ... updated schema to remove friednly_id_slugs table per changes in ruby_upgrade briley committed on 23 May 2018
	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
	Unverified a638884 Browse files » Merge pull request #1491 from CDLUC3/contributions ... Final cleanup for Super Admin Notifications PR Brian Riley authored on 23 May 2018 GitHub committed on 23 May 2018
	50067f0 Browse files » Ruby Upgrade v2.4.4 ... ---------------------------------------- cleaning unused gems and upgrade to Ruby v2.4.1 fix node modules issues when running the upgrade update travis.yml to Ruby v2.4.1 Remove Friendly Id gem and related code references. Upgrading the Devise, Omniauth and Pundit gems and removing version numbers Upgrading views related gems like recaptcha, formtastic, dragonfly Upgrade development group gems like kaminari, byebug, better_errors, web-console, binding_of_caller, rack-mini-profiler Upgrade test group gems like racktest, webmock, sqlite, simplecov Upgrading Exporting and Internalization gems in the Gemfile Ruby upgrade to 2.4.4 Fix assert nil warnings in tests reremoved administrate gem fixed merge conflicts bhavi authored on 1 May 2018 briley committed on 23 May 2018
2018-05-16	a30cf7b Browse files » Implemented Notifications ... updated tests to work with current test infrastructure forgot to add test file switched from url to path to correct 'Mixed content https vs http' issues Quentin Sonrel authored on 29 Mar 2018 briley committed on 16 May 2018
2018-05-08	9978702 Browse files » Remove administrate gem and files Jimmy Angelakos committed on 8 May 2018
2018-04-27	Unverified e889f9f Browse files » Merge pull request #1400 from DigitalCurationCentre/issue1397 ... Fixes #1397 Jose Lloret authored on 27 Apr 2018 GitHub committed on 27 Apr 2018
2018-04-24	58e4c7c Browse files » removed requirement that users are confirmed from stats controller xsrust committed on 24 Apr 2018
2018-04-20	Unverified 1cbf169 Browse files » Merge pull request #1399 from DigitalCurationCentre/issue1394 ... Fix for contact-us when logged in - fixes #1394 Brian Riley authored on 20 Apr 2018 GitHub committed on 20 Apr 2018
	72d74e9 Browse files » Fixes #1397 ... * after_sign_in\|up : Check for paths not urls (so that it works on localhost/http) * remove duplicate IDs from sign_up page by not including it in modal too (related to #1064) Jimmy Angelakos committed on 20 Apr 2018
	878fd20 Browse files » Changes for #1399 Jimmy Angelakos committed on 20 Apr 2018
2018-04-19	2d4b306 Browse files » Fix for contact-us when logged in - fixes #1394 Jimmy Angelakos committed on 19 Apr 2018
2018-04-19	Unverified 870fab0 Browse files » correct sort order for my dashboard - fixes #1395 ... Changed sort_direction argument from symbol to string Jimmy Angelakos authored on 19 Apr 2018 GitHub committed on 19 Apr 2018
2018-04-16	9e70b54 Browse files » Enable recaptcha for contact_us form: fixes #501 Jimmy Angelakos committed on 16 Apr 2018
2018-04-10	Unverified dd94ff8 Browse files » Resize logo to correct height - fixes #1357 Jimmy Angelakos authored on 10 Apr 2018 GitHub committed on 10 Apr 2018
2018-04-09	9c74f47 Browse files » removed delete of array element ... fixes issue with removing item from array while iterating over it briley committed on 9 Apr 2018
2018-04-09	0357975 Browse files » fixed issue with text downloads ... switched is_a? to respond_to? briley committed on 9 Apr 2018
2018-04-06	5b88834 Browse files » updated to check for blank example answers Brian Riley committed on 6 Apr 2018
	7850aea Browse files » added base_template_org and updated write plan to show correct org in guidance tab ... updated example answers logic added missing code to answers conroller and fixed test Brian Riley committed on 6 Apr 2018
	9d5bbaf Browse files » Existing template customisation appears now to be editable. DMPRoadmap/roadmap#1318 Jose Lloret committed on 6 Apr 2018
2018-04-05	Unverified 8559169 Browse files » Merge pull request #1346 from CDLUC3/issue1342 ... patch to fix issue with default template visibility setting Brian Riley authored on 5 Apr 2018 GitHub committed on 5 Apr 2018
	4c46272 Browse files » patch to fix issue with default template visibility setting ... added nil check reverted changes to schema.rb briley committed on 5 Apr 2018
	Unverified f094e64 Browse files » Merge pull request #1347 from CDLUC3/issue1343 ... added org abbreviation to 'Guidance' sections and added customized ex… Jose Lloret authored on 5 Apr 2018 GitHub committed on 5 Apr 2018
2018-04-04	bb28367 Browse files » added org abbreviation to 'Guidance' sections and added customized example answers ... updated locking logic briley committed on 4 Apr 2018
2018-04-04	949284c Browse files » fixed issue with equality check on localizable string :/ briley committed on 4 Apr 2018
2018-03-29	d4b5e07 Browse files » any paginable link or form uses paginable-action selector to avoid conflicting with other wider selectors. DMPRoadmap/roadmap#1334 Jose Lloret committed on 29 Mar 2018
2018-03-28	6559dd5 Browse files » View All not available for User scope when the current_user can super_admin. DMPRoadmap/roadmap#1186 Jose Lloret committed on 28 Mar 2018
2018-03-27	2d70e2c Browse files » updated logic for download/share briley committed on 27 Mar 2018
	Unverified 07167a8 Browse files » Merge pull request #1327 from CDLUC3/issue1197 ... added an excludeAsterisks option to AriatiseForm and validation JS fi… Brian Riley authored on 27 Mar 2018 GitHub committed on 27 Mar 2018
	5a130a6 Browse files » added an excludeAsterisks option to AriatiseForm and validation JS files. Also updated 2 gettext strings to allow for embedded HTML briley committed on 27 Mar 2018