opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / spec / models / question_spec.rb

2018-12-06	8b6acb7 Browse files » Further changes for Text field should be mandatory for option based questions. ... Fix for issue #1725 The question_options field on the Customisable Phase template has the following changes: - the 'Text' label has the asterick for required. - the error message for missing question option now reads "You must have at least one option with accompanying text." - Corrected some Rubocop errors on the files added. John Pinto committed on 6 Dec 2018
2018-11-27	0ad0cd8 Browse files » Updated JS for requiredField to allow for dynamically loaded DOM elements (#1996) ... * IssueID #1725 - Updated messages Question text and option presence messages. * updated requiredField.js to allow for dynamically loaded DOM elements * fixed broken tests Brian Riley authored on 27 Nov 2018 Sam Rust committed on 27 Nov 2018
2018-11-09	54463e7 Browse files » Fix for ensuring that Questions that are option based must have atleast one non-blank text entry. ... - Validation added for option based questions to ensure text field non-blank. - Validation message OPTION_PRESENCE_MESSAGE added to app/models/concerns/validation_messages.rb. - Added ':allow_nil => true' to delegate :option_based?, to: :question_format, :allow_nil => true in Question model to prevent NoMethodError if question_format is nil. Fix for #1725 John Pinto committed on 9 Nov 2018
2018-10-12	Unverified a920b20 Browse files » Fix bug when upgrading Template with new Sections ... Section presence validation was preventing Question from being saved. This was preventing new Sections from being saved. Bodacious committed on 12 Oct 2018
2018-09-13	Unverified b4727e5 Browse files » Repair broken or pending specs (#1874) ... - Fix pending Template model specs - Fix pending model specs - Fix broken/pending specs, including random "errors" bug Gavin Morrice authored on 13 Sep 2018 GitHub committed on 13 Sep 2018
2018-09-05	Unverified 2f8ed6c Browse files » Refactor how Template upgrade customization works (#1856) ... * Refactor how Template upgrade customization works - Added position_in_parent to child-records Phase, Section, and Questions - Extracted upgrade_customization! into its own service object wip: rebasing on development wip: pushing to Ghub wip: Template upgrade customisation service working Add migration to update versionable_id for records * Fix bug in org swaps test Test was failing because JS wasn't executing fast enough in test browser * Refactor how locales are set in specs * Fix bug in plan exports caused by git merge The routes weren't merged properly which seems to have caused a regression error * Add documentation for SectionSorter * Update rubyzip and re-instate Bundle Audit This was disabled because it was failing the Travis CI script. Since there wasn't a new version of the rubyzip gem to upgrade to, we couldn't turn the error off. * Add length constraints to versionable_id * Add length constraints to versionable_id * Fix bug in ActsAsSortable module ... I have no idea why those issues haven't popped up before now!? * Fix random bug in I18n * Move versioning ID migration into own rake task Gavin Morrice authored on 5 Sep 2018 GitHub committed on 5 Sep 2018
2018-08-02	Unverified f9c0185 Browse files » Replace deprecated methods with their new alaises Bodacious committed on 2 Aug 2018
2018-07-27	Unverified a8eb6b3 Browse files » Add specs for all models Bodacious committed on 27 Jul 2018
2018-07-24	Unverified 66a2103 Browse files » Add extra validations for all models ... - Includes specs using the Shoulda gem - Includes a refactoring of update_numbers to a "sortable" abstraction Bodacious committed on 24 Jul 2018