Merged DMPRoadmap V2.1.6

Fixed issue when setting common answers on newly answered questions

Solved issue on editor loading when saving a note in a research output

Changed the way common answers are changed

Issue/1682 (#2440) ...

* remove monthly usage from funder-usage-dashboard, adjust spacing on page

* rename usage statistic accordion partials

* usage-dashboard accordions now conditional on the type of user, also made the js more robust to the charts not existing

Default template should be displayed as a normal template in plan creation

Changing research output tab should change the tab in every sections

First research output should be movable

fix eslint issues

DRY up the stat and JS code

Merge branch 'development' of https://github.com/DMPRoadmap/roadmap into issue/1682

usage dashboard working but not dry, moving machines

Merge branch 'development' into bug/tinymce_styling

issue#2375 allow change of delimiter for csv download (#2403) ...

* issue#2375 allow change of delimiter for csv download

* fix eslint issues, bugfix usage-dashboard when no stats exist, Styling tweaks to csv separator

* fix issues with tests by defaulting the separator to a comma NOTE: does not enforce tests on the separator param working

* fix issues with new separator argument in stat-created-plan and spec

Co-authored-by: Sam Rust <xsrust@gmail.com>

Merged DMP Roadmap V2.1.5

enable js.erb parsing with webpacker, rename references to tinymce.js, and properly get the asset_path for the tinymce content stylesheet

added browser_spellcheck to tinymce

Refactor of usage dashboard (moved logic from JS to Ruby) (#2336) ...

* removed erroneous div tag

* Updated deep_copy on PLan model to set feedback_requested to false

* fixed typo in plan export

* refactored usage code to place most of the presentation logic into Rails instead of JS

finished up changes to usage

fixed eslinter issues

fixed rubocop issues

fixed additional rubocop issues

fixed issue with filter

fixed issue with totals

removed old controller test and added new usage_controller tests

added tests for new usage_helper

added usage_policy tests and pundit test helper

fixed some rubocop complaints

fixed up remaining rubocop issues

* removed opens in a new window for usage download buttons and moved org selector to below filters

* fixed some rubocop complaints in spec test

Improved notes editors loading in plan edition

added method to reattach labels to their corresponding tinymce iframe

Adjustements to external link, the title should tell the link opens a new window

Merged DMP Roadmap V2.1.4

Modify Merge Account messaging (#2287) ...

* revised user merge text and made responsive

* remove debug  lines

* update for eslint errors

* actually fixes eslint issues, this time with testing locally

[Feature] Create plan from link (#2284) ...

* Added direct link for plan creation from templates list

* Moved link generation to helper

* Added modal for link copy

* Added JS for link copy

* Improved modal style and moved it to a partial

* Added template link copy to admin area (organisation templates)

* Added confirmation modal for creation link

* Minor changes for direct_link helper

* Fixed typo in YARD doc

Added color picker & font size select to static pages editor

Added eslint-disable on commented function

Removed OpenAire API call on plans edit

Added Stats chart for org template usage

Updated gems with bundle update and eslint errors in outOfFocus.js.

Fix for Accessibility issues with Tables (highlighted by UCOP electronic accessibility review) ...

Changes:
  - Added scope="col" to table header tags <th> that were missing them.
  - The Jquery dropdown menus in tables are closed when the table cell
containing it is out of focus.

(The issue the fontawesome sort icons are read as 'column # link'.
Add some screen reader only text. This issue was sorted by someone else
who added ".screen-reader-text" class to the sort_link_name() method in
app/controllers/concerns/paginable.rb.)

Fix for issue #1455.