2018-11-18 |
1. stat_created_plan.to_csv with option for details by template.
...
2. details attribute for stats table #1679
3. create_created_plan_service extended with details by template
4. create_last_month_created_plan_service extended with details by
template.
5. create_or_update strategy for generating stats
6. StatCreatedPlanByTemplateController#index for graphs usage
7. month_start_date and month_end_date for OrgDateRangeable class
[RD-1679] Usage view including date input for plans by template
[#1679] monthly_range query updated
[#1679] client-side chart for plans by template
[#1679] Time picker for plans by template chart
[#1679] Download plans by template action.
deleted spec
merge conflicts fixed
[#1679] Removed JS linter warnings
[#1679] Rubocop conforming code. Drying out stat services
Jose Lloret
committed
on 18 Nov 2018
|
2018-10-24 |
Add ActiveRecord Session storage (#1969)
...
* Add ActiveRecord Session storage
* Update Gemfile to fix failing tests
Moved Dotenv to dev and test group
* Add length limit to session_id for MySQL databases
* Update session_id column length to 64
* Update schema with new constraints on session_id
Gavin Morrice
authored
on 24 Oct 2018
GitHub
committed
on 24 Oct 2018
|
2018-09-05 |
Refactor how Template upgrade customization works (#1856)
...
* Refactor how Template upgrade customization works
- Added position_in_parent to child-records Phase, Section, and Questions
- Extracted upgrade_customization! into its own service object
wip: rebasing on development
wip: pushing to Ghub
wip: Template upgrade customisation service working
Add migration to update versionable_id for records
* Fix bug in org swaps test
Test was failing because JS wasn't executing fast enough in test browser
* Refactor how locales are set in specs
* Fix bug in plan exports caused by git merge
The routes weren't merged properly which seems to have caused a regression error
* Add documentation for SectionSorter
* Update rubyzip and re-instate Bundle Audit
This was disabled because it was failing the Travis CI script. Since there wasn't a
new version of the rubyzip gem to upgrade to, we couldn't turn the error off.
* Add length constraints to versionable_id
* Add length constraints to versionable_id
* Fix bug in ActsAsSortable module
... I have no idea why those issues haven't popped up before now!?
* Fix random bug in I18n
* Move versioning ID migration into own rake task
Gavin Morrice
authored
on 5 Sep 2018
GitHub
committed
on 5 Sep 2018
|
2018-09-02 |
rebased onto development
...
stat_created_plan_spec finished
stats table using bigint. StatJoinedUser spec done
csvable_spec done
org_date_rangeable_spec done
Actions::StatCreatedPlan::Generate spec half way done
Actions::StatCreatedPlan::Generate rspec done
Actions::StatJoinedUser::Generate spec finished
Role.with_access_flags instead of access_values_for method
Jose Lloret
authored
on 22 Jul 2018
Jose Lloret
committed
on 2 Sep 2018
|
2018-08-22 |
removed bad index from templates (#1812)
...
removed index from schema.rb
fixed schema version number
Brian Riley
authored
on 22 Aug 2018
Sam Rust
committed
on 22 Aug 2018
|
2018-08-13 |
Remove redundant database tables and columns
...
Remove redundant columns and tables listed in #1382
Update models and factories with new schema structure comments.
Bodacious
committed
on 13 Aug 2018
|
2018-08-03 |
Remove published column from sections table
...
This was no longer required, and caused a bug when trying to create a new section.
Bodacious
committed
on 3 Aug 2018
|
2018-08-02 |
Revert "Removed length constraints from users email"
...
This reverts commit 9ddd68b .
Bodacious
committed
on 2 Aug 2018
|
Removed length constraints from users email
Bodacious
committed
on 2 Aug 2018
|
2018-08-01 |
Update DB schema for MySQL support
Bodacious
committed
on 1 Aug 2018
|
2018-06-19 |
removed default from template links
Sam Rust
authored
on 19 Jun 2018
GitHub
committed
on 19 Jun 2018
|
removed default links from schema
xsrust
committed
on 19 Jun 2018
|
2018-05-23 |
added joins to query
...
updated schema to remove friednly_id_slugs table per changes in ruby_upgrade
briley
committed
on 23 May 2018
|
Template Versioning
...
This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed.
------------------------------------------------------------
removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests
started updating model scopes and began creating new unit tests and test_helper methods
Rebased with template customization fixes. updated tests and latest_version queries
Grouping class methods. Grouping scope methods into separate class
removed Template::valid scope method in favour of Template::unarchived
Moved class methods to scope rails flavour.
Removed Template::get_public_published_template_versions method
Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects
added customize method to model
updated customize to use new deep_copy and added some tests
fixed test
fixed broken tests after latest PR. DMPRoadmap/roadmap#1341
generate_version with unit test associated
customize with unit test associated
upgrade_customization first attempt
added tests for upgrade_customization
upgrade_customization with several unit test associated
added generate_copy
fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize
added comments
finished up tests
Removed template.update! in favour of a more re-usable deep_copy with atomic saving.
removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method
renamed to bang notation generate_copy, generate_version, customize and upgrade_customization
question mark methods for generate_version, customize and upgrade_customization
unique indices for template and template customisations. #1341
init functionality for versionable concern
updated errors, added get_new
unique indices for template and template customisations. #1341
new schema dump generated from rails
manually set up the default for org.links
Fix for rake tasks
updated template controller and tests
finished tests for template controller update http verbs for customize and copy methods
updated template versioning intgeration to use new test_helper methods
updated template controller and tests
finished tests for template controller update http verbs for customize and copy methods
updated template versioning intgeration to use new test_helper methods
wired in the new versionable concern
wired in the new versionable concern
updated query structure in template_filter
updated routes and paths
moved phases controller to org_admin namespace
changes to phase model and unit tests
started moving phase views to new org_admin namespace and tests
fixed tests
started fixing up references to moved plan/phase status
started fixing up references to moved plan/phase status
moved js file, fixed tests and manually checked pages
set schema.rb back to sprint2
added in versionable concern and fixed tests
removed unused phase_status method
removed test for phase_status method
fixed issue with template visibility for the default template
fixed issue with default templates and versioning/customization
versionable_test.rb
versionable concern updated
find_or_generate_version! into template, test associated
annotation and question model using has_one through adequately
templates_controller#update action refactored
tweaks to template_test
get_new and get_modifiable test cases for RuntimeError capture
passing parent object ids to children during deep_copy
updated question_option and annotation deep copy
removed old deep_copy method from section model and updated unit tests
removed old deep_copy method from section model and updated unit tests
updates to sections controller, model, routes and tests
fixed broken tests
updated both phases and sections controller to use versionable
fixed tests
started work on new template show/edit
finished up templates UI
fixed tests
consolidated form
consolidated form
fixed history page
removed old view
fixed test
fixed typo in en_US app.po
removed old deep_copy method from section model and updated unit tests
updates to sections controller, model, routes and tests
fixed broken tests
updated both phases and sections controller to use versionable
fixed tests
fixed tests and missing policy
fixed tests
created separate routes for each template index tab
updates to template index page structure
added callback to template model to ensure only one published version
finished up first pass of templates index page
fixed tests
removed current_tab from phase views. DMPRoadmap/roadmap#1407
section#create refactored. DMPRoadmap/roadmap#1407
sections loaded on demand for a phase. DMPRoadmap/roadmap#1407
ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407
added phase/section/question overview back to template details page
send customizer to show section page
updated button text
updated history controller action
updated controller
updated views
added customization distinction to page title
updates to phase/section to introduce referrer logic and added section-show for customizable
removed old 'edit phase details button
removed edit question partial from section show
tweaks to templates index pages
fixed tests and default scope
added test for default customizations
added namespace to org section of templates index and made autocomplete combobox aware of form namespace
fixed issue with container view
removed old policies
updated statuses of templates
fixed typo in phases/overview view. DMPRoadmap/roadmap#1377
annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377
annotations_controller#(create|update|destroy) with test associated. DMPRoadmap/roadmap#1377
flash notice for successful action carried out. DMPRoadmap/roadmap#1377
flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377
started refactor of sections/questions
fixed nil references. DMPRoadmap/roadmap#1462
annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462
commented out version check on template update
removed invalid test
fixed reference to moved partials and family to family_id
fixed question update
updated guidances to work with modified themes form
finished up questions
fixed broken tests
updated preview and customize
fixed issue with sections index
cleaned up remaining issues with template editing and customization
added in check for nil phase to sections create
any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483
updated history to use new template.draft? logic to determine when to show draft icon
added latest check
added check for default option
added checks for historical and customization on preview page
added redirect to show if template is customization
added redirect to show if template is customization
updated ajax success/error for section display
fixed issues with create plan template selection and changing plan visibility
forgot to include model change
reverted schema.rb changes
adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495
improved customization template search against all funder templates. DMPRoadmap/roadmap#1499
started work on adding edit/show/new/cancel buttons for questions
added toggle functionality between question show/edit
removed whitespace
made text area the default
updated template statuses
updated class to fix layout
introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502
removed console.log
fixed JS for section/question
annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502
fixed issue with customizating by adding a section/question
removed reload
set focus to first invalid form input
fixed placement of focus for new validation.js
Added joins for customizations table
updated query
fixed initial numbering for new phases/sections
reverted referrer change
made section fields required
added ariatise to new section form
fixed referrer check
fixed inconsistent status message for transfer customization workflow
fixed issue with csv download
fixed csv header
fixed links for customization on history page
updated sections index so new section doesn't show unless its the current template
Added joins for customizations table
added includes to customisable query
fixed issue with paginable history
fixed merge conflicts in templates_controller and questions/_show.html.erb
resolved additional rebase conflict
briley
committed
on 23 May 2018
|
2018-05-16 |
Implemented Notifications
...
updated tests to work with current test infrastructure
forgot to add test file
switched from url to path to correct 'Mixed content https vs http' issues
Quentin Sonrel
authored
on 29 Mar 2018
briley
committed
on 16 May 2018
|
2018-03-20 |
added active flag to users and updated admin users page to allow admin to update the value
...
updated column text
Updated inactive message
updated mailers to exclude inactive users except for sharing and devise emails about their account
added tests for super admin users. added functionality for super admin to edit user info
added org and created columns to users table
swapped in good schema.rb
removed debug line
added new field to schem.rb manually
fixed schema.rb
added button to go back to users and switched from and to &&
fixed typo in schema.rb
briley
authored
on 15 Mar 2018
Brian Riley
committed
on 20 Mar 2018
|
2018-03-13 |
Migration for adding required indices.
Jimmy Angelakos
committed
on 13 Mar 2018
|
Fixes broken tasks and adds two migrations to keep db integrity. DMPRoadmap/roadmap#1210
...
.
.
Jose Lloret
committed
on 13 Mar 2018
|
2018-03-09 |
removed limit statements from schema.rb
Brian Riley
committed
on 9 Mar 2018
|
2018-03-06 |
update schema
xsrust
committed
on 6 Mar 2018
|
2018-02-21 |
fixed issue with phase accordions on template page
...
fixed issue with retaining current template tab
updated urls in test
briley
committed
on 21 Feb 2018
|
2018-02-13 |
migration to add complete flag to plans. #154
...
Integrate pre-fetching plan and phase from 25e2669
after_save callback for answer model with tests. #154
rake task to update completed plans. #154
statistics#completed_plans action done. #154
HTML view for completed plans and tweaks to JS file associated. #154
Jose Lloret
committed
on 13 Feb 2018
|
2018-01-23 |
Change long strings to text in DB
Jimmy Angelakos
committed
on 23 Jan 2018
|
2017-12-08 |
Make templates page usable for Org Admins and Super Admins
...
started work on super admin templates page
consolidated org_admin and super_admin templates page
moved template logic to org_admin module and consolidated logic for super/org admins
switched from submit button click to form submit
fixed issue with unused js var
fixed broken templates controller tests
switched back to submit button
updated template_options route in integration test
fixed broken integration tests caused by moving templates to org_admin namespace
added tests for copy template
added button to get back to 'all templates' page from template edit page
renamed delete button from 'Cancel' to 'Delete' and added proper cancel button to edit section view
made recommended adjustments and accounted for new template visibility functionality
switched out scopes in favor of flagshihtzu helpers
moved link to Themes to Admin menu
fixed broken tests for the public_pages controller
fixes for tests
refactored template current version queries
pulled in customization view changes
briley
authored
on 27 Nov 2017
Brian Riley
committed
on 8 Dec 2017
|
2017-11-27 |
concern to validate and parse an array of object links. DMPRoadmap/roadmap#819
...
validator for links attribute at templates. DMPRoadmap/roadmap#819
funder and sample links visible in funder templates html view. DMPRoadmap/roadmap#819
links view and its JS associated. DMPRoadmap/roadmap#819
Jose Lloret
committed
on 27 Nov 2017
|
2017-11-22 |
Org Admin provide feedback
...
Add Plans page to Org Admin section
added org admin plans page
finsihed up org admin plans page
added feedback complete and updated emails to use email_signature partial
refactored access checks on Plan now that user can have multiple roles (reviewer + ?)
finished feedback completion routine
added tests for new feedback methods
fixes for merge conflicts
fixed issues with plan and user changes
fixed issue with notes controller test
fixed issue with phase controller test
briley
authored
on 16 Nov 2017
Brian Riley
committed
on 22 Nov 2017
|
2017-11-13 |
Added Request Feedback button to the share plan page
...
modifications to tooltips and email defaults
moved email constants to usermailer
aded missing colon
started adding in the button to request feedback
modifications to tooltips and email defaults
started adding in the button to request feedback
finsihed adding request feedback button
Removed old comment
switched to roles
updated to role based reviewer
updated user_mailer
moved feedback confirmation defaults to methods on UserMailer
added default visibility back to schema.rb
made adjustments based on PR feedback
refactored to use flagshihtzu function that returns values for flags
briley
committed
on 13 Nov 2017
|
2017-11-10 |
fixed issues with plan create page
...
moved template_+options method to templates controller
Brian Riley
committed
on 10 Nov 2017
|
2017-11-09 |
removed the default setting from plans.visibility
...
added migration to correct plan visibility
changed to nil
fixed broken tests and added check for branding.yml contact_us_url before overriding rails built in route helper
briley
committed
on 9 Nov 2017
|
2017-10-26 |
Added Feedback Request to Org Details
...
Initial form changes for the New Org Details
added new db components for the org profile tab
split org page into tabs and updated profile form
switched section headers from labels to h3
finished org details tab
added feedback tab
made textarea a tinymce
fixed test broken by org controller update
Added btree back to schema.rb
added foreign keys back to schema.rb
fixed default email for feedback
bhavi
authored
on 24 Oct 2017
briley
committed
on 26 Oct 2017
|