opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / app / views / answers

2018-05-23	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
2018-04-06	5b88834 Browse files » updated to check for blank example answers Brian Riley committed on 6 Apr 2018
2018-04-06	7850aea Browse files » added base_template_org and updated write plan to show correct org in guidance tab ... updated example answers logic added missing code to answers conroller and fixed test Brian Riley committed on 6 Apr 2018
2018-04-04	bb28367 Browse files » added org abbreviation to 'Guidance' sections and added customized example answers ... updated locking logic briley committed on 4 Apr 2018
2018-03-09	Unverified 2468ad1 Browse files » update question heading display Sam Rust authored on 9 Mar 2018 GitHub committed on 9 Mar 2018
2018-03-09	d09cb11 Browse files » Bug fix for #1264 Jimmy Angelakos committed on 9 Mar 2018
2018-03-07	0a67faf Browse files » hid typeahead as not currently working xsrust committed on 7 Mar 2018
2018-03-07	655999b Browse files » visual tweaks xsrust committed on 7 Mar 2018
2018-03-06	993359d Browse files » bugfixes/tweaks xsrust committed on 6 Mar 2018
	b7192a4 Browse files » capture changes xsrust committed on 6 Mar 2018
	d33158c Browse files » rda backend implimented, bugfixing ui/JS xsrust committed on 6 Mar 2018
2018-01-25	d6dcbff Browse files » Removed circular tick icon progress indicators from each section in write plan. DMPRoadmap/roadmap#867 ... Ensure the question text comes before an example answer. DMPRoadmap/roadmap#867 Made the "Answered X mins ago" alert smaller. DMPRoadmap/roadmap#867 drew a line between questions to visually demarcate one from another. DMPRoadmap/roadmap#867 Fixed accordion HTML elements hierarchy and optimised expandCollapseAll. DMPRoadmap/roadmap#867 Reinstate borders around active areas. DMPRoadmap/roadmap#867 Ensure edges are consistent throughout UI - sharp not curved. DMPRoadmap/roadmap#867 Ensure edges are consistent throughout UI - sharp not curved. DMPRoadmap/roadmap#867 example answer for plans tweaked. Answer status html refactored. DMPRoadmap/roadmap#867 fixes problem rendering tinymce when a stale answer is found. DMPRoadmap/roadmap#867 refactored styles into classes. DMPRoadmap/roadmap#867 . Jose Lloret committed on 25 Jan 2018
2017-12-05	ea5cfbc Browse files » removed after_create callback for answers since no longer is needed after introducing transactions. DMPRoadmap/roadmap#893 ... unit test for answer#is_valid?. DMPRoadmap/roadmap#893 answer#update based on current_user. input text for answer based on either answer.text or question.default_text. DMPRoadmap/roadmap#893 renamed answers#update to answers#create_or_update and added new tests. DMPRoadmap/roadmap#893 Jose Lloret committed on 5 Dec 2017
2017-11-16	ff6c9f0 Browse files » phases edit view and its sub-templates using local variables instead of instance variables. DMPRoadmap/roadmap#677 ... conditional displaying of sub-templates at edit phase. This permits being re-used when previewing a template phase. DMPRoadmap/roadmap#677 Improved views logic. Conditional event handlers for when user does not have permissions to edit plan answer. DMPRoadmap/roadmap#677 Jose Lloret committed on 16 Nov 2017
2017-10-26	e6664c4 Browse files » after_create plan callback for saving answers. TODO error handling at answers#update. DMPRoadmap/roadmap#530 ... error handling for when an answer does not exist. DMPRoadmap/roadmap#530 error handling for answering questions. DMPRoadmap/roadmap#530 optimistic locking fixed. DMPRoadmap/roadmap#530 fixed tests after create callback for answers. Refactored answers js file. DMPRoadmap/roadmap#530 Jose Lloret committed on 26 Oct 2017
2017-10-23	5101006 Browse files » answered time set appropriately. timeago.js included under vendor.js file. DMPRoadmap/roadmap#742 Jose Lloret committed on 23 Oct 2017
2017-10-20	fc335e6 Browse files » label question not answered yet removed. DMPRoadmap/roadmap#742 Jose Lloret committed on 20 Oct 2017
2017-10-10	a76bb48 Browse files » Removed unused views and renamed ones in annotations/templates until those pages have been Bootstrapped DMPRoadmap/roadmap#667 ... Removed unused views and renamed ones in annotations/templates until those pages have been Bootstrapped DMPRoadmap/roadmap#667 moved plan navigation partial from shared to plans dir removed old es5 version of org details JS. was causing JS compilation issues fixed typos in location of plan nav partial removed unused views and renamed a few in annotations and templates until those pages have been bootstrapped and we can confirm they are not needed. switched API docs link to point to wiki docs added template history view back in. remove token_permission_type controller and test. it was being used to list the API permission types and was linked from the 'How to use API' link. Updated that link to point to Wiki docs added answer locking partial and phase preview back added question preview back converted popovers/tooltips on guidance group pages briley committed on 10 Oct 2017
2017-09-11	5b7b419 Browse files » DMPRoadmap/roadmap#562 ... edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller Jose Lloret committed on 11 Sep 2017
2017-08-09	a64c1e3 Browse files » tinymce refactoring for notes using JS. DMPRoadmap/roadmap#571 ... tinymce refactoring for notes using JS. DMPRoadmap/roadmap#571 tinymce refactoring for answers using JS. TODO adding events. DMPRoadmap/roadmap#571 tinymce gem removed from any view. DMPRoadmap/roadmap#571 tinymce answer events for editor working. DMPRoadmap/roadmap#571 fixed typos in js.erb template. DMPRoadmap/roadmap#571 extend renamed to define since more appropiate. DMPRoadmap/roadmap#571 Jose Lloret committed on 9 Aug 2017
2017-08-07	9a5b5cc Browse files » front-end dependencies handled through npm. DMPRoadmap/roadmap#551 Jose Lloret committed on 7 Aug 2017
2017-07-25	13ea438 Browse files » reintroduced auto-save functionality to write plan page DMPRoadmap/roadmap#535 briley committed on 25 Jul 2017
2017-07-24	57f3132 Browse files » removed old references to no-colon class since they are no longer applicable briley committed on 24 Jul 2017
2017-07-20	8dad99d Browse files » finished up rework of write plan page DMPRoadmap/roadmap#494 briley committed on 20 Jul 2017
2017-07-20	3f04417 Browse files » fixed styling issues on comments tab. updated section title to use primary color DMPRoadmap/roadmap#494 briley committed on 20 Jul 2017
2017-07-19	6a1e258 Browse files » initial redesign of write plan page DMPRoadmap/roadmap#494 briley committed on 19 Jul 2017
2017-07-18	1fae810 Browse files » started work on plan write redesign briley committed on 18 Jul 2017
2017-06-22	adbef72 Browse files » auto-saving working but needs some improvement. DMPRoadmap/roadmap#438 ... auto-saving debounce function per form and considering optimistic-locking. DMPRoadmap/roadmap#438 Added focus handler for textarea in order to also cancel debounce. DMPRoadmap/roadmap#438 Jose Lloret committed on 22 Jun 2017
2017-06-19	92c8ac4 Browse files » Fixed problem of loading tinymce styles for production environment. Jose Lloret committed on 19 Jun 2017
2017-06-07	c838c54 Browse files » Changed error text - closes #382. Jimmy Angelakos committed on 7 Jun 2017