fixed issues with ariatiseForm

fixed merge issue

switched back to allowing multiple themes per guidance and fixed error display for 'accept terms' on create account form ...

updated tooltip

fixed issue with checkbox error display, removed old JS for create account form, fixed create account form namespacing (#1686)

updated ariatise validation JS logic to work with radio fieldset legends (#1649)

Fixed issues with Public Template page sorting and form validations (#1621) ...

* fixed final issue with public template sort

* switched from aria-describedby to validation-help-block

* fixed remaining issues

switched guidance themes from checkboxes to radio buttons (#1608) ...

ported radio button logic to validation.js

updated shared tehemes partial to allow 'required' and 'asRadio' arguments. Also fixed bug with removing all theme selections on question form and added 'no themes selected' message

fixed typo and renamed asRadio to as_radio

Template Versioning ...

This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed.

------------------------------------------------------------

removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests

started updating model scopes and began creating new unit tests and test_helper methods

Rebased with template customization fixes. updated tests and latest_version queries

Grouping class methods. Grouping scope methods into separate class

removed Template::valid scope method in favour of Template::unarchived

Moved class methods to scope rails flavour.

Removed Template::get_public_published_template_versions method

Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects

added customize method to model

updated customize to use new deep_copy and added some tests

fixed test

fixed broken tests after latest PR. DMPRoadmap/roadmap#1341

generate_version with unit test associated

customize with unit test associated

upgrade_customization first attempt

added tests for upgrade_customization

upgrade_customization with several unit test associated

added generate_copy

fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize

added comments

finished up tests

Removed template.update! in favour of a more re-usable deep_copy with atomic saving.

removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method

renamed to bang notation generate_copy, generate_version, customize and upgrade_customization

question mark methods for generate_version, customize and upgrade_customization

unique indices for template and template customisations. #1341

init functionality for versionable concern

updated errors, added get_new

unique indices for template and template customisations. #1341

new schema dump generated from rails

manually set up the default for org.links

Fix for rake tasks

updated template controller and tests

finished tests for template controller update http verbs for customize and copy methods

updated template versioning intgeration to use new test_helper methods

updated template controller and tests

finished tests for template controller update http verbs for customize and copy methods

updated template versioning intgeration to use new test_helper methods

wired in the new versionable concern

wired in the new versionable concern

updated query structure in template_filter

updated routes and paths

moved phases controller to org_admin namespace

changes to phase model and unit tests

started moving phase views to new org_admin namespace and tests

fixed tests

started fixing up references to moved plan/phase status

started fixing up references to moved plan/phase status

moved js file, fixed tests and manually checked pages

set schema.rb back to sprint2

added in versionable concern and fixed tests

removed unused phase_status method

removed test for phase_status method

fixed issue with template visibility for the default template

fixed issue with default templates and versioning/customization

versionable_test.rb

versionable concern updated

find_or_generate_version! into template, test associated

annotation and question model using has_one through adequately

templates_controller#update action refactored

tweaks to template_test

get_new and get_modifiable test cases for RuntimeError capture

passing parent object ids to children during deep_copy

updated question_option and annotation deep copy

removed old deep_copy method from section model and updated unit tests

removed old deep_copy method from section model and updated unit tests

updates to sections controller, model, routes and tests

fixed broken tests

updated both phases and sections controller to use versionable

fixed tests

started work on new template show/edit

finished up templates UI

fixed tests

consolidated form

consolidated form

fixed history page

removed old view

fixed test

fixed typo in en_US app.po

removed old deep_copy method from section model and updated unit tests

updates to sections controller, model, routes and tests

fixed broken tests

updated both phases and sections controller to use versionable

fixed tests

fixed tests and missing policy

fixed tests

created separate routes for each template index tab

updates to template index page structure

added callback to template model to ensure only one published version

finished up first pass of templates index page

fixed tests

removed current_tab from phase views. DMPRoadmap/roadmap#1407

section#create refactored. DMPRoadmap/roadmap#1407

sections loaded on demand for a phase. DMPRoadmap/roadmap#1407

ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407

added phase/section/question overview back to template details page

send customizer to show section page

updated button text

updated history controller action

updated controller

updated views

added customization distinction to page title

updates to phase/section to introduce referrer logic and added section-show for customizable

removed old 'edit phase details button

removed edit question partial from section show

tweaks to templates index pages

fixed tests and default scope

added test for default customizations

added namespace to org section of templates index and made autocomplete combobox aware of form namespace

fixed issue with container view

removed old policies

updated statuses of templates

fixed typo in phases/overview view. DMPRoadmap/roadmap#1377

annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377

annotations_controller#(create|update|destroy) with test associated. DMPRoadmap/roadmap#1377

flash notice for successful action carried out. DMPRoadmap/roadmap#1377

flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377

started refactor of sections/questions

fixed nil references. DMPRoadmap/roadmap#1462

annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462

commented out version check on template update

removed invalid test

fixed reference to moved partials and family to family_id

fixed question update

updated guidances to work with modified themes form

finished up questions

fixed broken tests

updated preview and customize

fixed issue with sections index

cleaned up remaining issues with template editing and customization

added in check for nil phase to sections create

any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483

updated history to use new template.draft? logic to determine when to show draft icon

added latest check

added check for default option

added checks for historical and customization on preview page

added redirect to show if template is customization

added redirect to show if template is customization

updated ajax success/error for section display

fixed issues with create plan template selection and changing plan visibility

forgot to include model change

reverted schema.rb changes

adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495

improved customization template search against all funder templates. DMPRoadmap/roadmap#1499

started work on adding edit/show/new/cancel buttons for questions

added toggle functionality between question show/edit

removed whitespace

made text area the default

updated template statuses

updated class to fix layout

introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502

removed console.log

fixed JS for section/question

annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502

fixed issue with customizating by adding a section/question

removed reload

set focus to first invalid form input

fixed placement of focus for new validation.js

Added joins for customizations table

updated query

fixed initial numbering for new phases/sections

reverted referrer change

made section fields required

added ariatise to new section form

fixed referrer check

fixed inconsistent status message for transfer customization workflow

fixed issue with csv download

fixed csv header

fixed links for customization on history page

updated sections index so new section doesn't show unless its the current template

Added joins for customizations table

added includes to customisable query

fixed issue with paginable history

fixed merge conflicts in templates_controller and questions/_show.html.erb

resolved additional rebase conflict

added an excludeAsterisks option to AriatiseForm and validation JS files. Also updated 2 gettext strings to allow for embedded HTML

consolidated question edit/new js so that ariatise and tinymce are only invoked once ...

updated timing of validation checks on ariatiseForm because they were firing before Tinymce was transfering its contents to the textarea

added asterisk to JS that handles form validations

removed ariatise from js that did not have any fields defined yet

applied requested changes

moved constants to application.html.erb

List of default templates of type organisation with is_default to true. DMPRoadmap/roadmap#612 ...

fixed non-valid files after running eslint. DMPRoadmap/roadmap#612

add lint to npm scripts. DMPRoadmap/roadmap#612

Fixed issue with checkbox form validation DMPRoadmap/roadmap#686 ...

added checkbox handling to ariatiseForm

moved branding and plan visibility settings from application.rb to initializers/constants.rb

moved plan settings back to application.rb

Bootstrapped the Guidances and Guidance Groups pages and copnverted ES5 to ES6 DMPRoadmap/roadmap#645 ...

added select and tinymce to ariatiseForm. Bootstrapped guidances and new guidance pages

added tinymce to ariatiseForm, bootstrapped the new and edit guidance pages

bootstrapped the guidance_groups pages

fixed typos on terms page

Bug fixes to the create account/sign in/reset password/shib DS pages ...

fixed JS issues on shibboleth_ds and bootstrapped page

added js-cookie and fixed remember-email functionality

fixed issue with random empty notices appearing

added documentation to ariatiseForm and updated create account form

Boostrapped the create plan page. DMPRoadmap/roadmap#632 ...

- Converted JS for page over to ES6
- Added stub test and fixture
- Converted jquery autocomplete combobox to Bootstrap and ES6

TODO:
- Add in AJAX calls to retrieve template options based on org/funder selections
- Fix issue with the hidden id field being updated when combobox item is selected
- Finish tests for the autoComplete.js

Bootstrapped Plan Writing and Download pages (#88)

* DMPRoadmap/roadmap#issue567
* DMPRoadmap/roadmap#issue561

- Bootstrapped the Write Plan page accordions
- Rebased with latest from CDL-MVP

bootstrapped the phases accordion DMPRoadmap/roadmap#567

added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap/roadmap#567

finished Bootstrapping write plan accordions DMPRoadmap/roadmap#567

fixed linter issue DMPRoadmap/roadmap#issue567

fixed linter issue

* Bootstrapping and ES6 of the Plan Download page DMPRoadmap/roadmap#561.
- Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route)
- Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes)
- Bootstrapped page html

changed name of show_export to download to match UI terminology. Bootstrapped download page

Added ES6 JS for download page and made tweaks to the format

* DMPRoadmap/roadmap#562
edit phases using plan navigation layout

bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse

answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js

Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor

fixed broken test regarding answers_controller

* fixed linter issue with CRLF

* fixed tests broken by name change from show_export to download.

added JS tests for expandCollapseAll accordion functionality

fixed linter complaint about double vs single quotes in test

removed a few empty and unused views. removed old es5 js for create plan page. bootstrapped the create plan page

boostrapped the create plan page. converted jquery autocomplete to ES6 and bootstrap. started adding JS tests

removed unfinished tests for autocomplete, will finihs after demo. added comments to autoComplete.js

1. click ariatiseForm preventDefault only once now ...

2. removed dependency karma-jasmine-jquery in favour of plain jasmine-jquery
3. fixed ariatiseFormSpec by bundling the fixtures to the body of the window currently executing
4. moved tinymceSpec.js to the new place for Spec

moved view js back into individual views files

Fixed linter problems and improved some JS lines. DMPRoadmap/roadmap#558

moved view specific es6 js to top level views dir. added validation for radio buttons. ariatised plan share page DMPRoadmap/roadmap#560

fixed linter issue in ariatiseForm.js DMPRoadmap/roadmap#558

added ES6 JS for sign in and create account forms DMPRoadmap/roadmap#558

created added matchingPasswordValidator and wired up ES6 devise.js DMPRoadmap/roadmap#558

Added DomManipulator and ariatiseForm

changed let to const DMPRoadmap/roadmap#558

converted ariatiseForm over to ES6 and added new validation messages to constants DMPRoadmap/roadmap#558

is module and travis configuration tweaked. DMPRoadmap/roadmap#601 ...

is module and spec. Set up karma for unit test. DMPRoadmap/roadmap#601

Added constants, isValidInputType and debounce as ES6 modules. DMPRoadmap/roadmap#601

Modified documentation and logic operators. DMPRoadmap/roadmap#554

Contact us bootstrapped and with aria attributes controller through JS. DMPRoadmap/roadmap#554 ...

Contact us using dmproadmap.utils.ariatiseForm for validation states at control forms and taking into account aria. DMPRoadmap/roadmap#554

Removed console.log. DMPRoadmap/roadmap#554