remove unneeded comments, remove further references to reviewer role from tests, dry up refactored tests

Merge branch 'development' into feature/reviewer_role

removed references to role.reviewer

refactored review access from role to permission

Merge pull request #2127 from DMPRoadmap/issue2090 ...

Allow org admins to view 'share plan' page.

capture progress

Allow org admins to view 'share plan' page. ...

Changes:
 - Updated share? method in the class PlanPolicy.
 - Also fixed Rubocop warnings in PlanPolicy.
 - Updated _navigation.html.erb and _share_form.html.erb
   to enable org admins to view the Share tab of org plans.

Fix for #2090.

Merge pull request #2124 from DMPRoadmap/issue2089 ...

Pre-fill ID on the plan details page.

Merge pull request #2122 from DMPRoadmap/issue2094 ...

Changed date format of footer in the Plans pdf export to a more human…

Pre-fill ID on the plan details page. ...

Changes:
  - the default plan :identifier is set to the plan :id on creation in the
    PlanControllers create method.
  - added a method add_identifier to Plan model.

Fix for issue #2089

Changed date format of footer in the Plans pdf export to a more human readable date, ...

e.g., "Last modified 26 April 2019".

Changes:
  - added :readable date format to language locales
  - used this date for the footer in the Plans pdf export.
    Note, changed " formats" to "format" and use :readable in footer date
     From  "date: l(@plan.updated_at.to_date, formats: :short)" -->
     to    "date: l(@plan.updated_at.to_date, format: :readable)"
  - to pass Rspec test spec/features/plans/exports_spec.rb we needed to add
    a locale file en.yml  which is a copy of en-GB.yml to avoid error
    "1) PlansExports User downloads their plan as PDF
     Failure/Error: date: l(@plan.updated_at.to_date, format: :readable)

     I18n::MissingTranslationData:
       translation missing: en.date.formats.readable"

Fix for Issue #2094.

updated user search after invitation to be case-insensitive

Fix for a bug in the StatCreatedPlan model that was causing the following error ...

File /opt/src/dmponline_dev/app/models/stat_created_plan.rb line 24 in by_template
    Show 9 non-project frames
    File /opt/src/dmponline_dev/app/controllers/stat_created_plans_by_template_controller.rb line 14 in index

Added a check for variable details presence in the by_template method in app/models/stat_created_plan.rb

Complete merge Development -> Master

Table View Issue for Readonly Content of Plan and Template pages. ...

Changes:
- to re-style the readonly text tables with padding
- added the TinyMCE like styling to the Phase overview description

Fix for #2071.

Table View Issue for Readonly Content of Plan and Template pages. ...

Added a div to emulate the styling for TinyMCE text area around readonly text content for phases and question labels.

    Fix for #2071.

Table View Issue for Readonly Content of Plan and Template pages. ...

Added a div to emulate the styling for TinyMCE text area around readonly text content for answers, annotations, guidance, etc.

Fix for #2071.

Added code to make Search functionality case-insensitive. ...

Changes:
   - relevant models with :search scope updated with lower casing  of the column
     values and the search parameters.
   - fixed all rubocop warnings on the changed models except
     "Style/RedundantReturn: Redundant return detected."

   Note: one could not use 'ILIKE' in WHERE clauses changed as it is not supported by MariaDB and MySql.
   Hence we use lower() in changed WHERE clauses.

 Fix for issue #2080

The content of TinyMCE text area data viewed in readonly mode without thv TinyMCE editor had styling issues. ...

Added styling from TinyMCE to ensure that the readonly display had a similar overflow in y direction and table borders visible.

Fix for issue #2071.

Updated Usage page display to fix several issues. ...

- Moved mouse pointer instruction.
    - Made textual changes to "No. of plans by template"
    - The bar charts for  "No. users joined during last year" and
    "No. plans during last year" months are in ascending order. They were
    in descending order previously. Updated the count statistics methods
    in statistics_controller.rb.
    - The "No. plans by template" bar chart is now  replaced by a stacked bar chart
    as this is visually better for large data.
    - updated the by_template method in the create_or_update.rb with code from @xsrust.
    This now aggregates template counts for a month correctly.

    Fix for issue #1679.

Restyled Usage page: ...

- The 'No. of plans by template" section restyled
 - Added instruction to 'No. of plans by template'
 - Added a message for 'No. of plans by template' chart if
 no data available for a chosen time period.

Fix for changes requested in issue #1679.

The "No. plans by template" statistics and visualisation changes: ...

(1) The headers for the CSV for the Number of Plans by Template
             - the date column have dates in the format  'Jan 2018'
             - the template headers now display the Title of the templates
             - the Date and Count headers are capitalized.

        (2) The chart has been re-styled.
            The aspect ratio (width/height) of image is now dynamically
            set according to the selection of the month range.

        (3) Fixed broken rspec tests and rubocop errors/warnings.

        Fix for #1679.

Merge pull request #2065 from DMPRoadmap/issue1158 ...

Thanks @briri.

Merge branch 'issue1158' of https://github.com/DMPRoadmap/roadmap into issue1158

Updated css to try to help with datepicker next/prev buttons

Updated the new Comment notification email text. ...

Fix for #1872

Merge branch 'development' into issue1158

fix bugs with API: re-add date filtering, revert assumption of last month by default, re-add instance variables, fix other minor bugs

Added missing icons and fot to asset folder. ...

Fixed a JS missing dagling comma issue in datepicker.

pulled down jquery-ui custom theme for datepicker to try and get icons to work