Merge branch 'master' into development

Display issue (cropped answers & whitespace) when reviewing DMPs when answers in (#2023) ...

readonly mode.

Fixes issue #1683.

When the review mode is readonly, then we display the answer in in a paragraphs.

added logic to hide guidance selection if there is no selectable guidance (#2021) ...

fixed typos

made question themed guidance accordion ids more specific (#2022)

updated call to Plan.readable_by? (#2019)

added table prefix to column sorts (#2017)

updated sessions controller to no longer set shibboleth_id field on user account, changed devise registrations/new so the js could find the create-account-form.

Further changes for Text field should be mandatory for option based questions. ...

Fix for issue #1725

The question_options field on the Customisable Phase template has the
following changes:
- the 'Text' label has the asterick for required.
- the error message for missing question option now reads
 "You must have at least one option with accompanying text."
- Corrected some Rubocop errors on the files added.

Patch issue with share plans on development ...

Devise circumvents running validations on the user models when invite! is called.
I updated this call to adhere to validations, and I've updated the form to request the name,org of the user when a plan is shared with them.
This should fix the issue for both newly created share-plan users, and those with previous, bad data in the system.

You may want to consider re-running your validations(or fixup) scripts for users as you can have some invalid ones that you'll need to set a default name/org

Merge branch 'development' into issue1663

Merge pull request #1994 from DigitalCurationCentre/issue1391 ...

Issue1391

updated Role, Plan logic and fixed tests

Updated JS for requiredField to allow for dynamically loaded DOM elements (#1996) ...

* IssueID #1725 - Updated messages Question text and option presence messages.

* updated requiredField.js to allow for dynamically loaded DOM elements

* fixed broken tests

#1371 More specific selector for usage statistics export button

Issue #1931 - Share plan emails updated. ...

- The inviter name is added to the devise file app/views/devise/mailer/invitation_instructions.html.erb
- The name of person invited the plan is shared with is added to the greeting if it exists for both the devise
and non-devise emails (repectively app/views/devise/mailer/invitation_instructions.html.erb and app/views/user_mailer/sharing_notification.html.erb).
Otherwise, the invited person's email is displayed in the greetings.

Fix for #1931

Merge pull request #1990 from DMPRoadmap/issue-1164 ...

Issue #1164 - Styling for Download and Date columns in table.

Issue #1164 - Styling for Download and Date columns in table. ...

- Used an existing class .date-column to fix date column min-width and
   added it to all the table date columns.
 - Added a  class .download-column for download column min-width

 Fix for #1164

1. stat_created_plan.to_csv with option for details by template. ...

2. details attribute for stats table #1679
3. create_created_plan_service extended with details by template
4. create_last_month_created_plan_service extended with details by
template.
5. create_or_update strategy for generating stats
6. StatCreatedPlanByTemplateController#index for graphs usage
7. month_start_date and month_end_date for OrgDateRangeable class

[RD-1679] Usage view including date input for plans by template

[#1679] monthly_range query updated

[#1679] client-side chart for plans by template

[#1679] Time picker for plans by template chart

[#1679] Download plans by template action.

deleted spec

merge conflicts fixed

[#1679] Removed JS linter warnings

[#1679] Rubocop conforming code. Drying out stat services

Issue #1161 - Display tooltip below form fields on Create plan page. ...

- Required modification for the intiialization of Bootstrap tooltips in the javascript file
      /utils/tooltipHelper.js. The default behaviour is placement of tooltip to the right of element
      with attribute data-toggle='tooltip'. Now if the attribute data-placement attribute is set,
      then the placement of the tootip will be as specfied in the attribute and not on the right (the default behaviour).
    - The accessible combob-box now takes an optional property 'placement' which if present sets data-placement
      attribute to the value of the placement property.
    - Now all Create Plan page tooltips are below the input as requested.

Fix for #1161.

Changed links to icons for file download. ...

- Using fontawesome icons file-pdf-o and file-word-o

    Fix for Issue #1164

Add support for AWS file storage with Dragonfly ...

Fixes #1976

updated calls to user paginable controller (#1971)

fixed issue with args in translatable:find (#1963) ...

fixed issue with translatable text having a newline between the closing quote and the closing paren

fixed issues with translatable text in planscsv export and sharing notification

fixed issue with translatable on templates controller

fixed issue with multiline strings in translatable:find

fixed issue with multiline strings in translatable:find

cleaned up en-US translations

Fix webpacker configuration

Update asset structure with webpacker gem

Merge pull request #1947 from DigitalCurationCentre/issue/1937 ...

updated usage dashboard layout, minor spacing tweaks in css

Merge pull request #1945 from DigitalCurationCentre/issues/1844 ...

added hidden field to plan_export_form, updated controller auth logic…

Merge pull request #1944 from DMPRoadmap/issue-1940 ...

Rewrite tooltip for draggable sections

updated stat download button text

added handler for local dev/test and updated if statement to prevent local paths from redirecting