opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / app / policies

2019-08-21	e91afdc Browse files » capture status Sam Rust committed on 21 Aug 2019
2019-06-20	6e6f254 Browse files » Fix for issue associated with super-admins and department affiliation in a given organisation. (#2165) ... Changes made: - Department policies now allow both org admins and super admins to create update and delete departments, whilst org_admins can only do this for their own org. Super admins can do it for any org department. - When a super admin switches organisation their department_id is cleared. Fix for issue #2088. John Pinto authored on 20 Jun 2019 Sam Rust committed on 20 Jun 2019
2019-06-04	6b2c612 Browse files » Add functionality for School/Department for an organisation. ... Changes: - added a Department model whose instances belong to an org and require name. - added a DepartmentController and views for create, edit/update and a index view which is a tab of 'Organisational Details'. - added the optional attribute department_id to User model. - added Rspec tests. - updated app/controllers/registrations_controller.rb, app/models/org.rb and app/models/user.rb to get rid of outstanding Rubocop warnings Fix for issue #2088. John Pinto committed on 4 Jun 2019
2019-05-15	d3493c4 Browse files » added plans fulltext api using pagination Sam Rust committed on 15 May 2019
2019-05-09	Unverified 0f24533 Browse files » Merge pull request #2121 from DMPRoadmap/issue/2118 ... updated permissions and routing around public template export Sam Rust authored on 9 May 2019 GitHub committed on 9 May 2019
2019-05-08	Unverified 1f25a28 Browse files » Merge branch 'development' into feature/reviewer_role Sam Rust authored on 8 May 2019 GitHub committed on 8 May 2019
2019-05-07	7e56eb3 Browse files » refactored review access from role to permission Sam Rust committed on 7 May 2019
2019-05-03	d571dc4 Browse files » Allow org admins to view 'share plan' page. ... Changes: - Updated share? method in the class PlanPolicy. - Also fixed Rubocop warnings in PlanPolicy. - Updated _navigation.html.erb and _share_form.html.erb to enable org admins to view the Share tab of org plans. Fix for #2090. John Pinto committed on 3 May 2019
2019-05-01	9c68fdd Browse files » remove auth verification on public_pages, update model accessors to ? methods Sam Rust committed on 1 May 2019
2019-04-30	2bf38d8 Browse files » updated permissions and routing around public template export Sam Rust committed on 30 Apr 2019
2018-08-17	Unverified 14d1c2a Browse files » Refactor routes for better maintainability ... - Remove redundant routes (Fixes #1699, Fixes#1570) - Remove redundant actions - Remove redundant policy methods - Fix invalid actions (public methods defined on controllers) - Set concern methods as private - Extract session locale method from ApplicationController into its own controller - Explicitly define actions in statics controller for better readability Bodacious committed on 17 Aug 2018
2018-07-12	Unverified ca4a6ad Browse files » Make sections within a phase sortable Bodacious committed on 12 Jul 2018
2018-05-31	fd47177 Browse files » update_email_preferences action only authorized for signed_in user. DMPRoadmap/roadmap#1514 Jose Lloret committed on 31 May 2018
2018-05-23	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
2018-05-16	a30cf7b Browse files » Implemented Notifications ... updated tests to work with current test infrastructure forgot to add test file switched from url to path to correct 'Mixed content https vs http' issues Quentin Sonrel authored on 29 Mar 2018 briley committed on 16 May 2018
2018-03-20	Unverified 8f453a0 Browse files » Merge pull request #1303 from CDLUC3/issue1275 ... Updates to Super Admin Users page Jose Lloret authored on 20 Mar 2018 GitHub committed on 20 Mar 2018
2018-03-20	77014f5 Browse files » added active flag to users and updated admin users page to allow admin to update the value ... updated column text Updated inactive message updated mailers to exclude inactive users except for sharing and devise emails about their account added tests for super admin users. added functionality for super admin to edit user info added org and created columns to users table swapped in good schema.rb removed debug line added new field to schem.rb manually fixed schema.rb added button to go back to users and switched from and to && fixed typo in schema.rb briley authored on 15 Mar 2018 Brian Riley committed on 20 Mar 2018
2018-03-15	7976e15 Browse files » added check for user's role on a plan to determine if download tab is available briley committed on 15 Mar 2018
2018-02-15	c01ba32 Browse files » fixes for downloads ... updated security check briley committed on 15 Feb 2018
2018-02-12	d9af18f Browse files » fixes to edit user privileges ... fixed test minor changes requested to PR Brian Riley committed on 12 Feb 2018
2018-02-09	b100c1e Browse files » users_joined action re-factored. DMPRoadmap/roadmap# ... completed_plans action started. DMPRoadmap/roadmap#154 usage#index action and server view completed. Started dynamic UI through JS. added moment js library and ajaxified joined_users stats. charts.js integration for users joined. DMPRoadmap/roadmap#154 Jose Lloret committed on 9 Feb 2018
2018-02-08	016fe5c Browse files » User model search scope method concatenating firstname and surname to look for a term. DMPRoadmap/roadmap#1101 ... conditional query depending on the connection adapter. DMPRoadmap/roadmap#1101 Jose Lloret committed on 8 Feb 2018
2018-01-30	dca67c7 Browse files » changes requested by Jose ... fixed test briley committed on 30 Jan 2018
2018-01-29	7111d01 Browse files » added super admin org pages ... turned shib DS off fixed tests fixed tests Brian Riley authored on 27 Jan 2018 briley committed on 29 Jan 2018
2018-01-23	8b8f428 Browse files » guidance section in plan edit page(#943) ... add functional test for the select guidance list modal bhavi committed on 23 Jan 2018
2018-01-19	6beb771 Browse files » public DMPs paginablerised. DMPRoadmap/roadmap#1055 ... public DMPs templates paginablerised. DMPRoadmap/roadmap#1055 plans visible to org admin paginablerised. DMPRoadmap/roadmap#1055 guidances paginablerised. DMPRoadmap/roadmap#1055 guidance_groups paginablerised. DMPRoadmap/roadmap#1055 remove tablesorter class from paginable views. Introduce Clear search results when ALL search results are active. DMPRoadmap/roadmap#1055 guidance policy for paginable/guidance/index/:page. DMPRoadmap/roadmap#1055 Jose Lloret committed on 19 Jan 2018
2018-01-17	8b835a4 Browse files » moved template pagination logic to paginable namespace ... moved logic from concern to lib/filter and fixed tests made template tables sortable updated sort links Brian Riley authored on 12 Jan 2018 briley committed on 17 Jan 2018
2018-01-17	Unverified 61561f3 Browse files » Merge pull request #1039 from CDLUC3/fix-org-plan-query ... Fixed issue with organisationally_publicly_visible scope Brian Riley authored on 17 Jan 2018 GitHub committed on 17 Jan 2018