refactored review access from role to permission

capture progress

add rake-task to update blank or nil plan identifiers with plan_id

Complete merge Development -> Master

The "No. plans by template" statistics and visualisation changes: ...

(1) The headers for the CSV for the Number of Plans by Template
             - the date column have dates in the format  'Jan 2018'
             - the template headers now display the Title of the templates
             - the Date and Count headers are capitalized.

        (2) The chart has been re-styled.
            The aspect ratio (width/height) of image is now dynamically
            set according to the selection of the month range.

        (3) Fixed broken rspec tests and rubocop errors/warnings.

        Fix for #1679.

added date picker

fix to upgrade rake task ...

fix to upgrade rake task

Merge branch 'master' into development

updated Role, Plan logic and fixed tests

1. stat_created_plan.to_csv with option for details by template. ...

2. details attribute for stats table #1679
3. create_created_plan_service extended with details by template
4. create_last_month_created_plan_service extended with details by
template.
5. create_or_update strategy for generating stats
6. StatCreatedPlanByTemplateController#index for graphs usage
7. month_start_date and month_end_date for OrgDateRangeable class

[RD-1679] Usage view including date input for plans by template

[#1679] monthly_range query updated

[#1679] client-side chart for plans by template

[#1679] Time picker for plans by template chart

[#1679] Download plans by template action.

deleted spec

merge conflicts fixed

[#1679] Removed JS linter warnings

[#1679] Rubocop conforming code. Drying out stat services

fixed issue with args in translatable:find (#1963) ...

fixed issue with translatable text having a newline between the closing quote and the closing paren

fixed issues with translatable text in planscsv export and sharing notification

fixed issue with translatable on templates controller

fixed issue with multiline strings in translatable:find

fixed issue with multiline strings in translatable:find

cleaned up en-US translations

Fix missing CSV requirement from Csvable module

Update asset structure with webpacker gem

Refactor validation checking to exclude non-ARs ...

Check for class type to make sure we're only validating on objects
that inherit from ActiveRecord::Base.

Merge pull request #1951 from DMPRoadmap/issue-1949 ...

Fix bug choosing locale with region suffix

Fix bug choosing locale with region suffix

Merge pull request #1947 from DigitalCurationCentre/issue/1937 ...

updated usage dashboard layout, minor spacing tweaks in css

Merge pull request #1943 from DMPRoadmap/issue-1942 ...

Fix bug when sorting draggable sections

added handler for local dev/test and updated if statement to prevent local paths from redirecting

added JS to force external links to openin a new tab

Refactor JS in section sorting ...

Fixes #1939

updated usage dashboard layout, minor spacing tweaks in css

Fix bug when sorting draggable sections

Merge pull request #1932 from DMPRoadmap/refactor/rules ...

Remove data cleanup rules from repo

Merge pull request #1930 from DMPRoadmap/add-db-required ...

Added new find_known_invalidations and updated upgrade tasks

added exception for devise managed users.email to use our homegrown email validator

updated presence check to obey 'ifs' on validators. e.g. feedback_email_subject is required IF feedback_enabled?

Update template to ensure base file and dir

Remove our data cleanup Rules from the repo

updated script name in new v2_0_0_part_1 task