The "No. plans by template" statistics and visualisation changes: ...

(1) The headers for the CSV for the Number of Plans by Template
             - the date column have dates in the format  'Jan 2018'
             - the template headers now display the Title of the templates
             - the Date and Count headers are capitalized.

        (2) The chart has been re-styled.
            The aspect ratio (width/height) of image is now dynamically
            set according to the selection of the month range.

        (3) Fixed broken rspec tests and rubocop errors/warnings.

        Fix for #1679.

updated organisational plans query to only include completed plans to match logic of plan export (#2004) ...

refactored plan.visibility_allowed? to call underlying method on phases

refactored plan.visibility_allowed? to call underlying method on phases

fixed tests

Further changes for Text field should be mandatory for option based questions. ...

Fix for issue #1725

The question_options field on the Customisable Phase template has the
following changes:
- the 'Text' label has the asterick for required.
- the error message for missing question option now reads
 "You must have at least one option with accompanying text."
- Corrected some Rubocop errors on the files added.

finished up changes to controllers

Merge branch 'development' into issue1663

updated Role, Plan logic and fixed tests

refactor plan/role functionality to use flagshihtzu properly

updated deactivate logic

Updated JS for requiredField to allow for dynamically loaded DOM elements (#1996) ...

* IssueID #1725 - Updated messages Question text and option presence messages.

* updated requiredField.js to allow for dynamically loaded DOM elements

* fixed broken tests

moved deactivate logic to Role model and added specs

1. stat_created_plan.to_csv with option for details by template. ...

2. details attribute for stats table #1679
3. create_created_plan_service extended with details by template
4. create_last_month_created_plan_service extended with details by
template.
5. create_or_update strategy for generating stats
6. StatCreatedPlanByTemplateController#index for graphs usage
7. month_start_date and month_end_date for OrgDateRangeable class

[RD-1679] Usage view including date input for plans by template

[#1679] monthly_range query updated

[#1679] client-side chart for plans by template

[#1679] Time picker for plans by template chart

[#1679] Download plans by template action.

deleted spec

merge conflicts fixed

[#1679] Removed JS linter warnings

[#1679] Rubocop conforming code. Drying out stat services

Fix for ensuring that Questions that are option based must have atleast one non-blank text entry. ...

- Validation added for option based questions to ensure text field non-blank.
    - Validation message OPTION_PRESENCE_MESSAGE added to app/models/concerns/validation_messages.rb.
    - Added ':allow_nil => true' to
            delegate :option_based?, to: :question_format, :allow_nil => true
     in Question model to prevent NoMethodError if question_format is nil.

    Fix for #1725

Merge pull request #1982 from DMPRoadmap/fix-karma ...

Moved JS tests and added karma/jasmine for JS tests

moved JS tests to the spec dir and fixed issues with karma/webpack/jasmine ...

added lint and updated bundle task to use yarn

added lint and updated bundle task to use yarn

Changed links to icons for file download. ...

- Using fontawesome icons file-pdf-o and file-word-o

    Fix for Issue #1164

renamed yml examples. added them to bin/setup and added eslint init to travis ...

added eslintrc.json back

moved eslintrc to loaders dir

removed eslint init statement

fixed up eslinter

updated rack and destructured array and object assignments in js. updated release portion of readme

added eslintrc back to gitignore

fixed issue with create plan JS, fixed some warnings in specs

removed console.log statements and updated linter task in travis

Update asset structure with webpacker gem

Fix broken functional tests ...

Fix broken specs with random see 55679

Fix broken tests for random seed 19381

Temporarily disable travis security checks

Since I'm testing the specs, this should help make it faster

Fix bug caused by random Org locale

Fixes recurring issue with tests being loaded in German

Fix broken specs

Fix tests breaking with seed 60029

Fix broken specs with seed 12116

Fix broken specs with seed 51011

Fix broken template upgrades specs

Fix travis artifacts addons

Add Travis asset debugging

Remove Amazon S3 region from asset uploads config

Move S3 configs to local travis file

Re-add hygiene tasks to Travis YML

Disable broken test for now

Refactor tests for template upgrade customisations

Update test suite to allow re-using rand seed ...

Will help in debugging tests that are failing on Travis

Merge pull request #1951 from DMPRoadmap/issue-1949 ...

Fix bug choosing locale with region suffix

Fix bug choosing locale with region suffix

Change column titles in usage CSV download ...

Fixes #1938

Merge pull request #1929 from DMPRoadmap/issue-1853 ...

Fix bug preventing new sections from merging into persisted phases

Merge pull request #1928 from DigitalCurationCentre/data_cleanup_additions ...

update guidance spec to allign with changes to validation logic

updated guidance_spec syntax

Fix bug when upgrading Template with new Sections ...

Section presence validation was preventing Question from being saved. This was preventing
new Sections from being saved.

updated guidance spec to allign with validation changes

Fix how section number is set

Fix how section number is set

Fix bug in upgrade customization when new section ...

Adding a new section to the customized template was conflicting with the number value
on the corresponding funder template section.