opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / app / views / plans

2018-08-16	Unverified 99fea80 Browse files » Deprecate non-idiomatic helper method name Bodacious committed on 16 Aug 2018
2018-08-03	a6d9361 Browse files » Added missing VALID_FORMATS settings to models/settings/template.rb. ... Update package name for VALID_FORMATS in _download_form.html.erb. John Pinto committed on 3 Aug 2018
2018-07-13	Unverified 1b8eb1f Browse files » Make feedback email message html safe again ... Fixes bug added in previous request. Gavin Morrice authored on 13 Jul 2018 GitHub committed on 13 Jul 2018
2018-07-13	Unverified fa1dc2f Browse files » Fix bug when org feedback email message is nil Bodacious committed on 13 Jul 2018
2018-07-12	Unverified 2649de1 Browse files » Update feeback requests to provide more info ... Issue #1587 Bodacious committed on 12 Jul 2018
2018-07-02	Unverified c627043 Browse files » Merge branch 'development' into master Brian Riley authored on 2 Jul 2018 GitHub committed on 2 Jul 2018
2018-07-02	Unverified 2259747 Browse files » Merge pull request #1638 from CDLUC3/issue1448 ... Add <fieldset> markup to radio buttons and check boxes #1448 Brian Riley authored on 2 Jul 2018 GitHub committed on 2 Jul 2018
2018-06-25	3e88ccb Browse files » Add <fieldset> markup to radio buttons and check boxes #1448 ... remove the 'for' attribute for any check boxes or radio buttons that are embedded within the <label> tag bhavi committed on 25 Jun 2018
2018-06-25	13fb457 Browse files » Add Screen reader text for sort columns, adding scope to <th> tags bhavi committed on 25 Jun 2018
2018-06-22	f80731d Browse files » reverted changes to buttons <button><a ...></a></button> is invalid HTML5 and does not work in all browsers (#1636) Brian Riley authored on 22 Jun 2018 Sam Rust committed on 22 Jun 2018
2018-06-19	2844f80 Browse files » Issue1454 - Styling fixes for the fieldset on Edit Plans page (#1620) ... * Edit project details accessibility changes #1454 * Styling Fieldset on Edit Project details page #1454 Bhavi authored on 19 Jun 2018 Sam Rust committed on 19 Jun 2018
2018-06-14	7c326e5 Browse files » Fix buttons that do not provide a visual cue indicating that they have focus #1443 (#1600) Bhavi authored on 14 Jun 2018 Sam Rust committed on 14 Jun 2018
2018-06-13	f525dac Browse files » Add form validations (#1588) ... removed formtastic added required asterisks to create plan page and updated JS logic of Org selection added namespaces to edit profile, sign in and create account forms to fix duplicate id issue fixed JS behind links and their validation fixed JS behind links and their validation removed console.log statement and added rake tasks for data validation cleanup Add form validations removed formtastic added required asterisks to create plan page and updated JS logic of Org selection added namespaces to edit profile, sign in and create account forms to fix duplicate id issue fixed JS behind links and their validation fixed JS behind links and their validation removed console.log statement and added rake tasks for data validation cleanup made recommended adjustments reverted schema.rb removed unecessary other_org query Brian Riley authored on 13 Jun 2018 Sam Rust committed on 13 Jun 2018
2018-06-13	84ca8f6 Browse files » Add missing gettext markup to titles and skip main content link issues #1441 and #1442" (#1601) Bhavi authored on 13 Jun 2018 Sam Rust committed on 13 Jun 2018
2018-06-12	efcda25 Browse files » Edit project details accessibility changes #1454 (#1590) Bhavi authored on 12 Jun 2018 Sam Rust committed on 12 Jun 2018
2018-06-11	ee81474 Browse files » added gettext markup to 'See full list' link briley committed on 11 Jun 2018
2018-06-08	Unverified c2d6938 Browse files » Merge pull request #1579 from CDLUC3/accessibility ... Accessibility Issues - Page titles should be unique and descriptive #1441 Sam Rust authored on 8 Jun 2018 GitHub committed on 8 Jun 2018
2018-06-06	aa5e93e Browse files » Page titles should be unique and descriptive #1441 bhavi committed on 6 Jun 2018
2018-06-06	54ae4f1 Browse files » Accessibility - Form fields missing labels #1445 bhavi committed on 6 Jun 2018
2018-05-31	4a2f1dc Browse files » Revised text for plan#new. DMPRoadmap/roadmap#1479 Jose Lloret committed on 31 May 2018
2018-05-30	9a7e579 Browse files » Fixes : questions size is now a variable, replaced inject by reduce FAURE Benjamin committed on 30 May 2018
2018-05-28	61d44f1 Browse files » Fixed #1548 FAURE Benjamin committed on 28 May 2018
2018-05-23	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
2018-04-19	Unverified 870fab0 Browse files » correct sort order for my dashboard - fixes #1395 ... Changed sort_direction argument from symbol to string Jimmy Angelakos authored on 19 Apr 2018 GitHub committed on 19 Apr 2018
2018-03-27	2d70e2c Browse files » updated logic for download/share briley committed on 27 Mar 2018
2018-03-27	5a130a6 Browse files » added an excludeAsterisks option to AriatiseForm and validation JS files. Also updated 2 gettext strings to allow for embedded HTML briley committed on 27 Mar 2018
2018-03-22	Unverified 899882c Browse files » Merge pull request #1306 from CDLUC3/issue1197 ... Add asterisk to required fields Jose Lloret authored on 22 Mar 2018 GitHub committed on 22 Mar 2018
2018-03-21	ebddfdf Browse files » made reviewers unable to download plans Brian Riley committed on 21 Mar 2018
2018-03-21	ea4bd9f Browse files » consolidated question edit/new js so that ariatise and tinymce are only invoked once ... updated timing of validation checks on ariatiseForm because they were firing before Tinymce was transfering its contents to the textarea added asterisk to JS that handles form validations removed ariatise from js that did not have any fields defined yet applied requested changes Brian Riley committed on 21 Mar 2018
2018-03-15	7976e15 Browse files » added check for user's role on a plan to determine if download tab is available briley committed on 15 Mar 2018