opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / app / controllers / plans_controller.rb

2018-05-24	Unverified 9125f51 Browse files » Merge branch 'dmpopidor_branding' into master Benjamin FAURE authored on 24 May 2018 GitHub committed on 24 May 2018
2018-05-23	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
2018-05-15	318326f Browse files » Added the name of the person sharing a DMP in the title and the body of the notification FAURE Benjamin committed on 15 May 2018
2018-03-22	7917bb4 Browse files » updated plans controller to send user to overview after saving details ... fixed tests Brian Riley committed on 22 Mar 2018
2018-03-08	28d2da2 Browse files » switched to use google fonts ... fixed issue with margins removed old id updated h1 updated h1s briley committed on 8 Mar 2018
2018-03-02	d3ba6c7 Browse files » centered plan title ... fixed issue with pdf fomratting fixed issue with pdf fomratting Brian Riley committed on 2 Mar 2018
2018-02-28	8caa171 Browse files » fixed issue with double plan in docx briley committed on 28 Feb 2018
2018-02-23	89f2509 Browse files » removed side effects when generating or removing API token. Removed org_id method from User and use after_update callback instead. #1060 Jose Lloret committed on 23 Feb 2018
2018-02-21	20c647d Browse files » updated JS to fix guidance selection synchronization. updated controller to just replace guidance list briley committed on 21 Feb 2018
2018-02-20	f2ff19e Browse files » page ALL is retained if latest request contains it. Sort links are now right aligned within the th. #1105 ... default sorting to paginable concern specified through query_params keyword. #1105 paginable plans including default sorting paginable orgs including default sorting. #1105 Jose Lloret committed on 20 Feb 2018
2018-02-15	c01ba32 Browse files » fixes for downloads ... updated security check briley committed on 15 Feb 2018
2018-02-14	Unverified 1bf13b3 Browse files » Merge pull request #1153 from CDLUC3/issue1102 ... updated create plan to allow orgs and institutions in research org list Jose Lloret authored on 14 Feb 2018 GitHub committed on 14 Feb 2018
2018-02-13	e275d1f Browse files » updated create plan to allow orgs and institutions in research org list briley committed on 13 Feb 2018
	c6a63c2 Browse files » fix csv, txt exports briley committed on 13 Feb 2018
	Unverified 0ee252d Browse files » Merge pull request #1143 from CDLUC3/issue1127 ... consolidated plan exports Jose Lloret authored on 13 Feb 2018 GitHub committed on 13 Feb 2018
2018-02-09	db7079a Browse files » consolidated plan exports Brian Riley committed on 9 Feb 2018
2018-02-09	dec1936 Browse files » fixed issue with panel placement ... fixed issues with guidance selection removed unused function removed tests for functions that no longer exist briley authored on 8 Feb 2018 Brian Riley committed on 9 Feb 2018
2018-02-05	0bec3f9 Browse files » updated date format briley committed on 5 Feb 2018
2018-01-23	8b8f428 Browse files » guidance section in plan edit page(#943) ... add functional test for the select guidance list modal bhavi committed on 23 Jan 2018
2018-01-16	73d806f Browse files » shared search view passing controller and action. DMPRoadmap/roadmap#1027 ... new methods for paginable in order to abstract the sorting mechanism. DMPRoadmap/roadmap#1027 paginable concern refining scope query and helpers for sorting. DMPRoadmap/roadmap#1027 refactored paginable controllers and views after updating paginable concern. DMPRoadmap/roadmap#1027 Added comments to paginable concern methods. DMPRoadmap/roadmap#1027 Jose Lloret committed on 16 Jan 2018
2018-01-11	b37ffba Browse files » user and theme using generic search from paginable. DMPRoadmap/roadmap#815 ... search event handlers for paginate.js. DMPRoadmap/roadmap#815 plan using generic search for paginable. DMPRoadmap/roadmap#815 from glyphicon to font-awesome for search icon. DMPRoadmap/roadmap#815 Jose Lloret committed on 11 Jan 2018
2017-12-08	00d7e73 Browse files » Make templates page usable for Org Admins and Super Admins ... started work on super admin templates page consolidated org_admin and super_admin templates page moved template logic to org_admin module and consolidated logic for super/org admins switched from submit button click to form submit fixed issue with unused js var fixed broken templates controller tests switched back to submit button updated template_options route in integration test fixed broken integration tests caused by moving templates to org_admin namespace added tests for copy template added button to get back to 'all templates' page from template edit page renamed delete button from 'Cancel' to 'Delete' and added proper cancel button to edit section view made recommended adjustments and accounted for new template visibility functionality switched out scopes in favor of flagshihtzu helpers moved link to Themes to Admin menu fixed broken tests for the public_pages controller fixes for tests refactored template current version queries pulled in customization view changes briley authored on 27 Nov 2017 Brian Riley committed on 8 Dec 2017
2017-12-06	69dbf13 Browse files » plan overview controller action and view associated. DMPRoadmap/roadmap#546 ... functional test for overview action. DMPRoadmap/roadmap#546 Jose Lloret committed on 6 Dec 2017
2017-11-22	971ec8b Browse files » Org Admin provide feedback ... Add Plans page to Org Admin section added org admin plans page finsihed up org admin plans page added feedback complete and updated emails to use email_signature partial refactored access checks on Plan now that user can have multiple roles (reviewer + ?) finished feedback completion routine added tests for new feedback methods fixes for merge conflicts fixed issues with plan and user changes fixed issue with notes controller test fixed issue with phase controller test briley authored on 16 Nov 2017 Brian Riley committed on 22 Nov 2017
2017-11-22	e2926d2 Browse files » conditional_user_mailer concern for delivering email according to preferences. DMPRoadmap/roadmap#811 ... unit test for the concern. DMPRoadmap/roadmap#811 deliver_if recipients keyword accepts User or Array of Users. DMPRoadmap/roadmap#811 conditional email for users.new_comment, owners_and_coowners.visibility_changed. DMPRoadmap/roadmap#811 conditional email for users.added_as_coowner. DMPRoadmap/roadmap#811 conditional email for admins.feedback_requested. DMPRoadmap/roadmap#811 Jose Lloret committed on 22 Nov 2017
2017-11-21	6accf9e Browse files » paginable module to accomodate any model that needs paginated views. DMPRoadmap/roadmap#786 ... Pagination for plan model. DMPRoadmap/roadmap#786 Pagination for user model. DMPRoadmap/roadmap#786 Jose Lloret committed on 21 Nov 2017
2017-11-16	fa6ec53 Browse files » Fix conflicts with merging dev into CDL xsrust committed on 16 Nov 2017
2017-11-13	745f187 Browse files » Added Request Feedback button to the share plan page ... modifications to tooltips and email defaults moved email constants to usermailer aded missing colon started adding in the button to request feedback modifications to tooltips and email defaults started adding in the button to request feedback finsihed adding request feedback button Removed old comment switched to roles updated to role based reviewer updated user_mailer moved feedback confirmation defaults to methods on UserMailer added default visibility back to schema.rb made adjustments based on PR feedback refactored to use flagshihtzu function that returns values for flags briley committed on 13 Nov 2017
2017-11-10	9480290 Browse files » fixed issues with plan create page ... moved template_+options method to templates controller Brian Riley committed on 10 Nov 2017
2017-11-07	053b285 Browse files » Visibility view completed. DMPRoadmap/roadmap#732 ... visibility communicating with the right controller action. DMPRoadmap/roadmap#732 visibility_allowed method for Plan. Adequate error handling for visibility action. DMPRoadmap/roadmap#732 UserMailer for when the visibility is successfully saved. DMPRoadmap/roadmap#732 Jose Lloret committed on 7 Nov 2017