opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / spec / models

2019-03-29	20c4fdd Browse files » The "No. plans by template" statistics and visualisation changes: ... (1) The headers for the CSV for the Number of Plans by Template - the date column have dates in the format 'Jan 2018' - the template headers now display the Title of the templates - the Date and Count headers are capitalized. (2) The chart has been re-styled. The aspect ratio (width/height) of image is now dynamically set according to the selection of the month range. (3) Fixed broken rspec tests and rubocop errors/warnings. Fix for #1679. John Pinto committed on 29 Mar 2019
2018-12-10	0540917 Browse files » updated organisational plans query to only include completed plans to match logic of plan export (#2004) ... refactored plan.visibility_allowed? to call underlying method on phases refactored plan.visibility_allowed? to call underlying method on phases fixed tests Brian Riley authored on 10 Dec 2018 Sam Rust committed on 10 Dec 2018
2018-12-06	8b6acb7 Browse files » Further changes for Text field should be mandatory for option based questions. ... Fix for issue #1725 The question_options field on the Customisable Phase template has the following changes: - the 'Text' label has the asterick for required. - the error message for missing question option now reads "You must have at least one option with accompanying text." - Corrected some Rubocop errors on the files added. John Pinto committed on 6 Dec 2018
2018-11-30	ad393ed Browse files » finished up changes to controllers briri committed on 30 Nov 2018
2018-11-30	6a20aa4 Browse files » Merge branch 'development' into issue1663 briri committed on 30 Nov 2018
2018-11-29	a5dc80b Browse files » updated Role, Plan logic and fixed tests briri committed on 29 Nov 2018
2018-11-28	82a4ec8 Browse files » refactor plan/role functionality to use flagshihtzu properly briri committed on 28 Nov 2018
2018-11-27	d4ab563 Browse files » updated deactivate logic briri committed on 27 Nov 2018
	0ad0cd8 Browse files » Updated JS for requiredField to allow for dynamically loaded DOM elements (#1996) ... * IssueID #1725 - Updated messages Question text and option presence messages. * updated requiredField.js to allow for dynamically loaded DOM elements * fixed broken tests Brian Riley authored on 27 Nov 2018 Sam Rust committed on 27 Nov 2018
	6741fb4 Browse files » moved deactivate logic to Role model and added specs briri committed on 27 Nov 2018
2018-11-18	24c399d Browse files » 1. stat_created_plan.to_csv with option for details by template. ... 2. details attribute for stats table #1679 3. create_created_plan_service extended with details by template 4. create_last_month_created_plan_service extended with details by template. 5. create_or_update strategy for generating stats 6. StatCreatedPlanByTemplateController#index for graphs usage 7. month_start_date and month_end_date for OrgDateRangeable class [RD-1679] Usage view including date input for plans by template [#1679] monthly_range query updated [#1679] client-side chart for plans by template [#1679] Time picker for plans by template chart [#1679] Download plans by template action. deleted spec merge conflicts fixed [#1679] Removed JS linter warnings [#1679] Rubocop conforming code. Drying out stat services Jose Lloret committed on 18 Nov 2018
2018-11-09	54463e7 Browse files » Fix for ensuring that Questions that are option based must have atleast one non-blank text entry. ... - Validation added for option based questions to ensure text field non-blank. - Validation message OPTION_PRESENCE_MESSAGE added to app/models/concerns/validation_messages.rb. - Added ':allow_nil => true' to delegate :option_based?, to: :question_format, :allow_nil => true in Question model to prevent NoMethodError if question_format is nil. Fix for #1725 John Pinto committed on 9 Nov 2018
2018-10-19	db25309 Browse files » Fix broken functional tests ... Fix broken specs with random see 55679 Fix broken tests for random seed 19381 Temporarily disable travis security checks Since I'm testing the specs, this should help make it faster Fix bug caused by random Org locale Fixes recurring issue with tests being loaded in German Fix broken specs Fix tests breaking with seed 60029 Fix broken specs with seed 12116 Fix broken specs with seed 51011 Fix broken template upgrades specs Fix travis artifacts addons Add Travis asset debugging Remove Amazon S3 region from asset uploads config Move S3 configs to local travis file Re-add hygiene tasks to Travis YML Disable broken test for now Refactor tests for template upgrade customisations Bodacious authored on 12 Oct 2018 Sam Rust committed on 19 Oct 2018
2018-10-12	Unverified 302973e Browse files » Merge pull request #1929 from DMPRoadmap/issue-1853 ... Fix bug preventing new sections from merging into persisted phases Brian Riley authored on 12 Oct 2018 GitHub committed on 12 Oct 2018
	4c8fdef Browse files » updated guidance_spec syntax xsrust committed on 12 Oct 2018
	Unverified a920b20 Browse files » Fix bug when upgrading Template with new Sections ... Section presence validation was preventing Question from being saved. This was preventing new Sections from being saved. Bodacious committed on 12 Oct 2018
	f146b1d Browse files » updated guidance spec to allign with validation changes xsrust committed on 12 Oct 2018
2018-10-10	ed748e2 Browse files » Started Services and Actions for #1689 (#1871) ... StatCreatedPlan/StatJoinedUser Services and Action finished. #1689 removed comment. #1689 usage#all endpoint for all usage CSV reports. #1689 usage#all endpoint with request test associated. #1689 Removed require from files Moved generate actions into services [#1689] Renamed joined_user service related [#1689] Renamed stat_created_plan action to service [#1689] Removed action total_stat in favour of total_count_stat_service UsageDownloadController using Org::TotalCountStatService instead of the action Jose Lloret authored on 10 Oct 2018 Gavin Morrice committed on 10 Oct 2018
2018-09-20	9d3df90 Browse files » Fix broken tests caused by locale configuration (#1875) ... * Fix broken tests caused by locale configuration - Add LocaleSet - Add LocaleFormatter to force proper string formats - Rename I18n formats to use hyphen - Add rake task for updating existing languages on DB - Fix instances of US english in the templates * Fix FastGettext initializer loader * Add Amazon S3 creds for Travis * Revert "Add Amazon S3 creds for Travis" This reverts commit `366c1a7`. * Fix Faker localization for rake tasks Was breaking rake db:seed file Gavin Morrice authored on 20 Sep 2018 Sam Rust committed on 20 Sep 2018
2018-09-13	Unverified b4727e5 Browse files » Repair broken or pending specs (#1874) ... - Fix pending Template model specs - Fix pending model specs - Fix broken/pending specs, including random "errors" bug Gavin Morrice authored on 13 Sep 2018 GitHub committed on 13 Sep 2018
	1a697b0 Browse files » added validation tests (#1868) ... added validation tests added fr for I18n failing tests Brian Riley authored on 13 Sep 2018 Gavin Morrice committed on 13 Sep 2018
	1beea8c Browse files » Fixed issues with data_cleanup and section_sorter (#1859) ... * updated mysql query to update phase/section/question numbering, moved versionable_id rake task, fixed issue with section_sorter fixed test * Moved private methods from migrate to upgrade rake Brian Riley authored on 13 Sep 2018 Gavin Morrice committed on 13 Sep 2018
2018-09-05	Unverified 2f8ed6c Browse files » Refactor how Template upgrade customization works (#1856) ... * Refactor how Template upgrade customization works - Added position_in_parent to child-records Phase, Section, and Questions - Extracted upgrade_customization! into its own service object wip: rebasing on development wip: pushing to Ghub wip: Template upgrade customisation service working Add migration to update versionable_id for records * Fix bug in org swaps test Test was failing because JS wasn't executing fast enough in test browser * Refactor how locales are set in specs * Fix bug in plan exports caused by git merge The routes weren't merged properly which seems to have caused a regression error * Add documentation for SectionSorter * Update rubyzip and re-instate Bundle Audit This was disabled because it was failing the Travis CI script. Since there wasn't a new version of the rubyzip gem to upgrade to, we couldn't turn the error off. * Add length constraints to versionable_id * Add length constraints to versionable_id * Fix bug in ActsAsSortable module ... I have no idea why those issues haven't popped up before now!? * Fix random bug in I18n * Move versioning ID migration into own rake task Gavin Morrice authored on 5 Sep 2018 GitHub committed on 5 Sep 2018
2018-09-02	6971a12 Browse files » rebased onto development ... stat_created_plan_spec finished stats table using bigint. StatJoinedUser spec done csvable_spec done org_date_rangeable_spec done Actions::StatCreatedPlan::Generate spec half way done Actions::StatCreatedPlan::Generate rspec done Actions::StatJoinedUser::Generate spec finished Role.with_access_flags instead of access_values_for method Jose Lloret authored on 22 Jul 2018 Jose Lloret committed on 2 Sep 2018
2018-08-28	3039ef5 Browse files » Refactor how section ordering is handled (#1837) ... * Extract template customizations into own controller * Refactor Template model methods * Fix view logic in draggable sections * Add button for customising phase * Fix rubocop violations in GuidanceService * Rename GuidanceService to GuidancePresenter * Fix bug in phase preview order sections * Refactor preview action/controller code * Fix Section ordering in various views * Fix rubocop violations * Fix bug forcing Phases to be modifiable * Fix broken tests * Update method to check if section is draggable * Extract copy action into its own resource * Extract customization transfers to own controller * Remove redundant routing condition * Fix Rubocop violation issues * Change condition for section draggable * Refactor instance variable in PlansController * Fix broken tests * Add test support for 'de' locale * Fix merge issue in plans controller * Fix broken specs in plan#request_feedback Gavin Morrice authored on 28 Aug 2018 Sam Rust committed on 28 Aug 2018
2018-08-22	3b9264e Browse files » Added new Rspect tests to org_spec.rb. (#1830) John Pinto authored on 22 Aug 2018 Sam Rust committed on 22 Aug 2018
2018-08-22	Unverified fb69a3c Browse files » Configurable plan access (#1828) ... * added configuration options to branding.yml for plan access, updated links to be dependant on access * updated spec to expect multiple calls to branding Sam Rust authored on 22 Aug 2018 GitHub committed on 22 Aug 2018
2018-08-16	Unverified e13ff65 Browse files » Reset other_organisation when User org changes ... - Refactored how user model defines callbacks - Add specs Bodacious committed on 16 Aug 2018
2018-08-08	Unverified f3456fc Browse files » Remove specs referencing `sections.published` Bodacious committed on 8 Aug 2018
2018-08-02	Unverified f9c0185 Browse files » Replace deprecated methods with their new alaises Bodacious committed on 2 Aug 2018