opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / app / policies / plan_policy.rb

2021-07-05	a14cd48 Browse files » Added Project Selector (new registry) in Project Details Benjamin FAURE committed on 5 Jul 2021
2020-06-26	4dbc769 Browse files » Remade research outputs sorting Benjamin FAURE committed on 26 Jun 2020
2020-06-22	cbdec80 Browse files » Research outputs are now created remotely & research output fragment is now edital through modal Benjamin FAURE committed on 22 Jun 2020
2020-06-16	fb71b38 Browse files » Some code cleaning Benjamin FAURE committed on 16 Jun 2020
2020-04-27	e0db6e9 Browse files » First version of the Partners creation & edit form Benjamin FAURE committed on 27 Apr 2020
2019-11-08	3dc1e1a Browse files » Replaced include by prepend for DMPOPIDoR modules FAURE Benjamin committed on 8 Nov 2019
2019-10-01	71b44f8 Browse files » Merged DMPRoadmap V2.1.3 FAURE Benjamin committed on 1 Oct 2019
2019-06-14	bf33893 Browse files » Moved datasets form to its own tab FAURE Benjamin committed on 14 Jun 2019
2019-05-03	d571dc4 Browse files » Allow org admins to view 'share plan' page. ... Changes: - Updated share? method in the class PlanPolicy. - Also fixed Rubocop warnings in PlanPolicy. - Updated _navigation.html.erb and _share_form.html.erb to enable org admins to view the Share tab of org plans. Fix for #2090. John Pinto committed on 3 May 2019
2018-08-17	Unverified 14d1c2a Browse files » Refactor routes for better maintainability ... - Remove redundant routes (Fixes #1699, Fixes#1570) - Remove redundant actions - Remove redundant policy methods - Fix invalid actions (public methods defined on controllers) - Set concern methods as private - Extract session locale method from ApplicationController into its own controller - Explicitly define actions in statics controller for better readability Bodacious committed on 17 Aug 2018
2018-05-23	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
2018-03-15	7976e15 Browse files » added check for user's role on a plan to determine if download tab is available briley committed on 15 Mar 2018
2018-01-23	8b8f428 Browse files » guidance section in plan edit page(#943) ... add functional test for the select guidance list modal bhavi committed on 23 Jan 2018
2018-01-06	a2c1e62 Browse files » added csv download for org_admin plans page ... added tests removed comments switch @org creation in test debug in test updated pundit handling manually assign org admin perms manually assign org admin perms manually assign org admin perms removed policy to controller manually create role in test commented out travis failure briley authored on 4 Jan 2018 Brian Riley committed on 6 Jan 2018
2017-12-08	19d208a Browse files » updated Admin - Plans so that user can click through to a read-only version of the plan ... tweaked note policies fixed 2 plan policies fixed tests briley authored on 6 Dec 2017 Brian Riley committed on 8 Dec 2017
2017-12-06	69dbf13 Browse files » plan overview controller action and view associated. DMPRoadmap/roadmap#546 ... functional test for overview action. DMPRoadmap/roadmap#546 Jose Lloret committed on 6 Dec 2017
2017-11-22	971ec8b Browse files » Org Admin provide feedback ... Add Plans page to Org Admin section added org admin plans page finsihed up org admin plans page added feedback complete and updated emails to use email_signature partial refactored access checks on Plan now that user can have multiple roles (reviewer + ?) finished feedback completion routine added tests for new feedback methods fixes for merge conflicts fixed issues with plan and user changes fixed issue with notes controller test fixed issue with phase controller test briley authored on 16 Nov 2017 Brian Riley committed on 22 Nov 2017
2017-11-22	11f9295 Browse files » commentor is able to see plan details and write page. Commentor cannot access to share functionality. DMPRoadmap/roadmap#837 Jose Lloret committed on 22 Nov 2017
2017-11-13	745f187 Browse files » Added Request Feedback button to the share plan page ... modifications to tooltips and email defaults moved email constants to usermailer aded missing colon started adding in the button to request feedback modifications to tooltips and email defaults started adding in the button to request feedback finsihed adding request feedback button Removed old comment switched to roles updated to role based reviewer updated user_mailer moved feedback confirmation defaults to methods on UserMailer added default visibility back to schema.rb made adjustments based on PR feedback refactored to use flagshihtzu function that returns values for flags briley committed on 13 Nov 2017
2017-11-10	9480290 Browse files » fixed issues with plan create page ... moved template_+options method to templates controller Brian Riley committed on 10 Nov 2017
2017-09-08	1145391 Browse files » Bootstrapping and ES6 of the Plan Download page DMPRoadmap/roadmap#561. ... - Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route) - Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes) - Bootstrapped page html changed name of show_export to download to match UI terminology. Bootstrapped download page Added ES6 JS for download page and made tweaks to the format Brian Riley committed on 8 Sep 2017
2017-07-27	4f53490 Browse files » fixed broken tests and added functional tests for public_pages_controller briley committed on 27 Jul 2017
2017-07-27	dbcc008 Browse files » merge with cdl-mvp xsrust committed on 27 Jul 2017
2017-07-26	6cc9b7b Browse files » fixup plan and template policies xsrust committed on 26 Jul 2017
2017-07-24	9f0f0b4 Browse files » patch for public export auth xsrust committed on 24 Jul 2017
2017-07-24	91b0583 Browse files » patch for public export auth xsrust committed on 24 Jul 2017
2017-07-20	6d7fe05 Browse files » updated policy code to work(replaced where with find_by) xsrust committed on 20 Jul 2017
2017-07-20	472d63f Browse files » added ability for users to remove themselves from plans, without destroying the plan xsrust committed on 20 Jul 2017
2017-07-14	ec1d80b Browse files » made suggested changes from PR Brian Riley committed on 14 Jul 2017
2017-07-13	b5007bc Browse files » finished plan share and edit pages. Updated styling and handling or alert/notice messages. Updated css to allow background color, alert message and notice message colors to be set in dmproadmap.scss briley committed on 13 Jul 2017