opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / lib

2018-06-22	Unverified ddf92d2 Browse files » Merge branch 'dmpopidor_branding' into master Benjamin FAURE authored on 22 Jun 2018 GitHub committed on 22 Jun 2018
2018-06-21	558f34f Browse files » fix issue with duplicate asterisks on checkboxes (#1627) Brian Riley authored on 21 Jun 2018 Sam Rust committed on 21 Jun 2018
2018-06-19	f0785a5 Browse files » Fixed issues with Public Template page sorting and form validations (#1621) ... * fixed final issue with public template sort * switched from aria-describedby to validation-help-block * fixed remaining issues Brian Riley authored on 19 Jun 2018 Sam Rust committed on 19 Jun 2018
	2844f80 Browse files » Issue1454 - Styling fixes for the fieldset on Edit Plans page (#1620) ... * Edit project details accessibility changes #1454 * Styling Fieldset on Edit Project details page #1454 Bhavi authored on 19 Jun 2018 Sam Rust committed on 19 Jun 2018
	1138e36 Browse files » fixed issue with selectors on shibboleth_ds (#1623) Brian Riley authored on 19 Jun 2018 Sam Rust committed on 19 Jun 2018
2018-06-18	74c37ac Browse files » fixed issue with Tinymce toolbar (#1611) ... removed trailing spaces switched selector for notifications tinymce reverted back to passing tollbar Brian Riley authored on 18 Jun 2018 Sam Rust committed on 18 Jun 2018
2018-06-18	fd47409 Browse files » switched guidance themes from checkboxes to radio buttons (#1608) ... ported radio button logic to validation.js updated shared tehemes partial to allow 'required' and 'asRadio' arguments. Also fixed bug with removing all theme selections on question form and added 'no themes selected' message fixed typo and renamed asRadio to as_radio Brian Riley authored on 18 Jun 2018 Sam Rust committed on 18 Jun 2018
2018-06-14	2aeb337 Browse files » Improvements to News section FAURE Benjamin committed on 14 Jun 2018
2018-06-14	7c326e5 Browse files » Fix buttons that do not provide a visual cue indicating that they have focus #1443 (#1600) Bhavi authored on 14 Jun 2018 Sam Rust committed on 14 Jun 2018
2018-06-13	339e4c0 Browse files » only email helpdesk on plan review, update preferences in branding_example, add rake task to remove depricated DB preferences xsrust committed on 13 Jun 2018
	Unverified 23f53b7 Browse files » Only email admin helpdesk when plan review requested (not all admins) #1217 (#1597) ... * added gettext markup to 'See full list' link * only email helpdesk on plan review, update preferences in branding_example, add rake task to remove depricated DB preferences * added missing end to upgrade.rake * removed admin options from notification preferences page * Edit project details accessibility changes #1454 (#1590) * Add missing gettext markup to titles and skip main content link issues #1441 and #1442" (#1601) * Add form validations (#1588) removed formtastic added required asterisks to create plan page and updated JS logic of Org selection added namespaces to edit profile, sign in and create account forms to fix duplicate id issue fixed JS behind links and their validation fixed JS behind links and their validation removed console.log statement and added rake tasks for data validation cleanup Add form validations removed formtastic added required asterisks to create plan page and updated JS logic of Org selection added namespaces to edit profile, sign in and create account forms to fix duplicate id issue fixed JS behind links and their validation fixed JS behind links and their validation removed console.log statement and added rake tasks for data validation cleanup made recommended adjustments reverted schema.rb removed unecessary other_org query * only email helpdesk on plan review, update preferences in branding_example, add rake task to remove depricated DB preferences * added missing end to upgrade.rake * removed admin options from notification preferences page * added prefs task to meta-release task * lost an end to the merges Sam Rust authored on 13 Jun 2018 GitHub committed on 13 Jun 2018
	f525dac Browse files » Add form validations (#1588) ... removed formtastic added required asterisks to create plan page and updated JS logic of Org selection added namespaces to edit profile, sign in and create account forms to fix duplicate id issue fixed JS behind links and their validation fixed JS behind links and their validation removed console.log statement and added rake tasks for data validation cleanup Add form validations removed formtastic added required asterisks to create plan page and updated JS logic of Org selection added namespaces to edit profile, sign in and create account forms to fix duplicate id issue fixed JS behind links and their validation fixed JS behind links and their validation removed console.log statement and added rake tasks for data validation cleanup made recommended adjustments reverted schema.rb removed unecessary other_org query Brian Riley authored on 13 Jun 2018 Sam Rust committed on 13 Jun 2018
2018-06-12	88cbf12 Browse files » Improvements to Plan Creation Page & New Homepage FAURE Benjamin committed on 12 Jun 2018
2018-06-11	Unverified 275d7de Browse files » Merge pull request #1592 from CDLUC3/issue1442 ... Each page should have a 'Skip to Content' link for screen readers #1442 Brian Riley authored on 11 Jun 2018 GitHub committed on 11 Jun 2018
	dc48c98 Browse files » Added `rake translatable:find` ... ran gettext:find and fixed up en_US translations added translatable:find task and fixed up a few files added exception to po/pot backup files in gitignore began fixing up pt_BR added pt_BR translations fixed issue with multiline translatable text on help page. reran translatable:find and fixed up app.pot, pt_BR, en_US and en_GB fixed test fixed another test updated author comments added devise and bootstrap translations for pt_BR Brian Riley authored on 25 May 2018 briley committed on 11 Jun 2018
	688d2a5 Browse files » Each page should have a 'Skip to Content' link for screen readers #1442 bhavi committed on 11 Jun 2018
2018-05-30	cebcd2d Browse files » CSS changes to guidance choice FAURE Benjamin committed on 30 May 2018
	ebe2f5f Browse files » CSS fix on h2 tags FAURE Benjamin committed on 30 May 2018
	de5a861 Browse files » Changed favicon name FAURE Benjamin committed on 30 May 2018
2018-05-29	bfcc68a Browse files » CSS fix FAURE Benjamin committed on 29 May 2018
2018-05-25	dfdd5ee Browse files » Scrolling bar should appear when example answer is too large FAURE Benjamin committed on 25 May 2018
2018-05-24	Unverified 9125f51 Browse files » Merge branch 'dmpopidor_branding' into master Benjamin FAURE authored on 24 May 2018 GitHub committed on 24 May 2018
2018-05-23	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
	Unverified a638884 Browse files » Merge pull request #1491 from CDLUC3/contributions ... Final cleanup for Super Admin Notifications PR Brian Riley authored on 23 May 2018 GitHub committed on 23 May 2018
	50067f0 Browse files » Ruby Upgrade v2.4.4 ... ---------------------------------------- cleaning unused gems and upgrade to Ruby v2.4.1 fix node modules issues when running the upgrade update travis.yml to Ruby v2.4.1 Remove Friendly Id gem and related code references. Upgrading the Devise, Omniauth and Pundit gems and removing version numbers Upgrading views related gems like recaptcha, formtastic, dragonfly Upgrade development group gems like kaminari, byebug, better_errors, web-console, binding_of_caller, rack-mini-profiler Upgrade test group gems like racktest, webmock, sqlite, simplecov Upgrading Exporting and Internalization gems in the Gemfile Ruby upgrade to 2.4.4 Fix assert nil warnings in tests reremoved administrate gem fixed merge conflicts bhavi authored on 1 May 2018 briley committed on 23 May 2018
2018-05-18	b7aff79 Browse files » syntax fix in JS FAURE Benjamin committed on 18 May 2018
2018-05-18	4dd9774 Browse files » User Profile: checkbox in confirmation modal toggles Continue button FAURE Benjamin committed on 18 May 2018
2018-05-16	a30cf7b Browse files » Implemented Notifications ... updated tests to work with current test infrastructure forgot to add test file switched from url to path to correct 'Mixed content https vs http' issues Quentin Sonrel authored on 29 Mar 2018 briley committed on 16 May 2018
	16dc9a0 Browse files » CSS fixes on static pages FAURE Benjamin committed on 16 May 2018
	510fe55 Browse files » Fixed menu icon color on mobile FAURE Benjamin committed on 16 May 2018