diff --git a/app/views/contact_us/contacts/new.html.erb b/app/views/contact_us/contacts/new.html.erb index 05ceef9..985a32f 100644 --- a/app/views/contact_us/contacts/new.html.erb +++ b/app/views/contact_us/contacts/new.html.erb @@ -16,36 +16,31 @@
<% if ContactUs.require_name %>
- - /> + <%= f.label(:name, _('Name')+'*') %> + <%= f.text_field(:name, class: "left-indent required input-large", value: current_user.nil? ? '' : current_user.name(false), readonly: !current_user.nil?) %>
<% end %>
- - /> + <%= f.label(:email, _('Email')+'*') %> + <%= f.text_field(:email, class: "left-indent required input-large", value: current_user.nil? ? '' : current_user.email, readonly: !current_user.nil?) %>
<% if ContactUs.require_subject %>
- - + <%= f.label(:subject, _('Subject')+'*') %> + <%= f.text_field(:subject, class: "left-indent required input-large") %>
<% end %>
- - + <%= f.label(:message, _('Message')+'*', class: "align-top") %> + <%= f.text_area(:message, class: "left-indent required input-large", rows: 10) %>
- <% if !user_signed_in? then %>
- + <%= label_tag(nil, _('Security check')+'*', class: "align-top") %>
<%= recaptcha_tags %>
diff --git a/lib/assets/javascripts/dmproadmap/forms.js b/lib/assets/javascripts/dmproadmap/forms.js index 5434b52..4cfa730 100644 --- a/lib/assets/javascripts/dmproadmap/forms.js +++ b/lib/assets/javascripts/dmproadmap/forms.js @@ -49,7 +49,7 @@ // --------------------------------------------------------------------------- function validateEmail(sEmail) { - var filter = /^[a-zA-Z0-9]+[a-zA-Z0-9_.-]+[a-zA-Z0-9_-]+@[a-zA-Z0-9]+[a-zA-Z0-9.-]+.[a-z]{2,4}$/; + var filter = /[^@\s]+@(?:[-a-z0-9]+\.)+[a-z]{2,}$/; if(filter.test(sEmail)){ return ''; }else{ diff --git a/lib/assets/javascripts/views/contacts/new_contact.js b/lib/assets/javascripts/views/contacts/new_contact.js index 3127eb2..43f6d84 100644 --- a/lib/assets/javascripts/views/contacts/new_contact.js +++ b/lib/assets/javascripts/views/contacts/new_contact.js @@ -10,16 +10,16 @@ $("input[type='text'], input[type='email'], textarea").change(function(e){ var enable = ($("#contact_us_contact_name").val().trim().length > 0 && - validateEmail($("#contact_us_contact_email").val().trim()) != '' && + validateEmail($("#contact_us_contact_email").val().trim()) === '' && $("#contact_us_contact_subject").val().trim().length > 0 && $("#contact_us_contact_message").val().trim().length > 0); - // Check the recaptcha status - if($("#recaptcha-anchor")){ - if($("#recaptcha-anchor").prop('aria-checked') != 'true'){ - enable = false; - } - } + // Disabled recaptcha since always sets enable, TODO change when we tackle https://github.com/DMPRoadmap/roadmap/issues/501 + // if($("#recaptcha-anchor")){ + // if($("#recaptcha-anchor").prop('aria-checked') != 'true'){ + // enable = false; + // } + // } $("#create_contact_submit").attr('aria-disabled', !enable); }); }); \ No newline at end of file