diff --git a/app/controllers/plans_controller.rb b/app/controllers/plans_controller.rb index 41abae4..77c5256 100644 --- a/app/controllers/plans_controller.rb +++ b/app/controllers/plans_controller.rb @@ -115,6 +115,8 @@ @plan = Plan.eager_load(params[:id]) authorize @plan + @visibility = @plan.visibility.blank? ? @plan.visibility.to_s : Rails.application.config.default_plan_visibility + @editing = (!params[:editing].nil? && @plan.administerable_by?(current_user.id)) # Get all Guidance Groups applicable for the plan and group them by org @@ -153,6 +155,9 @@ def edit @plan = Plan.find(params[:id]) authorize @plan + + @visibility = @plan.visibility.blank? ? @plan.visibility.to_s : Rails.application.config.default_plan_visibility + # If there was no phase specified use the template's 1st phase @phase = (params[:phase].nil? ? @plan.template.phases.first : Phase.find(params[:phase])) @show_phase_tab = params[:phase] diff --git a/app/views/plans/_edit_details.html.erb b/app/views/plans/_edit_details.html.erb index 45adef7..d6c92f9 100644 --- a/app/views/plans/_edit_details.html.erb +++ b/app/views/plans/_edit_details.html.erb @@ -57,14 +57,15 @@
+
- +
(<%= _('Limited to finished plans') %>)

-
/><%= raw display_visibility('privately_visible') %>
-
/><%= raw display_visibility('organisationally_visible') %>
-
/><%= raw display_visibility('publicly_visible') %>
+
/><%= raw display_visibility('privately_visible') %>
+
/><%= raw display_visibility('organisationally_visible') %>
+
/><%= raw display_visibility('publicly_visible') %>
diff --git a/app/views/plans/public_index.html.erb b/app/views/plans/public_index.html.erb index 21f099b..5f0fdae 100644 --- a/app/views/plans/public_index.html.erb +++ b/app/views/plans/public_index.html.erb @@ -28,9 +28,9 @@ <% end %> - <%= _('Plan Title') %> + <%= _('Project Title') %> <%= _('Template') %> - <%= _('Organisation') %> + <%= _('Institution') %> <%= _('Owner') %> <%= _('Download') %> diff --git a/app/views/plans/show.html.erb b/app/views/plans/show.html.erb index 0926e61..af86338 100644 --- a/app/views/plans/show.html.erb +++ b/app/views/plans/show.html.erb @@ -26,11 +26,11 @@
- <% if @plan.editable_by?(current_user) %> - <%= render partial: 'edit_details', locals: {plan: @plan} %> - <% else %> - <%= render partial: 'show_details', locals: {plan: @plan} %> - <% end %> + <% if @plan.editable_by?(current_user) %> + <%= render partial: 'edit_details', locals: {plan: @plan, visibility: @visibility} %> + <% else %> + <%= render partial: 'show_details', locals: {plan: @plan, visibility: @visibility} %> + <% end %>
\ No newline at end of file diff --git a/lib/assets/javascripts/views/plans/edit.js b/lib/assets/javascripts/views/plans/edit.js index 41309bf..322f903 100644 --- a/lib/assets/javascripts/views/plans/edit.js +++ b/lib/assets/javascripts/views/plans/edit.js @@ -9,8 +9,8 @@ } }); - $("input[name='visibility']").on('change', function(e){ - $('#plan_visibility').val($("input[name='visibility']:checked").val()); + $("input[name='vis']").on('change', function(e){ + $('#plan_visibility').val($("input[name='vis']:checked").attr('id')); }); toggleVisibility(); @@ -18,7 +18,7 @@ function toggleVisibility(){ var test = $("#is_test").is(':checked'); // If the test checkbox is true then disable the visibility dropdown - $("input[name='visibility']").attr('aria-disabled', test).attr('disabled', test); + $("input[name='vis']").attr('aria-disabled', test).attr('disabled', test); } /*----------------