diff --git a/app/admin/user.rb b/app/admin/user.rb index 3e80251..464798b 100644 --- a/app/admin/user.rb +++ b/app/admin/user.rb @@ -12,8 +12,7 @@ filter :firstname filter :surname filter :email - filter :organisations - filter :other_organisation + filter :organisation filter :created_at filter :updated_at @@ -31,14 +30,10 @@ link_to user.surname, [:admin, user] end column I18n.t('admin.last_logged_in'), :last_sign_in_at - column I18n.t('admin.org_title'), :sortable => 'organisations.name' do |org_title| + + column I18n.t('admin.org_title'), :sortable => 'organisation.name' do |org_title| if !org_title.organisation.nil? then - if org_title.other_organisation.nil? || org_title.other_organisation == "" then - link_to org_title.organisation.name, [:admin, org_title.organisation] - else - I18n.t('helpers.org_type.org_name') + ' - ' + org_title.other_organisation - - end + link_to org_title.organisation.name, [:admin, org_title.organisation] end end @@ -89,9 +84,9 @@ f.input :orcid_id f.input :api_token # f.input :shibboleth_id - f.input :organisation_id ,:label => I18n.t('admin.org_title'), - :as => :select, - :collection => Organisation.order('name').map{|orgp|[orgp.name, orgp.id]} + f.input :organisation_id, :label => I18n.t('admin.org_title'), + :as => :select, + :collection => Organisation.order('name').map{|orgp|[orgp.name, orgp.id]} f.input :other_organisation # f.input :user_status_id, :label => I18n.t('admin.user_status'), # :as => :select, @@ -104,8 +99,6 @@ :multiple => true, :include_blank => I18n.t('helpers.none'), :collection => Role.order('name').map{|ro| [ro.name, ro.id]} - - f.input :api_token end f.actions @@ -114,9 +107,6 @@ controller do - def scoped_collection - resource_class.includes(:organisations) # prevents N+1 queries to your database - end def permitted_params params.permit! diff --git a/app/admin/user_org_role.rb b/app/admin/user_org_role.rb deleted file mode 100644 index e5d9793..0000000 --- a/app/admin/user_org_role.rb +++ /dev/null @@ -1,54 +0,0 @@ -# [+Project:+] DMPRoadmap -# [+Description:+] -# -# [+Created:+] 03/09/2014 -# [+Copyright:+] Digital Curation Centre and University of California Curation Center - -ActiveAdmin.register UserOrgRole do - permit_params :user_id, :organisation_id, :user_role_type_id - - menu false - #:priority => 5, :label => proc{I18n.t('admin.user_org_role')}, :parent => "User management" - - index do - column I18n.t('admin.user'), :sortable => :user_id do |user_n| - if !user_n.user.nil? then - link_to user_n.user.firstname, [:admin, user_n.user] - end - end - column I18n.t('admin.org'), :sortable => :organisation_id do |org| - if !org.organisation.nil? then - link_to org.organisation.name, [:admin, org.organisation] - end - end - column I18n.t('admin.user_role_type'), :sortable => :user_role_type_id do |role| - if !role.user_role_type.nil? then - link_to role.user_role_type.name, [:admin, role.user_role_type] - end - end - - actions - end - - show do - attributes_table do - row I18n.t('admin.user'), :user_id do |user_n| - link_to user_n.user.firstname, [:admin, user_n.user] - end - row I18n.t('admin.org'), :organisation_id do |org| - link_to org.organisation.name, [:admin, org.organisation] - end - row I18n.t('admin.user_role_type'), :user_role_type_id do |role| - link_to role.user_role_type.name, [:admin, role.user_role_type] - end - row :created_at - row :updated_at - end - end - - controller do - def permitted_params - params.permit! - end - end -end diff --git a/app/assets/javascripts/projects.js b/app/assets/javascripts/projects.js index 59ea647..879400a 100644 --- a/app/assets/javascripts/projects.js +++ b/app/assets/javascripts/projects.js @@ -46,7 +46,7 @@ // ---------------------------------------------------------- $("#project_funder_name").change(function(){ - $("#confirm-funder").text($(this).val()); + $("#confirm-funder").text($("#project_funder_id :selected").text()); }); // ---------------------------------------------------------- diff --git a/app/models/user.rb b/app/models/user.rb index 484f41b..cdda608 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -245,16 +245,18 @@ user.roles << grant_api_to_orgs unless user.roles.include? grant_api_to_orgs user.roles << grant_permissions unless user.roles.include? grant_permissions user.roles.delete(admin) - elsif user.roles.include? 'org_admin' + user.save! + end + if user.roles.include? org_admin #add org-admin roles user.roles << grant_permissions unless user.roles.include? grant_permissions user.roles << modify_templates unless user.roles.include? modify_templates user.roles << modify_guidance unless user.roles.include? modify_guidance user.roles << change_org_details unless user.roles.include? change_org_details user.roles.delete(org_admin) + # save the user + user.save! end - # save the user - user.save! end end end diff --git a/app/views/layouts/_dmponline_navigation.html.erb b/app/views/layouts/_dmponline_navigation.html.erb index b38673f..601034d 100644 --- a/app/views/layouts/_dmponline_navigation.html.erb +++ b/app/views/layouts/_dmponline_navigation.html.erb @@ -60,7 +60,7 @@ <% else %>