opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / app / controllers / guidances_controller.rb

2019-12-16	ec1818c Browse files » removed travis ... Briri GitHub tests (#2312) * Created Github workflow for tests Github workflow for Rubocop (#2315) * Create ruby.yml * updated to get ruby ver from gem file.lock Update rubocop.yml Update rubocop.yml pulling in our rubocop gem reverted rubocop file Pulled all of the separate gem's rubocop stuff into the repo's rubocop file Removed 'Rails' from rubocop.yml added brakeman workflow fixed bad rubocop disable lines restricted brakeman workflow to PR on master added ES lint workflow fixed typo added workflow for mysql tests chenged workflow names and updated mysql chenged workflow names and updated mysql chenged workflow names and updated mysql chenged workflow names and updated mysql chenged workflow names and updated mysql chenged workflow names and updated mysql added password for mysql tests and fixed spec removed blank line added rails_env environment var added RAILS_ENV to bundle commands removed rails_env from rspec line briri committed on 16 Dec 2019
2018-09-07	16e12b7 Browse files » Remove old JS form validations (#1867) ... * added new form validation error handling added tests for orgs controller converted over remaining controllers to new errors enhanced message handlers in application controller finished form validations * fixed rubocop for all controllers * Fix broken specs - Factories needed to be updated to meet new validation requirements - Spec was broken since error message had changed * Fix errors and warnings from npm audit Brian Riley authored on 7 Sep 2018 Gavin Morrice committed on 7 Sep 2018
2018-05-23	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
2018-02-21	55b0892 Browse files » fixed issue with clearing all theme selections ... switch variable name briley committed on 21 Feb 2018
2018-01-26	042a529 Browse files » Revise Publish action on Guidances page (#871) ... Getting the tests to pass unpublish the gudiance group if its guidances are unpublished update tooltip on Guidance Group name bhavi committed on 26 Jan 2018
2018-01-19	6beb771 Browse files » public DMPs paginablerised. DMPRoadmap/roadmap#1055 ... public DMPs templates paginablerised. DMPRoadmap/roadmap#1055 plans visible to org admin paginablerised. DMPRoadmap/roadmap#1055 guidances paginablerised. DMPRoadmap/roadmap#1055 guidance_groups paginablerised. DMPRoadmap/roadmap#1055 remove tablesorter class from paginable views. Introduce Clear search results when ALL search results are active. DMPRoadmap/roadmap#1055 guidance policy for paginable/guidance/index/:page. DMPRoadmap/roadmap#1055 Jose Lloret committed on 19 Jan 2018
2018-01-04	952ea95 Browse files » Revise Publish action on Guidances page (#871) ... Getting the tests to pass bhavi committed on 4 Jan 2018
2017-12-14	97f1a39 Browse files » redirect to guidances#admin_index for create, update, destroy, publish and unpublish. DMPRoadmap/roadmap#876 Jose Lloret committed on 14 Dec 2017
2017-12-11	c07a085 Browse files » refactored new and edit guidance views. DMPRoadmap/roadmap#906 Jose Lloret committed on 11 Dec 2017
2017-12-06	6841a60 Browse files » Add publish/unpublish to Guidances and Guidance Groups(#871) bhavi committed on 6 Dec 2017
2017-07-07	31cc3e6 Browse files » updated controllers to use alert instead of notice for errors DMPRoadmap/roadmap#175 Brian Riley committed on 7 Jul 2017
2017-07-07	f730850 Browse files » added generic success message and updated controllers to use it DMPRoadmap/roadmap#175 Brian Riley committed on 7 Jul 2017
2017-06-27	c213ca1 Browse files » switched guidance update to return to edit page instead of show briley committed on 27 Jun 2017
	d62b6ca Browse files » fixed merge conflicts briley committed on 27 Jun 2017
	050f1db Browse files » removed auto-publishing of groups by publishing guidance xsrust committed on 27 Jun 2017
	3e20270 Browse files » allows guidances to save attributes other than text xsrust committed on 27 Jun 2017
2017-06-23	05d9644 Browse files » added old admin.js back in to handle templates page. finsihed css rebuild of guidances and guidance groups Brian Riley committed on 23 Jun 2017
2017-04-11	291b973 Browse files » removed remaining references to guidance.question_id DMPRoadmap/roadmap#221 briley committed on 11 Apr 2017
2017-04-07	7357cc4 Browse files » broken generic error message handler apart into separate create/update/destroy versions. updated calls within the controllers and fixed tests DMPRoadmap/roadmap#227 Brian Riley committed on 7 Apr 2017
2017-04-07	706b7b6 Browse files » Added obj_name param to the generic error message handler on application_controller. Updated all save error handling to render the page rather than redirect DMPRoadmap/roadmap#227 Brian Riley committed on 7 Apr 2017
2017-04-06	32190ef Browse files » fixed typo in guidances controller briley committed on 6 Apr 2017
2017-04-05	d7f33b8 Browse files » fixed rebase issues briley committed on 5 Apr 2017
	543cc05 Browse files » rebuilt locale json files after adding timeago values. updated main <html> tag to include current locale for use with JS. DMPRoadmap/roadmap#204 briley committed on 5 Apr 2017
	369d1fb Browse files » removed template->question dropdowns on guidance pages. updated controller and JS accordingly. fixed issue with themes not being saved. DMPRoadmap/roadmap#221 briley committed on 5 Apr 2017
2017-04-03	d224081 Browse files » added error messaging to guidances controller's update and create methods briley committed on 3 Apr 2017
	ec989fa Browse files » resolved rebase conflicts from merge with development briley committed on 3 Apr 2017
	b07aa14 Browse files » cleaned up guidances controller and added functional tests briley committed on 3 Apr 2017
2017-03-24	abd1c94 Browse files » fixed other basic issues found on guidance pages DMPRoadmap/roadmap#185 briley committed on 24 Mar 2017
2017-03-24	043d59b Browse files » fixed typo in guidances controller. Fixes part of DMPRoadmap/roadmap#185 briley committed on 24 Mar 2017
2017-03-02	6a78027 Browse files » Replaced I18n.t(...) from controllers. DMPRoadmap/roadmap#98 Jose Lloret committed on 2 Mar 2017