opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / app / models

2018-09-07	16e12b7 Browse files » Remove old JS form validations (#1867) ... * added new form validation error handling added tests for orgs controller converted over remaining controllers to new errors enhanced message handlers in application controller finished form validations * fixed rubocop for all controllers * Fix broken specs - Factories needed to be updated to meet new validation requirements - Spec was broken since error message had changed * Fix errors and warnings from npm audit Brian Riley authored on 7 Sep 2018 Gavin Morrice committed on 7 Sep 2018
2018-09-05	Unverified 2f8ed6c Browse files » Refactor how Template upgrade customization works (#1856) ... * Refactor how Template upgrade customization works - Added position_in_parent to child-records Phase, Section, and Questions - Extracted upgrade_customization! into its own service object wip: rebasing on development wip: pushing to Ghub wip: Template upgrade customisation service working Add migration to update versionable_id for records * Fix bug in org swaps test Test was failing because JS wasn't executing fast enough in test browser * Refactor how locales are set in specs * Fix bug in plan exports caused by git merge The routes weren't merged properly which seems to have caused a regression error * Add documentation for SectionSorter * Update rubyzip and re-instate Bundle Audit This was disabled because it was failing the Travis CI script. Since there wasn't a new version of the rubyzip gem to upgrade to, we couldn't turn the error off. * Add length constraints to versionable_id * Add length constraints to versionable_id * Fix bug in ActsAsSortable module ... I have no idea why those issues haven't popped up before now!? * Fix random bug in I18n * Move versioning ID migration into own rake task Gavin Morrice authored on 5 Sep 2018 GitHub committed on 5 Sep 2018
2018-09-02	6971a12 Browse files » rebased onto development ... stat_created_plan_spec finished stats table using bigint. StatJoinedUser spec done csvable_spec done org_date_rangeable_spec done Actions::StatCreatedPlan::Generate spec half way done Actions::StatCreatedPlan::Generate rspec done Actions::StatJoinedUser::Generate spec finished Role.with_access_flags instead of access_values_for method Jose Lloret authored on 22 Jul 2018 Jose Lloret committed on 2 Sep 2018
2018-08-30	Unverified 3557fd3 Browse files » Merge branch 'development' into issue-1833 Gavin Morrice authored on 30 Aug 2018 GitHub committed on 30 Aug 2018
2018-08-30	Unverified 25dadc1 Browse files » Refactor Answer model Bodacious committed on 30 Aug 2018
2018-08-29	Unverified 912f6f5 Browse files » Add specs for PDF download link Bodacious committed on 29 Aug 2018
	Unverified 025ac29 Browse files » Fix bug preventing PDF downloads from dashboard Bodacious committed on 29 Aug 2018
	Unverified f8c31a9 Browse files » Fix Rubocop offenses Bodacious committed on 29 Aug 2018
	Unverified 3ca37a3 Browse files » Fix bug when creating first section in phase ... Would raise an error since no previous section number was available Bodacious committed on 29 Aug 2018
2018-08-28	Unverified e436eed Browse files » Fix bug preventing plans from downloading Bodacious committed on 28 Aug 2018
2018-08-28	3039ef5 Browse files » Refactor how section ordering is handled (#1837) ... * Extract template customizations into own controller * Refactor Template model methods * Fix view logic in draggable sections * Add button for customising phase * Fix rubocop violations in GuidanceService * Rename GuidanceService to GuidancePresenter * Fix bug in phase preview order sections * Refactor preview action/controller code * Fix Section ordering in various views * Fix rubocop violations * Fix bug forcing Phases to be modifiable * Fix broken tests * Update method to check if section is draggable * Extract copy action into its own resource * Extract customization transfers to own controller * Remove redundant routing condition * Fix Rubocop violation issues * Change condition for section draggable * Refactor instance variable in PlansController * Fix broken tests * Add test support for 'de' locale * Fix merge issue in plans controller * Fix broken specs in plan#request_feedback Gavin Morrice authored on 28 Aug 2018 Sam Rust committed on 28 Aug 2018
2018-08-27	Unverified 4e4b4db Browse files » Issue 1845 (#1846) ... * Fix bug preventing Feedback from being requested * Fix Rubocop violations * Extract feedback requests into own controller * Add test for feedback requests * Fix Rubocop violations Gavin Morrice authored on 27 Aug 2018 GitHub committed on 27 Aug 2018
2018-08-27	3b34a33 Browse files » Exported Plan bug and style fixes: ... - The csv export now shows the project coversheet text when the option is selected. - the text export now shows the questions when question text option selected. John Pinto committed on 27 Aug 2018
2018-08-22	Unverified fb69a3c Browse files » Configurable plan access (#1828) ... * added configuration options to branding.yml for plan access, updated links to be dependant on access * updated spec to expect multiple calls to branding Sam Rust authored on 22 Aug 2018 GitHub committed on 22 Aug 2018
2018-08-22	7dcb85e Browse files » Fix TinyMCE JS on forms loaded with DOM (#1827) ... * Fix TinyMCE JS on forms loaded with DOM Fixes #1777 * Fix broken specs * Fix Rubocop style violations Ignored LineLength violations when string is part of FastGettext * Updated rubocop style gem Gavin Morrice authored on 22 Aug 2018 Sam Rust committed on 22 Aug 2018
2018-08-21	7c71460 Browse files » Add tests for locale setting (#1823) ... * Add tests for locale setting - Adds Faker::Language module for testing languages with real-ish data - Refactors global constants into Language model (See Issue#1696) - Add specs to test locale change works * Clean up language files to remove long names * Add DB check in FastGettext initializer * Set Memory cache for temporary caching solution * Fix bug in Plan Rule Gavin Morrice authored on 21 Aug 2018 Sam Rust committed on 21 Aug 2018
2018-08-20	Unverified d73e7c6 Browse files » Merge pull request #1814 from DMPRoadmap/issue-1736 ... Reset other_organisation when User org changes Brian Riley authored on 20 Aug 2018 GitHub committed on 20 Aug 2018
2018-08-17	Unverified bca4a89 Browse files » Ensure annotations destroyed when text is blank ... When a user updates an existing annotation to set its text to blank, this should destroy that annotation record on the DB—since they can't be valid without text. Bodacious committed on 17 Aug 2018
2018-08-16	Unverified b5abe80 Browse files » Fix updating questions when annotation text is nil Bodacious committed on 16 Aug 2018
2018-08-16	Unverified e13ff65 Browse files » Reset other_organisation when User org changes ... - Refactored how user model defines callbacks - Add specs Bodacious committed on 16 Aug 2018
2018-08-15	Unverified a4729f7 Browse files » Fix duplicates in guidance group options ... Restructure the `has_many` association to use SQL's DISTINCT function Bodacious committed on 15 Aug 2018
2018-08-14	Unverified c36d9ac Browse files » Merge branch 'development' into feature/validations Brian Riley authored on 14 Aug 2018 GitHub committed on 14 Aug 2018
2018-08-14	Unverified d92cfa3 Browse files » Merge pull request #1802 from DMPRoadmap/refactor/database-cleanup ... Remove redundant database tables and columns Brian Riley authored on 14 Aug 2018 GitHub committed on 14 Aug 2018
2018-08-13	Unverified e98abf2 Browse files » Merge pull request #1800 from DMPRoadmap/refactor/tomdoc ... Rewrite YARD comments as Tomdoc. Brian Riley authored on 13 Aug 2018 GitHub committed on 13 Aug 2018
	694b2d6 Browse files » Fix for "Plan Download". ... This is a clean up of code based on PR comments. Also updated the ExportablePlan helper method as_csv() to work with the selections made on the Plan Download page. Issue #1730 John Pinto committed on 13 Aug 2018
	Unverified 4bbbe23 Browse files » Remove redundant database tables and columns ... Remove redundant columns and tables listed in #1382 Update models and factories with new schema structure comments. Bodacious committed on 13 Aug 2018
	08ae4a1 Browse files » Fix for "Plan download file not filtering on selection on Download page". ... Issue #1730 Also included is a fix for rendering if saving a new plan or editing a plan that results in errors. John Pinto committed on 13 Aug 2018
	Unverified 52a160b Browse files » Replace YARD documentation with Tomdoc ... These changes use the YARD gem, but in the lighter Tomdoc format. You can read more about Tomdoc here: https://tomdoc.org Bodacious committed on 13 Aug 2018
2018-08-10	Unverified 2f553e6 Browse files » Update schema annotations on Org model Bodacious committed on 10 Aug 2018
2018-08-10	Unverified 13ddd32 Browse files » Remove uniqueness validation from Org abbreviation Bodacious committed on 10 Aug 2018