Remove old JS form validations (#1867) ...

* added new form validation error handling

added tests for orgs controller

converted over remaining controllers to new errors

enhanced message handlers in application controller

finished form validations

* fixed rubocop for all controllers

* Fix broken specs

- Factories needed to be updated to meet new validation requirements
- Spec was broken since error message had changed

* Fix errors and warnings from npm audit

Merge branch 'development' into issue-1833

Fix field alignment in questions form

Refactor Template creation views and controllers

Extract org swapping into own resource

Refactor how section ordering is handled (#1837) ...

* Extract template customizations into own controller

* Refactor Template model methods

* Fix view logic in draggable sections

* Add button for customising phase

* Fix rubocop violations in GuidanceService

* Rename GuidanceService to GuidancePresenter

* Fix bug in phase preview order sections

* Refactor preview action/controller code

* Fix Section ordering in various views

* Fix rubocop violations

* Fix bug forcing Phases to be modifiable

* Fix broken tests

* Update method to check if section is draggable

* Extract copy action into its own resource

* Extract customization transfers to own controller

* Remove redundant routing condition

* Fix Rubocop violation issues

* Change condition for section draggable

* Refactor instance variable in PlansController

* Fix broken tests

* Add test support for 'de' locale

* Fix merge issue in plans controller

* Fix broken specs in plan#request_feedback

Issue 532 (#1847) ...

* Replaced instances of `raw` with `sanitize`

* Updated Brakeman ignores

* Remove unnecessary sanitation

* Add support for TinyMCE tags

Fix TinyMCE JS on forms loaded with DOM (#1827) ...

* Fix TinyMCE JS on forms loaded with DOM

Fixes #1777

* Fix broken specs

* Fix Rubocop style violations

Ignored LineLength violations when string is part of FastGettext

* Updated rubocop style gem

Ensure annotations destroyed when text is blank ...

When a user updates an existing annotation to set its text to blank, this
should destroy that annotation record on the DB—since they can't be valid without
text.

Refactor template index views to use instance vars

Deprecate non-idiomatic helper method name

Add specs for editing template question

Change tooltip on container page if all modifiable ...

If all of the sections are modifiable, we don't need the second part of the tooltip that reads: "You may place them before or after the main template sections."

Only show this if some of the Sections are unmodifiable

Replace YARD documentation with Tomdoc ...

These changes use the YARD gem, but in the lighter Tomdoc format.

You can read more about Tomdoc here: https://tomdoc.org

Add tests to check that Template copying works

Merge pull request #1794 from DMPRoadmap/refactor/template-number-field ...

Remove specs referencing `sections.published`