opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / app / models / phase.rb

2018-07-25	Unverified 0d4cdee Browse files » Add extra validations for all models ... - Includes specs using the Shoulda gem - Includes a refactoring of update_numbers to a "sortable" abstraction Bodacious committed on 25 Jul 2018
2018-07-16	ec700a6 Browse files » fixed issues with saving and displaying of template stack ... Removed comments briley committed on 16 Jul 2018
2018-07-13	Unverified 0a6c232 Browse files » Merge pull request #1715 from DMPRoadmap/issue-1371 ... Add ability to sort phase sections by dragging Brian Riley authored on 13 Jul 2018 GitHub committed on 13 Jul 2018
2018-07-13	Unverified 06725b3 Browse files » Remove section ordering from Phase assocs Bodacious committed on 13 Jul 2018
2018-07-12	Unverified c27697d Browse files » Add annotate gem for models and Gemfile Bodacious committed on 12 Jul 2018
	Unverified ca4a6ad Browse files » Make sections within a phase sortable Bodacious committed on 12 Jul 2018
	a167b6f Browse files » Remove Rails 3 attr accessible from models (#1691) Gavin Morrice authored on 12 Jul 2018 Sam Rust committed on 12 Jul 2018
2018-05-23	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
2018-05-23	50067f0 Browse files » Ruby Upgrade v2.4.4 ... ---------------------------------------- cleaning unused gems and upgrade to Ruby v2.4.1 fix node modules issues when running the upgrade update travis.yml to Ruby v2.4.1 Remove Friendly Id gem and related code references. Upgrading the Devise, Omniauth and Pundit gems and removing version numbers Upgrading views related gems like recaptcha, formtastic, dragonfly Upgrade development group gems like kaminari, byebug, better_errors, web-console, binding_of_caller, rack-mini-profiler Upgrade test group gems like racktest, webmock, sqlite, simplecov Upgrading Exporting and Internalization gems in the Gemfile Ruby upgrade to 2.4.4 Fix assert nil warnings in tests reremoved administrate gem fixed merge conflicts bhavi authored on 1 May 2018 briley committed on 23 May 2018
2018-02-13	8158b86 Browse files » migration to add complete flag to plans. #154 ... Integrate pre-fetching plan and phase from `25e2669` after_save callback for answer model with tests. #154 rake task to update completed plans. #154 statistics#completed_plans action done. #154 HTML view for completed plans and tweaks to JS file associated. #154 Jose Lloret committed on 13 Feb 2018
2018-01-26	3ba8776 Browse files » made template details a non-versioning update and moved template version logic to the phases controller ... fixed tests and updated plan creation Brian Riley committed on 26 Jan 2018
2018-01-22	7be8e77 Browse files » templates history paginablerised. DMPRoadmap/roadmap#1067 Jose Lloret committed on 22 Jan 2018
2017-12-04	c24d14d Browse files » Plan answers including multi-phase tab. DMPRoadmap/roadmap#859 Jose Lloret committed on 4 Dec 2017
2017-10-20	22190a6 Browse files » Plan progress changed in favour of phase from a plan progress. DMPRoadmap/roadmap753 Jose Lloret committed on 20 Oct 2017
2017-06-06	40eaffd Browse files » Default ordering for Phase, Question becomes .number - closes #402 Jimmy Angelakos committed on 6 Jun 2017
2017-04-28	d1b09d7 Browse files » fixed merge conflict in schema.rb Brian Riley committed on 28 Apr 2017
2017-04-26	fa67892 Browse files » moved some of the logic that was defaulting template attributes in the controller over to the model. Fixed tests DMPRoadmap/roadmap#251 DMPRoadmap/roadmap#273 Brian Riley committed on 26 Apr 2017
2017-04-26	9465772 Browse files » section association sorted by number rather than id. DMPRoadmap/roadmap#269 ... Funder and Institution displayed adequately. DMPRoadmap/roadmap#269 Jose Lloret committed on 26 Apr 2017
2017-04-25	11234f3 Browse files » moved most of the save logic from the template controller to the model. Updated the phases/section/question models to use the after_save callback to handle updating the template.dirty flag Brian Riley committed on 25 Apr 2017
2017-04-18	a3f86db Browse files » added a test that searches for missing translations. Added specific error messages for model validations. Added some devise controlled error messages to pot/po files DMPRoadmap/roadmap#236 briley committed on 18 Apr 2017
2017-02-15	b4389d8 Browse files » mege in head changes Ray Carrick committed on 15 Feb 2017
2017-02-15	ab0988f Browse files » trying to reduce data access queries. Needs more work Ray Carrick committed on 15 Feb 2017
2017-02-14	052a026 Browse files » Merge branch 'final_schema' of https://github.com/DigitalCurationCentre/roadmap into final_schema xsrust committed on 14 Feb 2017
2017-02-14	e4591bf Browse files » removed slugs unique requirement from phases ** may break other code xsrust committed on 14 Feb 2017
2017-02-08	017d830 Browse files » some cleanup of irrelevant objects (e.g. removal of remaining OrganisationType) briley committed on 8 Feb 2017
2017-02-03	d4ae801 Browse files » init commit of deep_copy for templates [untested] xsrust committed on 3 Feb 2017
2017-01-31	636fa37 Browse files » fixed unit tests for phases briley committed on 31 Jan 2017
2017-01-26	1bcfe8d Browse files » added some more attr_accessible attributes for new fields. finished up seed.rb file. briley committed on 26 Jan 2017
2017-01-26	f18ea4d Browse files » resolved merge conflicts briley committed on 26 Jan 2017
2017-01-24	568a84e Browse files » cleaned up tests briley committed on 24 Jan 2017