opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / app / models / template.rb

2018-07-25	Unverified e4bd87a Browse files » Update validations with suggestions from team Bodacious committed on 25 Jul 2018
2018-07-25	Unverified 0d4cdee Browse files » Add extra validations for all models ... - Includes specs using the Shoulda gem - Includes a refactoring of update_numbers to a "sortable" abstraction Bodacious committed on 25 Jul 2018
2018-07-19	cf379ca Browse files » Add annotate gem for models and Gemfile Bodacious authored on 12 Jul 2018 briley committed on 19 Jul 2018
	4019a97 Browse files » Remove Rails 3 attr accessible from models (#1691) Gavin Morrice authored on 12 Jul 2018 briley committed on 19 Jul 2018
	36f8e09 Browse files » Fix bug preventing Template model from loading Bodacious authored on 12 Jul 2018 briley committed on 19 Jul 2018
	a8162b2 Browse files » Refactor scopes back into Template model Bodacious authored on 12 Jul 2018 briley committed on 19 Jul 2018
2018-05-23	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
2018-04-06	7850aea Browse files » added base_template_org and updated write plan to show correct org in guidance tab ... updated example answers logic added missing code to answers conroller and fixed test Brian Riley committed on 6 Apr 2018
2018-04-06	9d5bbaf Browse files » Existing template customisation appears now to be editable. DMPRoadmap/roadmap#1318 Jose Lloret committed on 6 Apr 2018
2018-04-05	4c46272 Browse files » patch to fix issue with default template visibility setting ... added nil check reverted changes to schema.rb briley committed on 5 Apr 2018
2018-03-02	84d2dbd Browse files » updated templates to display customisation in messaging when appropriate Brian Riley committed on 2 Mar 2018
2018-02-21	13f662a Browse files » perpetuate default template flag across versions ... perpetuate default template flag across versions briley committed on 21 Feb 2018
2018-02-06	8f665ba Browse files » fixed create plan logic ... fixed tests fixed tests briley committed on 6 Feb 2018
2018-01-26	3ba8776 Browse files » made template details a non-versioning update and moved template version logic to the phases controller ... fixed tests and updated plan creation Brian Riley committed on 26 Jan 2018
2018-01-19	6beb771 Browse files » public DMPs paginablerised. DMPRoadmap/roadmap#1055 ... public DMPs templates paginablerised. DMPRoadmap/roadmap#1055 plans visible to org admin paginablerised. DMPRoadmap/roadmap#1055 guidances paginablerised. DMPRoadmap/roadmap#1055 guidance_groups paginablerised. DMPRoadmap/roadmap#1055 remove tablesorter class from paginable views. Introduce Clear search results when ALL search results are active. DMPRoadmap/roadmap#1055 guidance policy for paginable/guidance/index/:page. DMPRoadmap/roadmap#1055 Jose Lloret committed on 19 Jan 2018
2018-01-17	8b835a4 Browse files » moved template pagination logic to paginable namespace ... moved logic from concern to lib/filter and fixed tests made template tables sortable updated sort links Brian Riley authored on 12 Jan 2018 briley committed on 17 Jan 2018
2017-12-22	80076b7 Browse files » Templates table revisions #900 (In Progress) ... added tests updates to controller and model methods updated view tested and adjusted scoping queries added unit tests for new latest customization queries updated tests updated tests and added predefined scopes back to funders templates finialized tests for new template page removed debug statements bhavi authored on 20 Dec 2017 Brian Riley committed on 22 Dec 2017
2017-12-19	eba4ccf Browse files » added all/published/unpublished scopes to the templates tables ... removed debug statements updated main index action optimized query for customizations briley committed on 19 Dec 2017
2017-12-11	82721bf Browse files » using activerecord for subqueries too. Case for latest version of templated. DMPRoadmap/roadmap#928 Jose Lloret committed on 11 Dec 2017
2017-12-08	00d7e73 Browse files » Make templates page usable for Org Admins and Super Admins ... started work on super admin templates page consolidated org_admin and super_admin templates page moved template logic to org_admin module and consolidated logic for super/org admins switched from submit button click to form submit fixed issue with unused js var fixed broken templates controller tests switched back to submit button updated template_options route in integration test fixed broken integration tests caused by moving templates to org_admin namespace added tests for copy template added button to get back to 'all templates' page from template edit page renamed delete button from 'Cancel' to 'Delete' and added proper cancel button to edit section view made recommended adjustments and accounted for new template visibility functionality switched out scopes in favor of flagshihtzu helpers moved link to Themes to Admin menu fixed broken tests for the public_pages controller fixes for tests refactored template current version queries pulled in customization view changes briley authored on 27 Nov 2017 Brian Riley committed on 8 Dec 2017
2017-12-06	d6e51ed Browse files » Added ability to set template visibility for funders ... enabled template visibility added ability to set template visibility for funders fixed typo in scope removed aria-required shortened if else for visibility in templates_controller briley committed on 6 Dec 2017
2017-11-27	798a516 Browse files » concern to validate and parse an array of object links. DMPRoadmap/roadmap#819 ... validator for links attribute at templates. DMPRoadmap/roadmap#819 funder and sample links visible in funder templates html view. DMPRoadmap/roadmap#819 links view and its JS associated. DMPRoadmap/roadmap#819 Jose Lloret committed on 27 Nov 2017
2017-11-16	fa6ec53 Browse files » Fix conflicts with merging dev into CDL xsrust committed on 16 Nov 2017
2017-11-06	9e0b576 Browse files » Default templates placed before funder templates with dynamic plural. DMPRoadmap/roadmap#612 ... Retrieves all valid, published, is default templates for any organisation type whose user does not belong to. DMPRoadmap/roadmap#612 removed if from view. no longer relevant. DMPRoadmap/roadmap#612 Jose Lloret committed on 6 Nov 2017
2017-10-24	2ba66f7 Browse files » updated default template selection logic, added helper function to find default template xsrust committed on 24 Oct 2017
2017-06-15	17b6eff Browse files » updated other controller actions shown to throw error by test, we render phases/admin show from other controllers, so need same instance variables defined xsrust committed on 15 Jun 2017
2017-06-09	5c2dd1f Browse files » updated admin_index for templates to not bug for some orgs, reimplimented logic for transfering customizations, changed text according to #338 xsrust committed on 9 Jun 2017
2017-06-02	71bab65 Browse files » Updated translation strings & added :migrated attribute access to template model Jimmy Angelakos committed on 2 Jun 2017
2017-05-26	bec5774 Browse files » bugfixes to allow tests to work xsrust committed on 26 May 2017
2017-05-26	2e9c4f0 Browse files » updated org-admin and plan create pages to reflect schema change xsrust committed on 26 May 2017