Remove old JS form validations (#1867) ...

* added new form validation error handling

added tests for orgs controller

converted over remaining controllers to new errors

enhanced message handlers in application controller

finished form validations

* fixed rubocop for all controllers

* Fix broken specs

- Factories needed to be updated to meet new validation requirements
- Spec was broken since error message had changed

* Fix errors and warnings from npm audit

Issue 532 (#1847) ...

* Replaced instances of `raw` with `sanitize`

* Updated Brakeman ignores

* Remove unnecessary sanitation

* Add support for TinyMCE tags

Fix bug preventing orgs loading on register page ...

Recent updates to the DB have made the `is_other` field on the Orgs table mandatory.
Previously, it was loading null values. This PR updates this to load false values instead.

Fixes #1809

Merge branch 'development' into fix/account_creation

Remove references to Org#parent_id

Removed 'Other' org from combobox to avoid confusion

Fixed empty 'Organisation' field issue

switched back to allowing multiple themes per guidance and fixed error display for 'accept terms' on create account form ...

updated tooltip

fixed issue with checkbox error display, removed old JS for create account form, fixed create account form namespacing (#1686)

fixed issue with checkbox error display, removed old JS for create account form, fixed create account form namespacing (#1686)

Add <fieldset> markup to radio buttons and check boxes #1448 ...

remove the 'for' attribute for any check boxes or radio buttons that are embedded within the <label> tag

Add form validations (#1588) ...

removed formtastic

added required asterisks to create plan page and updated JS logic of Org selection

added namespaces to edit profile, sign in and create account forms to fix duplicate id issue

fixed JS behind links and their validation

fixed JS behind links and their validation

removed console.log statement and added rake tasks for data validation cleanup

Add form validations

removed formtastic

added required asterisks to create plan page and updated JS logic of Org selection

added namespaces to edit profile, sign in and create account forms to fix duplicate id issue

fixed JS behind links and their validation

fixed JS behind links and their validation

removed console.log statement and added rake tasks for data validation cleanup

made recommended adjustments

reverted schema.rb

removed unecessary other_org query

Merge branch 'development' into login_workflow

New login workflow changes (post-shibboleth authentication) ...

- New dual choice layout in app/views/devise/registrations/new.html.erb
- Changes to omniauth_callbacks/application/registrations/sessions controllers to support choice post-shibboleth auth:
  - Do you have an account? Sign in to link your shibboleth credentials
  - If you don't have an account, sign up and this will link your shibboleth credentials
- Changes to sign in, create account, and password details forms for multiple onscreen "show password" tickboxes
- Aesthetic change to clear-field (X) icon (align it with input field and bring it inside)

Create account org is needed now. Fixed find nil whne swaping orgs. #1144

Created shared org autocomplete/other org control for Profile and Create Account pages ...

added js and css for autocomplete box and other org toggle

added logic to disable org change while account is linked. added warning for org admin about losing priveleges

tweaked css to work on both forms. added logic to hide link creds if no org

removed change to package-lock.json

fixed logic bug in display of shib link

removed check for nil allow_other_orgs

removed recovery_email from the 2 forms and fixed bug in edit profile save

Merge branch 'static_pages' of https://github.com/CDLUC3/roadmap into static_pages

change single quotes occurances wiht double for consistency

Bug fixes to the create account/sign in/reset password/shib DS pages ...

fixed JS issues on shibboleth_ds and bootstrapped page

added js-cookie and fixed remember-email functionality

fixed issue with random empty notices appearing

added documentation to ariatiseForm and updated create account form

Converted popovers and tooltips to Bootstrap tooltips DMPRoadmap/roadmap#568 ...

commented out import of old ES5 tooltip JS

added bootstrap tooltip wiring to application.js

removed boostrap tooltip/popover calls from devise/regisitrations/edit and updated html

added placement and animation rules to general tooltip init. converted edit plan details page to use tooltips

removed irrelevant data-placement from edit profile tooltips

converted guidance group popovers to tooltips

converted guidance popovers to tooltips

converted popovers on phase edit/add to tooltips

converted popoevers to bootstrap tooltips on sections and questions

removed popover references from annotations, and templates

boostrapped the shibboleth_ds page and converted ES5 to ES6

fixed linter issues with shib_ds. added tooltip functionality to autocomplete erb

updated tooltip on create account page

updated tooltips on table filter and grant permissions pages

removed redundant right placement on personal details form

fixed broken test

updated passwordHelper so that html page is providing show password checkboxes and js only handles display DMPRoadmap/roadmap#558

added ES6 JS for sign in and create account forms DMPRoadmap/roadmap#558

bootstrapped the sign in and create account forms DMPRoadmap/roadmap#558