Remove old JS form validations (#1867) ...

* added new form validation error handling

added tests for orgs controller

converted over remaining controllers to new errors

enhanced message handlers in application controller

finished form validations

* fixed rubocop for all controllers

* Fix broken specs

- Factories needed to be updated to meet new validation requirements
- Spec was broken since error message had changed

* Fix errors and warnings from npm audit

Fix broken test in plan exports

Merge branch 'development' into issue-1843

Merge branch 'development' into issue-1833

Merge branch 'development' into issue-1844

Fix bug preventing PDF downloads from dashboard

Fix Rubocop offenses

Refactor sections controller create action

Refactor Template creation views and controllers

Extract org swapping into own resource

Move template options to main namespace

Fix bug preventing plans from downloading

Refactor plan exports. Extract into own resource

Refactor template options into own controller

Fix sorting in plans controller

Refactor how section ordering is handled (#1837) ...

* Extract template customizations into own controller

* Refactor Template model methods

* Fix view logic in draggable sections

* Add button for customising phase

* Fix rubocop violations in GuidanceService

* Rename GuidanceService to GuidancePresenter

* Fix bug in phase preview order sections

* Refactor preview action/controller code

* Fix Section ordering in various views

* Fix rubocop violations

* Fix bug forcing Phases to be modifiable

* Fix broken tests

* Update method to check if section is draggable

* Extract copy action into its own resource

* Extract customization transfers to own controller

* Remove redundant routing condition

* Fix Rubocop violation issues

* Change condition for section draggable

* Refactor instance variable in PlansController

* Fix broken tests

* Add test support for 'de' locale

* Fix merge issue in plans controller

* Fix broken specs in plan#request_feedback

Issue 532 (#1847) ...

* Replaced instances of `raw` with `sanitize`

* Updated Brakeman ignores

* Remove unnecessary sanitation

* Add support for TinyMCE tags

Issue 1845 (#1846) ...

* Fix bug preventing Feedback from being requested

* Fix Rubocop violations

* Extract feedback requests into own controller

* Add test for feedback requests

* Fix Rubocop violations

Exported Plan bug and style fixes: ...

- The csv export now shows the project coversheet text when the option is selected.
- the text export now shows the questions when question text option selected.

Issue/1815 (#1831) ...

* # This is a combination of 2 commits.
# The first commit's message is:

updated logic on number of non-customized templates

# This is the 2nd commit message:

noticed other stats affected by customizations_vs_funder mismatched, so fixed those

* Updated logic on number of non-customized templates, published, unpublished

Fix TinyMCE JS on forms loaded with DOM (#1827) ...

* Fix TinyMCE JS on forms loaded with DOM

Fixes #1777

* Fix broken specs

* Fix Rubocop style violations

Ignored LineLength violations when string is part of FastGettext

* Updated rubocop style gem

Merge pull request #1822 from DMPRoadmap/issue-1570 ...

Refactor routes for better maintainability

Refactor routes for better maintainability ...

- Remove redundant routes (Fixes #1699, Fixes#1570)
- Remove redundant actions
- Remove redundant policy methods
- Fix invalid actions (public methods defined on controllers)
- Set concern methods as private
- Extract session locale method from ApplicationController into its own controller
- Explicitly define actions in statics controller for better readability

Ensure annotations destroyed when text is blank ...

When a user updates an existing annotation to set its text to blank, this
should destroy that annotation record on the DB—since they can't be valid without
text.

Remove !bang save and updates when if condition

Refactor template index views to use instance vars

Merge pull request #1802 from DMPRoadmap/refactor/database-cleanup ...

Remove redundant database tables and columns

Remove references to Org#parent_id

Merge pull request #1800 from DMPRoadmap/refactor/tomdoc ...

Rewrite YARD comments as Tomdoc.

Fix for "Plan Download". ...

This is a clean up of code based on PR comments.

Also updated the ExportablePlan helper method as_csv() to work with the selections made on the Plan Download page.

Issue #1730