Fix for ensuring that Questions that are option based must have atleast one non-blank text entry. ...

- Validation added for option based questions to ensure text field non-blank.
    - Validation message OPTION_PRESENCE_MESSAGE added to app/models/concerns/validation_messages.rb.
    - Added ':allow_nil => true' to
            delegate :option_based?, to: :question_format, :allow_nil => true
     in Question model to prevent NoMethodError if question_format is nil.

    Fix for #1725

Merge pull request #1982 from DMPRoadmap/fix-karma ...

Moved JS tests and added karma/jasmine for JS tests

moved JS tests to the spec dir and fixed issues with karma/webpack/jasmine ...

added lint and updated bundle task to use yarn

added lint and updated bundle task to use yarn

Changed links to icons for file download. ...

- Using fontawesome icons file-pdf-o and file-word-o

    Fix for Issue #1164

renamed yml examples. added them to bin/setup and added eslint init to travis ...

added eslintrc.json back

moved eslintrc to loaders dir

removed eslint init statement

fixed up eslinter

updated rack and destructured array and object assignments in js. updated release portion of readme

added eslintrc back to gitignore

fixed issue with create plan JS, fixed some warnings in specs

removed console.log statements and updated linter task in travis

Update asset structure with webpacker gem

Fix broken functional tests ...

Fix broken specs with random see 55679

Fix broken tests for random seed 19381

Temporarily disable travis security checks

Since I'm testing the specs, this should help make it faster

Fix bug caused by random Org locale

Fixes recurring issue with tests being loaded in German

Fix broken specs

Fix tests breaking with seed 60029

Fix broken specs with seed 12116

Fix broken specs with seed 51011

Fix broken template upgrades specs

Fix travis artifacts addons

Add Travis asset debugging

Remove Amazon S3 region from asset uploads config

Move S3 configs to local travis file

Re-add hygiene tasks to Travis YML

Disable broken test for now

Refactor tests for template upgrade customisations

Update test suite to allow re-using rand seed ...

Will help in debugging tests that are failing on Travis

Merge pull request #1951 from DMPRoadmap/issue-1949 ...

Fix bug choosing locale with region suffix

Fix bug choosing locale with region suffix

Change column titles in usage CSV download ...

Fixes #1938

Merge pull request #1929 from DMPRoadmap/issue-1853 ...

Fix bug preventing new sections from merging into persisted phases

Merge pull request #1928 from DigitalCurationCentre/data_cleanup_additions ...

update guidance spec to allign with changes to validation logic

updated guidance_spec syntax

Fix bug when upgrading Template with new Sections ...

Section presence validation was preventing Question from being saved. This was preventing
new Sections from being saved.

updated guidance spec to allign with validation changes

Fix how section number is set

Fix how section number is set

Fix bug in upgrade customization when new section ...

Adding a new section to the customized template was conflicting with the number value
on the corresponding funder template section.

Add functional specs for upgrade customisation

Update tinyMCE helper to match capybara format

Started Services and Actions for #1689 (#1871) ...

StatCreatedPlan/StatJoinedUser Services and Action finished. #1689

removed comment. #1689

usage#all endpoint for all usage CSV reports. #1689

usage#all endpoint with request test associated. #1689

Removed require from files

Moved generate actions into services [#1689]

Renamed joined_user service related [#1689]

Renamed stat_created_plan action to service [#1689]

Removed action total_stat in favour of total_count_stat_service

UsageDownloadController using Org::TotalCountStatService instead of the action

Change to remove multi select box as an answer format. ...

- Removed test multiselectbox_questions_spec.rb, as multi-select
functionality no longer used.

Fix for issue #1771

Fix broken org factory

Fix broken tests caused by locale configuration (#1875) ...

* Fix broken tests caused by locale configuration

- Add LocaleSet
- Add LocaleFormatter to force proper string formats
- Rename I18n formats to use hyphen
- Add rake task for updating existing languages on DB
- Fix instances of US english in the templates

* Fix FastGettext initializer loader

* Add Amazon S3 creds for Travis

* Revert "Add Amazon S3 creds for Travis"

This reverts commit 366c1a7.

* Fix Faker localization for rake tasks

Was breaking rake db:seed file

Repair broken or pending specs (#1874) ...

- Fix pending Template model specs

- Fix pending model specs

- Fix broken/pending specs, including random "errors" bug

added validation tests (#1868) ...

added validation tests

added fr for I18n failing tests

Fixed issues with data_cleanup and section_sorter (#1859) ...

* updated mysql query to update phase/section/question numbering, moved versionable_id rake task, fixed issue with section_sorter

fixed test

* Moved private methods from migrate to upgrade rake

Remove old JS form validations (#1867) ...

* added new form validation error handling

added tests for orgs controller

converted over remaining controllers to new errors

enhanced message handlers in application controller

finished form validations

* fixed rubocop for all controllers

* Fix broken specs

- Factories needed to be updated to meet new validation requirements
- Spec was broken since error message had changed

* Fix errors and warnings from npm audit

Refactor how Template upgrade customization works (#1856) ...

* Refactor how Template upgrade customization works

- Added position_in_parent to child-records Phase, Section, and Questions
- Extracted upgrade_customization! into its own service object

wip: rebasing on development

wip: pushing to Ghub

wip: Template upgrade customisation service working

Add migration to update versionable_id for records

* Fix bug in org swaps test

Test was failing because JS wasn't executing fast enough in test browser

* Refactor how locales are set in specs

* Fix bug in plan exports caused by git merge

The routes weren't merged properly which seems to have caused a regression error

* Add documentation for SectionSorter

* Update rubyzip and re-instate Bundle Audit

This was disabled because it was failing the Travis CI script. Since there wasn't a
new version of the rubyzip gem to upgrade to, we couldn't turn the error off.

* Add length constraints to versionable_id

* Add length constraints to versionable_id

* Fix bug in ActsAsSortable module

... I have no idea why those issues haven't popped up before now!?

* Fix random bug in I18n

* Move versioning ID migration into own rake task