Merged DMPRoadmap V2.1.6

Removed plans list when visiting a user profile as super admin

Changes were made to the HTML h tags - Issue 1451 (#2423) ...

* capture status

* Changes were made to the HTML h tags in order to make it more accessibility friendly and compliant

* Changes to make merge with development possible

* Fixe of the empty class

fix super_admin user department dropdown size

Modify Merge Account messaging (#2287) ...

* revised user merge text and made responsive

* remove debug  lines

* update for eslint errors

* actually fixes eslint issues, this time with testing locally

fixed issue with archiving users (#2286)

Updated functionality for Admin View of Users. ...

Changes:
 - for Super Admins: Added user department and plans.
 - for Org Admins:
        (1) The user view now has a clickable link for opening up
            a view of a user's profile and plans.
        (2) In a user's profile view the Department if it exists for the
            organisation is editable. The Organisation must have
            departments in systerm to avail of this functionality.

Fix for #2240.

fixed placeholder text on search form

add confirmation dialog and fix merge logic

capture status

Enable spellcheck for text fields: ...

Changes:
 - added HTML 5 attribute spellcheck= "true" to text_field tag by adding
        spellcheck: true.
 - Did not add this attribute to text_fields for:
    firstname,
    surname,
    principal_investigator_name &
    data_contact.
   (it is irritating for folk to have a spellchecker say your name is incorrectly spelt.)

Fix for issue #2169.

Remove old JS form validations (#1867) ...

* added new form validation error handling

added tests for orgs controller

converted over remaining controllers to new errors

enhanced message handlers in application controller

finished form validations

* fixed rubocop for all controllers

* Fix broken specs

- Factories needed to be updated to meet new validation requirements
- Spec was broken since error message had changed

* Fix errors and warnings from npm audit

Add tests for locale setting (#1823) ...

* Add tests for locale setting

- Adds Faker::Language module for testing languages with real-ish data
- Refactors global constants into Language model (See Issue#1696)
- Add specs to test locale change works

* Clean up language files to remove long names

* Add DB check in FastGettext initializer

* Set Memory cache for temporary caching solution

* Fix bug in Plan Rule

reverted changes to buttons <button><a ...></a></button> is invalid HTML5 and does not work in all browsers (#1636)

fixed issue with saving other org on sup_admin edit user (#1614) ...

reverted my_org

added fix for super admin

update to logic

fixed tests

fixed issue with Tinymce toolbar (#1611) ...

removed trailing spaces

switched selector for notifications tinymce

reverted back to passing tollbar

Fix buttons that do not provide a visual cue indicating that they have focus #1443 (#1600)

Add form validations (#1588) ...

removed formtastic

added required asterisks to create plan page and updated JS logic of Org selection

added namespaces to edit profile, sign in and create account forms to fix duplicate id issue

fixed JS behind links and their validation

fixed JS behind links and their validation

removed console.log statement and added rake tasks for data validation cleanup

Add form validations

removed formtastic

added required asterisks to create plan page and updated JS logic of Org selection

added namespaces to edit profile, sign in and create account forms to fix duplicate id issue

fixed JS behind links and their validation

fixed JS behind links and their validation

removed console.log statement and added rake tasks for data validation cleanup

made recommended adjustments

reverted schema.rb

removed unecessary other_org query

Add missing gettext markup to titles and skip main content link issues #1441 and #1442" (#1601)

Put back titles for missing pages issue #1441

Page titles should be unique and descriptive #1441

Implemented Notifications ...

updated tests to work with current test infrastructure

forgot to add test file

switched from url to path to correct 'Mixed content https vs http' issues

added active flag to users and updated admin users page to allow admin to update the value ...

updated column text

Updated inactive message

updated mailers to exclude inactive users except for sharing and devise emails about their account

added tests for super admin users. added functionality for super admin to edit user info

added org and created columns to users table

swapped in good schema.rb

removed debug line

added new field to schem.rb manually

fixed schema.rb

added button to go back to users and switched from and to &&

fixed typo in schema.rb

updated tables so they have default sorts. updated paginable clear/search links ...

added logic to retain sort info after search

fixed sort link and updated tests

reverted changes to concern and paginable/search erbs

reverted tests

page ALL is retained if latest request contains it. Sort links are now right aligned within the th. #1105 ...

default sorting to paginable concern specified through query_params keyword. #1105

paginable plans including default sorting

paginable orgs including default sorting. #1105

added super admin org pages ...

turned shib DS off

fixed tests

fixed tests

destroy action for themes. DMPRoadmap/roadmap#939 ...

unobtrusive ajax for plans#set_test. DMPRoadmap/roadmap#939

unobtrusive ajax for plans#duplicate. DMPRoadmap/roadmap#939

unobtrusive ajax for plans#visibility. DMPRoadmap/roadmap#939

renamed new_edit.js for themes. DMPRoadmap/roadmap#939

server logic for themes index, new, create, edit and update actions. DMPRoadmap/roadmap#869 ...

client logic for themes new_edit view. DMPRoadmap/roadmap#869

functional tests for themes_controller. DMPRoadmap/roadmap#869

helper path instead of url_for. ThemePolicy without namespace. DMPRoadmap/roadmap#869