Merge pull request #2128 from DMPRoadmap/feature/research-grant-id ...

Add typeahead field for Research Grant ID

Merge branch 'development' into feature/research-grant-id

Merge branch 'development' into feature/reviewer_role

refactored review access from role to permission

Add typeahead field for Grant ID

Allow org admins to view 'share plan' page. ...

Changes:
 - Updated share? method in the class PlanPolicy.
 - Also fixed Rubocop warnings in PlanPolicy.
 - Updated _navigation.html.erb and _share_form.html.erb
   to enable org admins to view the Share tab of org plans.

Fix for #2090.

Table View Issue for Readonly Content of Plan and Template pages. ...

Changes:
- to re-style the readonly text tables with padding
- added the TinyMCE like styling to the Phase overview description

Fix for #2071.

The "Request expert feedback" text area on the Share Plan page displayed ...

Ruby strings  %{user_name} and %{plan_name} that were not interpolated.

- The strings are now interpolated.
- The function helper function feedback_constant_to_text in FeedbacksHelper
 displays the user name instead of the email.
- also Rubocop errors and warnings in FeedbacksHelper were fixed.

Fix for issue #2047.

added logic to hide guidance selection if there is no selectable guidance (#2021) ...

fixed typos

updated Role, Plan logic and fixed tests

Issue #1161 - Display tooltip below form fields on Create plan page. ...

- Required modification for the intiialization of Bootstrap tooltips in the javascript file
      /utils/tooltipHelper.js. The default behaviour is placement of tooltip to the right of element
      with attribute data-toggle='tooltip'. Now if the attribute data-placement attribute is set,
      then the placement of the tootip will be as specfied in the attribute and not on the right (the default behaviour).
    - The accessible combob-box now takes an optional property 'placement' which if present sets data-placement
      attribute to the value of the placement property.
    - Now all Create Plan page tooltips are below the input as requested.

Fix for #1161.

added hidden field to plan_export_form, updated controller auth logic to allow public plan owners to choose options

fixed layout issues on create plan page

accessibility fix - add 'new window' text for screen readers when links has target=_blank (#1901) ...

added sr logic to download_plan submit button

Remove old JS form validations (#1867) ...

* added new form validation error handling

added tests for orgs controller

converted over remaining controllers to new errors

enhanced message handlers in application controller

finished form validations

* fixed rubocop for all controllers

* Fix broken specs

- Factories needed to be updated to meet new validation requirements
- Spec was broken since error message had changed

* Fix errors and warnings from npm audit

Textual changes made to Plan Edit Details Page: (#1858) ...

* Textual  changes made to Plan Edit Details Page:

- 'Submit' buttons renamed 'Save'
- 'Plan Guidance Configuration' chanded to 'Select Guidance'

* Updated button name in  in failing plans_spec.rb test from
"Submit" to "Save".

Merge branch 'development' into issue-1843

Add specs for PDF download link

Move template options to main namespace

Fix bug preventing plans from downloading

Refactor plan exports. Extract into own resource

Issue 532 (#1847) ...

* Replaced instances of `raw` with `sanitize`

* Updated Brakeman ignores

* Remove unnecessary sanitation

* Add support for TinyMCE tags

Issue 1845 (#1846) ...

* Fix bug preventing Feedback from being requested

* Fix Rubocop violations

* Extract feedback requests into own controller

* Add test for feedback requests

* Fix Rubocop violations

Deprecate non-idiomatic helper method name

Added missing VALID_FORMATS settings to models/settings/template.rb. ...

Update package name for VALID_FORMATS in _download_form.html.erb.

Make feedback email message html safe again ...

Fixes bug added in previous request.

Fix bug when org feedback email message is nil

Update feeback requests to provide more info ...

Issue #1587

Merge branch 'development' into master

Merge pull request #1638 from CDLUC3/issue1448 ...

Add <fieldset> markup to radio buttons and check boxes #1448