remove unneeded comments, remove further references to reviewer role from tests, dry up refactored tests

removed references to role.reviewer

refactored review access from role to permission

Merge pull request #2124 from DMPRoadmap/issue2089 ...

Pre-fill ID on the plan details page.

Merge pull request #2122 from DMPRoadmap/issue2094 ...

Changed date format of footer in the Plans pdf export to a more human…

Pre-fill ID on the plan details page. ...

Changes:
  - the default plan :identifier is set to the plan :id on creation in the
    PlanControllers create method.
  - added a method add_identifier to Plan model.

Fix for issue #2089

Changed date format of footer in the Plans pdf export to a more human readable date, ...

e.g., "Last modified 26 April 2019".

Changes:
  - added :readable date format to language locales
  - used this date for the footer in the Plans pdf export.
    Note, changed " formats" to "format" and use :readable in footer date
     From  "date: l(@plan.updated_at.to_date, formats: :short)" -->
     to    "date: l(@plan.updated_at.to_date, format: :readable)"
  - to pass Rspec test spec/features/plans/exports_spec.rb we needed to add
    a locale file en.yml  which is a copy of en-GB.yml to avoid error
    "1) PlansExports User downloads their plan as PDF
     Failure/Error: date: l(@plan.updated_at.to_date, format: :readable)

     I18n::MissingTranslationData:
       translation missing: en.date.formats.readable"

Fix for Issue #2094.

updated user search after invitation to be case-insensitive

Complete merge Development -> Master

Updated Usage page display to fix several issues. ...

- Moved mouse pointer instruction.
    - Made textual changes to "No. of plans by template"
    - The bar charts for  "No. users joined during last year" and
    "No. plans during last year" months are in ascending order. They were
    in descending order previously. Updated the count statistics methods
    in statistics_controller.rb.
    - The "No. plans by template" bar chart is now  replaced by a stacked bar chart
    as this is visually better for large data.
    - updated the by_template method in the create_or_update.rb with code from @xsrust.
    This now aggregates template counts for a month correctly.

    Fix for issue #1679.

fix bugs with API: re-add date filtering, revert assumption of last month by default, re-add instance variables, fix other minor bugs

Merge pull request #2039 from DMPRoadmap/issue1872 ...

Update the text of the Comment notification email.

Merge pull request #2042 from DMPRoadmap/issue1182 ...

Make Template names an actionable link like  Project title in My Dash…

Make Template names an actionable link like Project title in My Dashboard. ...

The Template Name column links have been made the same as the corresponding link in the dropdown menu link of the Template tables with except we use the template title for the link name.

    Fix for #1182.

Merge pull request #2051 from DMPRoadmap/issue1749 ...

Added a customised error message for the case where personal details …

fixed pagination issues (#2045) ...

fixed issue with public plans template sort

Added a customised error message for the case where personal details update of the email fails because of its use already. ...

Fix for #1749.

Added UTF8 ecoding to renderer for pdf export. ...

The fix was suggested by Benjamin Faure  @benjaminfaure
https://github.com/DMPRoadmap/roadmap/issues/73#issuecomment-380854181

Fix for issue #73.

Update the text of the Comment notification email. ...

Fix for issue #1872.

Improved formatting of plan downloads. (#2035) ...

Fix for issue #1893

- Cleaned some of the formatting issues for the html, pdf and docx format
that used the partial app/views/shared/export/_plan.erb.

Fix for the scenario a plan with a question checkboxes where the a single checkbox has been checked and saved, then unchecked and saved. The bug is that the checkbox still appears. (#2034) ...

The fix was suggested by Y Chieh Henry Yang. It resets the permitted question_option_ids array to an empty array.

Fix for #1999

Merge branch 'master' into development

Merge pull request #2015 from DMPRoadmap/issue/2014 ...

issue/2014: Issues Preventing Shiboleth account creation or linking from the homescreen

updated ref (#2010)

fixed query (#2008)

updated sessions controller to no longer set shibboleth_id field on user account, changed devise registrations/new so the js could find the create-account-form.

Patch issue with share plans on development ...

Devise circumvents running validations on the user models when invite! is called.
I updated this call to adhere to validations, and I've updated the form to request the name,org of the user when a plan is shared with them.
This should fix the issue for both newly created share-plan users, and those with previous, bad data in the system.

You may want to consider re-running your validations(or fixup) scripts for users as you can have some invalid ones that you'll need to set a default name/org

made recommended adjustments

removed debug statements

finished up changes to controllers