Updated video

Remove old JS form validations (#1867) ...

* added new form validation error handling

added tests for orgs controller

converted over remaining controllers to new errors

enhanced message handlers in application controller

finished form validations

* fixed rubocop for all controllers

* Fix broken specs

- Factories needed to be updated to meet new validation requirements
- Spec was broken since error message had changed

* Fix errors and warnings from npm audit

Refactor how Template upgrade customization works (#1856) ...

* Refactor how Template upgrade customization works

- Added position_in_parent to child-records Phase, Section, and Questions
- Extracted upgrade_customization! into its own service object

wip: rebasing on development

wip: pushing to Ghub

wip: Template upgrade customisation service working

Add migration to update versionable_id for records

* Fix bug in org swaps test

Test was failing because JS wasn't executing fast enough in test browser

* Refactor how locales are set in specs

* Fix bug in plan exports caused by git merge

The routes weren't merged properly which seems to have caused a regression error

* Add documentation for SectionSorter

* Update rubyzip and re-instate Bundle Audit

This was disabled because it was failing the Travis CI script. Since there wasn't a
new version of the rubyzip gem to upgrade to, we couldn't turn the error off.

* Add length constraints to versionable_id

* Add length constraints to versionable_id

* Fix bug in ActsAsSortable module

... I have no idea why those issues haven't popped up before now!?

* Fix random bug in I18n

* Move versioning ID migration into own rake task

Fixed plan visibility when turning off test mode

rebased onto development ...

stat_created_plan_spec finished

stats table using bigint. StatJoinedUser spec done

csvable_spec done

org_date_rangeable_spec done

Actions::StatCreatedPlan::Generate spec half way done

Actions::StatCreatedPlan::Generate rspec done

Actions::StatJoinedUser::Generate spec finished

Role.with_access_flags instead of access_values_for method

Moved field validation to my_org.js

Fixed issue with Javascript

Fixed empty 'Organisation' field issue

Added automatic selection of 'Other' org when using unlisted org

Code cleanup to match Roadmap code base

Refactor how section ordering is handled (#1837) ...

* Extract template customizations into own controller

* Refactor Template model methods

* Fix view logic in draggable sections

* Add button for customising phase

* Fix rubocop violations in GuidanceService

* Rename GuidanceService to GuidancePresenter

* Fix bug in phase preview order sections

* Refactor preview action/controller code

* Fix Section ordering in various views

* Fix rubocop violations

* Fix bug forcing Phases to be modifiable

* Fix broken tests

* Update method to check if section is draggable

* Extract copy action into its own resource

* Extract customization transfers to own controller

* Remove redundant routing condition

* Fix Rubocop violation issues

* Change condition for section draggable

* Refactor instance variable in PlansController

* Fix broken tests

* Add test support for 'de' locale

* Fix merge issue in plans controller

* Fix broken specs in plan#request_feedback

Added word break when guidance in too long

Merge roadmap/master into dmpopidor_branding

Fix TinyMCE JS on forms loaded with DOM (#1827) ...

* Fix TinyMCE JS on forms loaded with DOM

Fixes #1777

* Fix broken specs

* Fix Rubocop style violations

Ignored LineLength violations when string is part of FastGettext

* Updated rubocop style gem

fixed issues with JS and updated other org selection areas to use new JS (#1805) ...

updates to JS for org selection cahnges in PR#1778

Add tests for locale setting (#1823) ...

* Add tests for locale setting

- Adds Faker::Language module for testing languages with real-ish data
- Refactors global constants into Language model (See Issue#1696)
- Add specs to test locale change works

* Clean up language files to remove long names

* Add DB check in FastGettext initializer

* Set Memory cache for temporary caching solution

* Fix bug in Plan Rule

Merge pull request #1822 from DMPRoadmap/issue-1570 ...

Refactor routes for better maintainability

Refactor routes for better maintainability ...

- Remove redundant routes (Fixes #1699, Fixes#1570)
- Remove redundant actions
- Remove redundant policy methods
- Fix invalid actions (public methods defined on controllers)
- Set concern methods as private
- Extract session locale method from ApplicationController into its own controller
- Explicitly define actions in statics controller for better readability

Ensure annotations destroyed when text is blank ...

When a user updates an existing annotation to set its text to blank, this
should destroy that annotation record on the DB—since they can't be valid without
text.

Merge pull request #1807 from DMPRoadmap/feature/validations ...

Feature/validations

Add exit code to assets rake task

Fix lint issues in JS

Merge branch 'feature/validations' of github.com:DMPRoadmap/roadmap into feature/validations

Refactor rule: Plann - fix blank title

Added rake task to check record validity via SQL

Merge branch 'development' into fix/account_creation

Merge branch 'development' into feature/validations

Replace YARD documentation with Tomdoc ...

These changes use the YARD gem, but in the lighter Tomdoc format.

You can read more about Tomdoc here: https://tomdoc.org

Update rake tasks for documentation with Tomdoc

Moved field validation to my_org.js