fixed issue with progress bar totals ...

updated logic to allow for phase sepcific progress or total progress

updated plan

Refactored num_answrered_questions

Merge pull request #2211 from DMPRoadmap/issue2175 ...

Added functionality to give warnings when links open in new windows.

Fix for providing a text alternative for tooltips for assistive technologies. ...

The fix consists of adding the current tooltip text to a <em> tag with the bootstrap class
sr-only that is made only available to assitive technologies.

Fix for issue #2174.

Added functionality to give warnings when links open in new windows. ...

The solution is based on the recommendation in "Techniques for WCAG 2.0" section
"G201: Giving users advanced warning when opening a new window":
"Example 2: Using CSS to provide a warning before opening a new window"
(cf., https://www.w3.org/TR/WCAG20-TECHS/G201.html)

Changes:

- any link in the views with target="_blank" has had css class "has-new-window-popup-info" to the link together with the span   <span class="new-window-pop-info"><%= _('Opens in new window') %></span>.
- The javascript script externalLink.js is used for external links that don't have the target="_blank" in the view.

Fix for issue #2175.

Merge pull request #2202 from DMPRoadmap/issue2169 ...

Enable spellcheck for text fields:

Enable spellcheck for text fields: ...

Changes:
 - added HTML 5 attribute spellcheck= "true" to text_field tag by adding
        spellcheck: true.
 - Did not add this attribute to text_fields for:
    firstname,
    surname,
    principal_investigator_name &
    data_contact.
   (it is irritating for folk to have a spellchecker say your name is incorrectly spelt.)

Fix for issue #2169.

fix template published date

changed tooltip text to use app name from branding

added gettext markup

updated plan sharing form according to #2111, also added text to the email field to clarify what happens if the user is not in our system

Add template version to Plan view. ...

Changes added template version to plan overview.

Fix for issue #2157.

Merge pull request #2128 from DMPRoadmap/feature/research-grant-id ...

Add typeahead field for Research Grant ID

Merge branch 'development' into feature/research-grant-id

Merge branch 'development' into feature/reviewer_role

refactored review access from role to permission

Add typeahead field for Grant ID

Allow org admins to view 'share plan' page. ...

Changes:
 - Updated share? method in the class PlanPolicy.
 - Also fixed Rubocop warnings in PlanPolicy.
 - Updated _navigation.html.erb and _share_form.html.erb
   to enable org admins to view the Share tab of org plans.

Fix for #2090.

Table View Issue for Readonly Content of Plan and Template pages. ...

Changes:
- to re-style the readonly text tables with padding
- added the TinyMCE like styling to the Phase overview description

Fix for #2071.

The "Request expert feedback" text area on the Share Plan page displayed ...

Ruby strings  %{user_name} and %{plan_name} that were not interpolated.

- The strings are now interpolated.
- The function helper function feedback_constant_to_text in FeedbacksHelper
 displays the user name instead of the email.
- also Rubocop errors and warnings in FeedbacksHelper were fixed.

Fix for issue #2047.

added logic to hide guidance selection if there is no selectable guidance (#2021) ...

fixed typos

updated Role, Plan logic and fixed tests

Issue #1161 - Display tooltip below form fields on Create plan page. ...

- Required modification for the intiialization of Bootstrap tooltips in the javascript file
      /utils/tooltipHelper.js. The default behaviour is placement of tooltip to the right of element
      with attribute data-toggle='tooltip'. Now if the attribute data-placement attribute is set,
      then the placement of the tootip will be as specfied in the attribute and not on the right (the default behaviour).
    - The accessible combob-box now takes an optional property 'placement' which if present sets data-placement
      attribute to the value of the placement property.
    - Now all Create Plan page tooltips are below the input as requested.

Fix for #1161.

added hidden field to plan_export_form, updated controller auth logic to allow public plan owners to choose options

fixed layout issues on create plan page

accessibility fix - add 'new window' text for screen readers when links has target=_blank (#1901) ...

added sr logic to download_plan submit button

Remove old JS form validations (#1867) ...

* added new form validation error handling

added tests for orgs controller

converted over remaining controllers to new errors

enhanced message handlers in application controller

finished form validations

* fixed rubocop for all controllers

* Fix broken specs

- Factories needed to be updated to meet new validation requirements
- Spec was broken since error message had changed

* Fix errors and warnings from npm audit

Textual changes made to Plan Edit Details Page: (#1858) ...

* Textual  changes made to Plan Edit Details Page:

- 'Submit' buttons renamed 'Save'
- 'Plan Guidance Configuration' chanded to 'Select Guidance'

* Updated button name in  in failing plans_spec.rb test from
"Submit" to "Save".

Merge branch 'development' into issue-1843

Add specs for PDF download link

Move template options to main namespace