IssueID #1749 - Allow break of words in the text for answers and comments. (#2038) ...

Fix for issue #1749.

Improved formatting of plan downloads. (#2035) ...

Fix for issue #1893

- Cleaned some of the formatting issues for the html, pdf and docx format
that used the partial app/views/shared/export/_plan.erb.

Fix for the scenario a plan with a question checkboxes where the a single checkbox has been checked and saved, then unchecked and saved. The bug is that the checkbox still appears. (#2034) ...

The fix was suggested by Y Chieh Henry Yang. It resets the permitted question_option_ids array to an empty array.

Fix for #1999

Change where replies to DMP review email are directed. (#2006) (#2033) ...

The email sent when Feedback complete now uses the contact_email of the organisation from which Feeedback has been given.

Display issue (cropped answers & whitespace) when reviewing DMPs when answers in (#2023) ...

readonly mode.

Fixes issue #1683.

When the review mode is readonly, then we display the answer in in a paragraphs.

added logic to hide guidance selection if there is no selectable guidance (#2021) ...

fixed typos

made question themed guidance accordion ids more specific (#2022)

updated call to Plan.readable_by? (#2019)

added table prefix to column sorts (#2017)

Merge pull request #2015 from DMPRoadmap/issue/2014 ...

issue/2014: Issues Preventing Shiboleth account creation or linking from the homescreen

added check to feedback_requested (#2012)

added externalLink.js back to application.js (#2013)

updated ref (#2010)

fixed query (#2008)

updated sessions controller to no longer set shibboleth_id field on user account, changed devise registrations/new so the js could find the create-account-form.

updated organisational plans query to only include completed plans to match logic of plan export (#2004) ...

refactored plan.visibility_allowed? to call underlying method on phases

refactored plan.visibility_allowed? to call underlying method on phases

fixed tests

Further changes for Text field should be mandatory for option based questions. ...

Fix for issue #1725

The question_options field on the Customisable Phase template has the
following changes:
- the 'Text' label has the asterick for required.
- the error message for missing question option now reads
 "You must have at least one option with accompanying text."
- Corrected some Rubocop errors on the files added.

Patch issue with share plans on development ...

Devise circumvents running validations on the user models when invite! is called.
I updated this call to adhere to validations, and I've updated the form to request the name,org of the user when a plan is shared with them.
This should fix the issue for both newly created share-plan users, and those with previous, bad data in the system.

You may want to consider re-running your validations(or fixup) scripts for users as you can have some invalid ones that you'll need to set a default name/org

Merge pull request #1997 from DMPRoadmap/issue1663 ...

Moved deactivate logic to Role model and added specs

made recommended adjustments

removed debug statements

Merge pull request #1998 from DMPRoadmap/roadmap_styling_tweaks ...

refactoring css variables to be more descriptive when re-branding the site

finished up changes to controllers

Merge branch 'development' into issue1663

Merge pull request #1994 from DigitalCurationCentre/issue1391 ...

Issue1391

updated Role, Plan logic and fixed tests

Updated api stats controller to use Org model's method (#1995) ...

* updated api stats controller to use Org model's  method

* updated org.plans to check role.active flag

* updated other api stats endpoints to use org.plans

refactoring css variables to be more descriptive when re-branding the site

refactor plan/role functionality to use flagshihtzu properly

updated deactivate logic