Merged DMP Roadmap V2.1.5

Merge pull request #2342 from DMPRoadmap/issue2341 ...

check for agreement to T&Cs was wrong

accept_terms is inside user

check for agreement to T&Cs was wrong

removed travis ...

Briri GitHub tests (#2312)

* Created Github workflow for tests

Github workflow for Rubocop (#2315)

* Create ruby.yml

* updated to get ruby ver from gem file.lock

Update rubocop.yml

Update rubocop.yml

pulling in our rubocop gem

reverted rubocop file

Pulled all of the separate gem's rubocop stuff into the repo's rubocop file

Removed 'Rails' from rubocop.yml

added brakeman workflow

fixed bad rubocop disable lines

restricted brakeman workflow to PR on master

added ES lint workflow

fixed typo

added workflow for mysql tests

chenged workflow names and updated mysql

chenged workflow names and updated mysql

chenged workflow names and updated mysql

chenged workflow names and updated mysql

chenged workflow names and updated mysql

chenged workflow names and updated mysql

added password for mysql tests and fixed spec

removed blank line

added rails_env environment var

added RAILS_ENV to bundle commands

removed rails_env from rspec line

Added comment on rewritten methods in controllers, models ...

Replaced include by prepend for DMPOPIDoR modules

Merged DMPRoadmap V2.1.3

Merged DMPRoadmap V2.1.2

Add functionality for School/Department for an organisation. ...

Changes:
    - added a Department model whose instances belong to an org and require name.
    - added a DepartmentController and views for create, edit/update and a index view which is a tab
      of 'Organisational Details'.
    - added the optional attribute department_id to User model.
    - added Rspec tests.
    - updated app/controllers/registrations_controller.rb, app/models/org.rb and
      app/models/user.rb to get rid of outstanding Rubocop warnings

    Fix for issue #2088.

Commented overridden methods in controllers & models

Fix in mixin controllers call

Merged with DMPRoadmap:master

Funders should not appear in create account form and profile edit

Added a customised error message for the case where personal details update of the email fails because of its use already. ...

Fix for #1749.

Remove old JS form validations (#1867) ...

* added new form validation error handling

added tests for orgs controller

converted over remaining controllers to new errors

enhanced message handlers in application controller

finished form validations

* fixed rubocop for all controllers

* Fix broken specs

- Factories needed to be updated to meet new validation requirements
- Spec was broken since error message had changed

* Fix errors and warnings from npm audit

Remove references to Org#parent_id

Replace deprecated methods with their new alaises

added additional invitation token check

removed side effects when generating or removing API token. Removed org_id method from User and use after_update callback instead. #1060

Merge branch 'development' into login_workflow

New login workflow changes (post-shibboleth authentication) ...

- New dual choice layout in app/views/devise/registrations/new.html.erb
- Changes to omniauth_callbacks/application/registrations/sessions controllers to support choice post-shibboleth auth:
  - Do you have an account? Sign in to link your shibboleth credentials
  - If you don't have an account, sign up and this will link your shibboleth credentials
- Changes to sign in, create account, and password details forms for multiple onscreen "show password" tickboxes
- Aesthetic change to clear-field (X) icon (align it with input field and bring it inside)

Create account org is needed now. Fixed find nil whne swaping orgs. #1144

removed duplicate ids for elements. DMPRoadmap/roadmap#1009 ...

sending hidden input when input checkbox is false. DMPRoadmap/roadmap#1009

fixed redirect to password-details when something wrong. fixed URL to show a href when a tab is clicked. DMPRoadmap/roadmap#1009

Sign up email case insensitive. Removed session key previous_url since does not work well. Duck-typed User.where_case_insensitive method. DMPRoadmap/roadmap#638 ...

Re-factored logic to accommodate stem accounts. DMPRoadmap/roadmap#638

Added active tab logic as tabHelper.js ...

added helper task to detect active tab

converted active tab logic to be handled via JS

added hash to default profile tab

fixed broken test

Created shared org autocomplete/other org control for Profile and Create Account pages ...

added js and css for autocomplete box and other org toggle

added logic to disable org change while account is linked. added warning for org admin about losing priveleges

tweaked css to work on both forms. added logic to hide link creds if no org

removed change to package-lock.json

fixed logic bug in display of shib link

removed check for nil allow_other_orgs

removed recovery_email from the 2 forms and fixed bug in edit profile save

if no defaults specified, obtuse error. now improved.

Create Account: Fix styling/code issues for Organisation dropdown #518