opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / app / controllers / org_admin

2018-09-07	16e12b7 Browse files » Remove old JS form validations (#1867) ... * added new form validation error handling added tests for orgs controller converted over remaining controllers to new errors enhanced message handlers in application controller finished form validations * fixed rubocop for all controllers * Fix broken specs - Factories needed to be updated to meet new validation requirements - Spec was broken since error message had changed * Fix errors and warnings from npm audit Brian Riley authored on 7 Sep 2018 Gavin Morrice committed on 7 Sep 2018
2018-08-30	05eed79 Browse files » Merge branch 'development' into issue-1843 briri committed on 30 Aug 2018
2018-08-29	Unverified d5d1177 Browse files » Refactor sections controller create action Bodacious committed on 29 Aug 2018
	Unverified ca20ef0 Browse files » Refactor Template creation views and controllers Bodacious committed on 29 Aug 2018
	Unverified 318e1ce Browse files » Move template options to main namespace Bodacious committed on 29 Aug 2018
2018-08-28	Unverified 286aed3 Browse files » Refactor template options into own controller Bodacious committed on 28 Aug 2018
2018-08-28	3039ef5 Browse files » Refactor how section ordering is handled (#1837) ... * Extract template customizations into own controller * Refactor Template model methods * Fix view logic in draggable sections * Add button for customising phase * Fix rubocop violations in GuidanceService * Rename GuidanceService to GuidancePresenter * Fix bug in phase preview order sections * Refactor preview action/controller code * Fix Section ordering in various views * Fix rubocop violations * Fix bug forcing Phases to be modifiable * Fix broken tests * Update method to check if section is draggable * Extract copy action into its own resource * Extract customization transfers to own controller * Remove redundant routing condition * Fix Rubocop violation issues * Change condition for section draggable * Refactor instance variable in PlansController * Fix broken tests * Add test support for 'de' locale * Fix merge issue in plans controller * Fix broken specs in plan#request_feedback Gavin Morrice authored on 28 Aug 2018 Sam Rust committed on 28 Aug 2018
2018-08-22	Unverified 40348a9 Browse files » Issue/1815 (#1831) ... * # This is a combination of 2 commits. # The first commit's message is: updated logic on number of non-customized templates # This is the 2nd commit message: noticed other stats affected by customizations_vs_funder mismatched, so fixed those * Updated logic on number of non-customized templates, published, unpublished Sam Rust authored on 22 Aug 2018 GitHub committed on 22 Aug 2018
2018-08-22	7dcb85e Browse files » Fix TinyMCE JS on forms loaded with DOM (#1827) ... * Fix TinyMCE JS on forms loaded with DOM Fixes #1777 * Fix broken specs * Fix Rubocop style violations Ignored LineLength violations when string is part of FastGettext * Updated rubocop style gem Gavin Morrice authored on 22 Aug 2018 Sam Rust committed on 22 Aug 2018
2018-08-17	Unverified bca4a89 Browse files » Ensure annotations destroyed when text is blank ... When a user updates an existing annotation to set its text to blank, this should destroy that annotation record on the DB—since they can't be valid without text. Bodacious committed on 17 Aug 2018
2018-08-16	Unverified 209495f Browse files » Remove !bang save and updates when if condition Bodacious committed on 16 Aug 2018
2018-08-16	Unverified 5e0f92c Browse files » Refactor template index views to use instance vars Bodacious committed on 16 Aug 2018
2018-08-03	Unverified 67fa39e Browse files » Remove number field from sections form ... This should no longer be necessary, since the number is set automatically by ordering the sections Bodacious committed on 3 Aug 2018
2018-08-01	Unverified f7e3d8b Browse files » Refactored model code for better readability Bodacious committed on 1 Aug 2018
2018-07-25	Unverified 0d4cdee Browse files » Add extra validations for all models ... - Includes specs using the Shoulda gem - Includes a refactoring of update_numbers to a "sortable" abstraction Bodacious committed on 25 Jul 2018
2018-07-16	ec700a6 Browse files » fixed issues with saving and displaying of template stack ... Removed comments briley committed on 16 Jul 2018
2018-07-12	Unverified ca4a6ad Browse files » Make sections within a phase sortable Bodacious committed on 12 Jul 2018
2018-07-12	a167b6f Browse files » Remove Rails 3 attr accessible from models (#1691) Gavin Morrice authored on 12 Jul 2018 Sam Rust committed on 12 Jul 2018
2018-07-06	4abf839 Browse files » fix issue with theme deletion on annotation save #1684 xsrust committed on 6 Jul 2018
2018-06-18	fd47409 Browse files » switched guidance themes from checkboxes to radio buttons (#1608) ... ported radio button logic to validation.js updated shared tehemes partial to allow 'required' and 'asRadio' arguments. Also fixed bug with removing all theme selections on question form and added 'no themes selected' message fixed typo and renamed asRadio to as_radio Brian Riley authored on 18 Jun 2018 Sam Rust committed on 18 Jun 2018
2018-06-14	7ca739e Browse files » started fixing sort issues briley committed on 14 Jun 2018
2018-05-30	5351a9e Browse files » added redirects to template and section controller for edit action when template is not latest and section is not modifiable ... fixed typos fixed tests fixed up schema.rb fixed up schema.rb fixed up schema.rb pull down latest htmltoword briley committed on 30 May 2018
2018-05-23	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
2018-04-09	9c74f47 Browse files » removed delete of array element ... fixes issue with removing item from array while iterating over it briley committed on 9 Apr 2018
2018-04-04	949284c Browse files » fixed issue with equality check on localizable string :/ briley committed on 4 Apr 2018
2018-03-02	84d2dbd Browse files » updated templates to display customisation in messaging when appropriate Brian Riley committed on 2 Mar 2018
2018-02-24	2f56f10 Browse files » simplified logic for selected templates tab ... perpetuate edit flag throughout partials updated preview updated preview Brian Riley committed on 24 Feb 2018
2018-02-22	740deb1 Browse files » updated tables so they have default sorts. updated paginable clear/search links ... added logic to retain sort info after search fixed sort link and updated tests reverted changes to concern and paginable/search erbs reverted tests briley committed on 22 Feb 2018
2018-02-21	2131671 Browse files » fixed issue with phase accordions on template page ... fixed issue with retaining current template tab updated urls in test briley committed on 21 Feb 2018
2018-02-20	f2ff19e Browse files » page ALL is retained if latest request contains it. Sort links are now right aligned within the th. #1105 ... default sorting to paginable concern specified through query_params keyword. #1105 paginable plans including default sorting paginable orgs including default sorting. #1105 Jose Lloret committed on 20 Feb 2018