added exception for devise managed users.email to use our homegrown email validator

updated presence check to obey 'ifs' on validators. e.g. feedback_email_subject is required IF feedback_enabled?

updated script name in new v2_0_0_part_1 task

created new find_know_invalidations rake task. Added new pre migrate step

updated prefetching syntax error

added user rules to fixup blank name/orgs and updated some other tasks

merged development additions to data_cleanup into working branch

added additional data cleanup steps to catch other orphaned records that might be found in other installations. Added stat rake tasks

added check for roles with orphaned user

fixed issue with role cleanup

updated blank fixes to include both nil and empty string

fixed issue with Org abbreviation yaml check

organized the upgrade.rake and added a v2_0_0 task. add check for answers with missing plans to data cleanup

added additional data_cleanup rules

Started Services and Actions for #1689 (#1871) ...

StatCreatedPlan/StatJoinedUser Services and Action finished. #1689

removed comment. #1689

usage#all endpoint for all usage CSV reports. #1689

usage#all endpoint with request test associated. #1689

Removed require from files

Moved generate actions into services [#1689]

Renamed joined_user service related [#1689]

Renamed stat_created_plan action to service [#1689]

Removed action total_stat in favour of total_count_stat_service

UsageDownloadController using Org::TotalCountStatService instead of the action

added rule to remove orphaned answers which have no associated plans

added any check to allow skipping of rule if no orgs have blank abbreviations

added trim to check for optimistic lock text

Merge pull request #1896 from DMPRoadmap/issue-1861 ...

Fix bug in paginable table sorting

added default for feedback email subject. updated JS toggle to enable/disable feddback message appropriately (#1895) ...

added default for feedback email subject. updated JS toggle to enable/disable feddback message appropriately

fixed issue with autosave (#1894)

Merge pull request #1882 from DMPRoadmap/issue-1760 ...

Display total Org users and total Org plans statistics on the Usage s…

Fix bug in paginable table sorting ...

- Wasn't flipping direction when clicked
- JS was loading multiple nested duplicate .paginable objects

Display total Org users and total Org plans statistics on the Usage statistics page. ...

Feature for issue #1760

Fix broken tests caused by locale configuration (#1875) ...

* Fix broken tests caused by locale configuration

- Add LocaleSet
- Add LocaleFormatter to force proper string formats
- Rename I18n formats to use hyphen
- Add rake task for updating existing languages on DB
- Fix instances of US english in the templates

* Fix FastGettext initializer loader

* Add Amazon S3 creds for Travis

* Revert "Add Amazon S3 creds for Travis"

This reverts commit 366c1a7.

* Fix Faker localization for rake tasks

Was breaking rake db:seed file

Fixed issues with data_cleanup and section_sorter (#1859) ...

* updated mysql query to update phase/section/question numbering, moved versionable_id rake task, fixed issue with section_sorter

fixed test

* Moved private methods from migrate to upgrade rake

Remove old JS form validations (#1867) ...

* added new form validation error handling

added tests for orgs controller

converted over remaining controllers to new errors

enhanced message handlers in application controller

finished form validations

* fixed rubocop for all controllers

* Fix broken specs

- Factories needed to be updated to meet new validation requirements
- Spec was broken since error message had changed

* Fix errors and warnings from npm audit

Refactor how Template upgrade customization works (#1856) ...

* Refactor how Template upgrade customization works

- Added position_in_parent to child-records Phase, Section, and Questions
- Extracted upgrade_customization! into its own service object

wip: rebasing on development

wip: pushing to Ghub

wip: Template upgrade customisation service working

Add migration to update versionable_id for records

* Fix bug in org swaps test

Test was failing because JS wasn't executing fast enough in test browser

* Refactor how locales are set in specs

* Fix bug in plan exports caused by git merge

The routes weren't merged properly which seems to have caused a regression error

* Add documentation for SectionSorter

* Update rubyzip and re-instate Bundle Audit

This was disabled because it was failing the Travis CI script. Since there wasn't a
new version of the rubyzip gem to upgrade to, we couldn't turn the error off.

* Add length constraints to versionable_id

* Add length constraints to versionable_id

* Fix bug in ActsAsSortable module

... I have no idea why those issues haven't popped up before now!?

* Fix random bug in I18n

* Move versioning ID migration into own rake task

rebased onto development ...

stat_created_plan_spec finished

stats table using bigint. StatJoinedUser spec done

csvable_spec done

org_date_rangeable_spec done

Actions::StatCreatedPlan::Generate spec half way done

Actions::StatCreatedPlan::Generate rspec done

Actions::StatJoinedUser::Generate spec finished

Role.with_access_flags instead of access_values_for method

Refactor how section ordering is handled (#1837) ...

* Extract template customizations into own controller

* Refactor Template model methods

* Fix view logic in draggable sections

* Add button for customising phase

* Fix rubocop violations in GuidanceService

* Rename GuidanceService to GuidancePresenter

* Fix bug in phase preview order sections

* Refactor preview action/controller code

* Fix Section ordering in various views

* Fix rubocop violations

* Fix bug forcing Phases to be modifiable

* Fix broken tests

* Update method to check if section is draggable

* Extract copy action into its own resource

* Extract customization transfers to own controller

* Remove redundant routing condition

* Fix Rubocop violation issues

* Change condition for section draggable

* Refactor instance variable in PlansController

* Fix broken tests

* Add test support for 'de' locale

* Fix merge issue in plans controller

* Fix broken specs in plan#request_feedback