Remove old JS form validations (#1867) ...

* added new form validation error handling

added tests for orgs controller

converted over remaining controllers to new errors

enhanced message handlers in application controller

finished form validations

* fixed rubocop for all controllers

* Fix broken specs

- Factories needed to be updated to meet new validation requirements
- Spec was broken since error message had changed

* Fix errors and warnings from npm audit

Remove Rails 3 attr accessible from models (#1691)

Fix for nasty bug (add Note after Answer has been saved -> duplicate blank answer saved)

fixed up issues with request feedback emails

Org Admin provide feedback ...

Add Plans page to Org Admin section

added org admin plans page

finsihed up org admin plans page

added feedback complete and updated emails to use email_signature partial

refactored access checks on Plan now that user can have multiple roles (reviewer + ?)

finished feedback completion routine

added tests for new feedback methods

fixes for merge conflicts

fixed issues with plan and user changes

fixed issue with notes controller test

fixed issue with phase controller test

conditional_user_mailer concern for delivering email according to preferences. DMPRoadmap/roadmap#811 ...

unit test for the concern. DMPRoadmap/roadmap#811

deliver_if recipients keyword accepts User or Array of Users. DMPRoadmap/roadmap#811

conditional email for users.new_comment, owners_and_coowners.visibility_changed. DMPRoadmap/roadmap#811

conditional email for users.added_as_coowner. DMPRoadmap/roadmap#811

conditional email for admins.feedback_requested. DMPRoadmap/roadmap#811

updating failing tests

re-saved files

merge Dev into CDL-MVP

Fix conflicts with merging dev into CDL

updated answers and notes controller for #798

Fixed to notes UI according to DMPRoadmap/roadmap#706 ...

re-added listener for new_note submit. DMPRoadmap/roadmap#706

Fixed huge editor for notes when clicking on edit note. Improved performance since Tinymce editor is load on demand. DMPRoadmap/roadmap#706

guidances_notes layout according to bootstrap. DMPRoadmap/roadmap#562 ...

new notes view according to bootstrap. Display logic for each view at JS. DMPRoadmap/roadmap#562

new notes working without js.erb templates. Fixed functional test broken. TODO update number of comments view. DMPRoadmap/roadmap#562

$.ajax attributes url and method extracted from closest form action and method attributes respectively. DMPRoadmap/roadmap#562

number of comments template and includes method at answer for abstracting logic. DMPRoadmap/roadmap#562

added generic success message and updated controllers to use it DMPRoadmap/roadmap#175

broken generic error message handler apart into separate create/update/destroy versions. updated calls within the controllers and fixed tests DMPRoadmap/roadmap#227

Added obj_name param to the generic error message handler on application_controller. Updated all save error handling to render the page rather than redirect DMPRoadmap/roadmap#227

added notes controller tests

Change notes to work with AJAX calls.

Replaced I18n.t(...) from controllers. DMPRoadmap/roadmap#98

trying to reduce data access queries. Needs more work

first port of plan creation and editing to new data model

controllers only respond to html

renamed comments to notes