Merge pull request #1943 from DMPRoadmap/issue-1942 ...

Fix bug when sorting draggable sections

added handler for local dev/test and updated if statement to prevent local paths from redirecting

added JS to force external links to openin a new tab

Refactor JS in section sorting ...

Fixes #1939

Fix bug when sorting draggable sections

Fix for broken edit of user privileges and status by admins on the ...

Users accounts page.

 Delegated the JS event to 'body' instead of paginableSelector in
 admin_grant_permissions.js.

Fix for issue #1908.

added trim to check for optimistic lock text

Merge pull request #1896 from DMPRoadmap/issue-1861 ...

Fix bug in paginable table sorting

added default for feedback email subject. updated JS toggle to enable/disable feddback message appropriately (#1895) ...

added default for feedback email subject. updated JS toggle to enable/disable feddback message appropriately

fixed issue with autosave (#1894)

Fix bug in paginable table sorting ...

- Wasn't flipping direction when clicked
- JS was loading multiple nested duplicate .paginable objects

Remove old JS form validations (#1867) ...

* added new form validation error handling

added tests for orgs controller

converted over remaining controllers to new errors

enhanced message handlers in application controller

finished form validations

* fixed rubocop for all controllers

* Fix broken specs

- Factories needed to be updated to meet new validation requirements
- Spec was broken since error message had changed

* Fix errors and warnings from npm audit

Refactor how section ordering is handled (#1837) ...

* Extract template customizations into own controller

* Refactor Template model methods

* Fix view logic in draggable sections

* Add button for customising phase

* Fix rubocop violations in GuidanceService

* Rename GuidanceService to GuidancePresenter

* Fix bug in phase preview order sections

* Refactor preview action/controller code

* Fix Section ordering in various views

* Fix rubocop violations

* Fix bug forcing Phases to be modifiable

* Fix broken tests

* Update method to check if section is draggable

* Extract copy action into its own resource

* Extract customization transfers to own controller

* Remove redundant routing condition

* Fix Rubocop violation issues

* Change condition for section draggable

* Refactor instance variable in PlansController

* Fix broken tests

* Add test support for 'de' locale

* Fix merge issue in plans controller

* Fix broken specs in plan#request_feedback

Fix TinyMCE JS on forms loaded with DOM (#1827) ...

* Fix TinyMCE JS on forms loaded with DOM

Fixes #1777

* Fix broken specs

* Fix Rubocop style violations

Ignored LineLength violations when string is part of FastGettext

* Updated rubocop style gem

fixed issues with JS and updated other org selection areas to use new JS (#1805) ...

updates to JS for org selection cahnges in PR#1778

Ensure annotations destroyed when text is blank ...

When a user updates an existing annotation to set its text to blank, this
should destroy that annotation record on the DB—since they can't be valid without
text.

Fix lint issues in JS

Merge branch 'development' into fix/account_creation

Moved field validation to my_org.js

Fixed issue with Javascript

Fixed empty 'Organisation' field issue

Added automatic selection of 'Other' org when using unlisted org

Code cleanup to match Roadmap code base

Fix bug causing drag handle to collapse as minus

Update error message when prepending two sections

Show alert when dragging section to 1st place

Extend notification code to make them floatable

Remove wobble effect from failed sort

Change sort handle to arrows instead of bars

Fix bug causing tooltips to display badly ...

Fixes #1739