opidor/dmpopidor

Fork: 0

opidor / dmpopidor

History for dmpopidor / app / controllers / answers_controller.rb

2019-12-16	ec1818c Browse files » removed travis ... Briri GitHub tests (#2312) * Created Github workflow for tests Github workflow for Rubocop (#2315) * Create ruby.yml * updated to get ruby ver from gem file.lock Update rubocop.yml Update rubocop.yml pulling in our rubocop gem reverted rubocop file Pulled all of the separate gem's rubocop stuff into the repo's rubocop file Removed 'Rails' from rubocop.yml added brakeman workflow fixed bad rubocop disable lines restricted brakeman workflow to PR on master added ES lint workflow fixed typo added workflow for mysql tests chenged workflow names and updated mysql chenged workflow names and updated mysql chenged workflow names and updated mysql chenged workflow names and updated mysql chenged workflow names and updated mysql chenged workflow names and updated mysql added password for mysql tests and fixed spec removed blank line added rails_env environment var added RAILS_ENV to bundle commands removed rails_env from rspec line briri committed on 16 Dec 2019
2019-01-07	4a80943 Browse files » Fix for the scenario a plan with a question checkboxes where the a single checkbox has been checked and saved, then unchecked and saved. The bug is that the checkbox still appears. (#2034) ... The fix was suggested by Y Chieh Henry Yang. It resets the permitted question_option_ids array to an empty array. Fix for #1999 John Pinto authored on 7 Jan 2019 Sam Rust committed on 7 Jan 2019
2018-09-07	16e12b7 Browse files » Remove old JS form validations (#1867) ... * added new form validation error handling added tests for orgs controller converted over remaining controllers to new errors enhanced message handlers in application controller finished form validations * fixed rubocop for all controllers * Fix broken specs - Factories needed to be updated to meet new validation requirements - Spec was broken since error message had changed * Fix errors and warnings from npm audit Brian Riley authored on 7 Sep 2018 Gavin Morrice committed on 7 Sep 2018
2018-08-01	Unverified f7e3d8b Browse files » Refactored model code for better readability Bodacious committed on 1 Aug 2018
2018-06-11	dc48c98 Browse files » Added `rake translatable:find` ... ran gettext:find and fixed up en_US translations added translatable:find task and fixed up a few files added exception to po/pot backup files in gitignore began fixing up pt_BR added pt_BR translations fixed issue with multiline translatable text on help page. reran translatable:find and fixed up app.pot, pt_BR, en_US and en_GB fixed test fixed another test updated author comments added devise and bootstrap translations for pt_BR Brian Riley authored on 25 May 2018 briley committed on 11 Jun 2018
2018-05-23	92da1d9 Browse files » Template Versioning ... This commit is a complete refactor of all the pages involved with Template creating/editing. The database, models, controllers, views and JS have all been changed. ------------------------------------------------------------ removed unused template methods from Plan model and removed references to 'Dmptemplate' from tests started updating model scopes and began creating new unit tests and test_helper methods Rebased with template customization fixes. updated tests and latest_version queries Grouping class methods. Grouping scope methods into separate class removed Template::valid scope method in favour of Template::unarchived Moved class methods to scope rails flavour. Removed Template::get_public_published_template_versions method Model#deep_copy instead of Model::deep_copy. Model#deep_copy without side effects added customize method to model updated customize to use new deep_copy and added some tests fixed test fixed broken tests after latest PR. DMPRoadmap/roadmap#1341 generate_version with unit test associated customize with unit test associated upgrade_customization first attempt added tests for upgrade_customization upgrade_customization with several unit test associated added generate_copy fixed tests and added test_helper for phase/section/question/annotation/question_option equality for verifying template copy/version/customize added comments finished up tests Removed template.update! in favour of a more re-usable deep_copy with atomic saving. removed new_copy.save! from templates_controller#copy. Atomic save for upgrade_customization method renamed to bang notation generate_copy, generate_version, customize and upgrade_customization question mark methods for generate_version, customize and upgrade_customization unique indices for template and template customisations. #1341 init functionality for versionable concern updated errors, added get_new unique indices for template and template customisations. #1341 new schema dump generated from rails manually set up the default for org.links Fix for rake tasks updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods updated template controller and tests finished tests for template controller update http verbs for customize and copy methods updated template versioning intgeration to use new test_helper methods wired in the new versionable concern wired in the new versionable concern updated query structure in template_filter updated routes and paths moved phases controller to org_admin namespace changes to phase model and unit tests started moving phase views to new org_admin namespace and tests fixed tests started fixing up references to moved plan/phase status started fixing up references to moved plan/phase status moved js file, fixed tests and manually checked pages set schema.rb back to sprint2 added in versionable concern and fixed tests removed unused phase_status method removed test for phase_status method fixed issue with template visibility for the default template fixed issue with default templates and versioning/customization versionable_test.rb versionable concern updated find_or_generate_version! into template, test associated annotation and question model using has_one through adequately templates_controller#update action refactored tweaks to template_test get_new and get_modifiable test cases for RuntimeError capture passing parent object ids to children during deep_copy updated question_option and annotation deep copy removed old deep_copy method from section model and updated unit tests removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests started work on new template show/edit finished up templates UI fixed tests consolidated form consolidated form fixed history page removed old view fixed test fixed typo in en_US app.po removed old deep_copy method from section model and updated unit tests updates to sections controller, model, routes and tests fixed broken tests updated both phases and sections controller to use versionable fixed tests fixed tests and missing policy fixed tests created separate routes for each template index tab updates to template index page structure added callback to template model to ensure only one published version finished up first pass of templates index page fixed tests removed current_tab from phase views. DMPRoadmap/roadmap#1407 section#create refactored. DMPRoadmap/roadmap#1407 sections loaded on demand for a phase. DMPRoadmap/roadmap#1407 ExpandAll triggers click instead of using collapse. DMPRoadmap/roadmap#1407 added phase/section/question overview back to template details page send customizer to show section page updated button text updated history controller action updated controller updated views added customization distinction to page title updates to phase/section to introduce referrer logic and added section-show for customizable removed old 'edit phase details button removed edit question partial from section show tweaks to templates index pages fixed tests and default scope added test for default customizations added namespace to org section of templates index and made autocomplete combobox aware of form namespace fixed issue with container view removed old policies updated statuses of templates fixed typo in phases/overview view. DMPRoadmap/roadmap#1377 annotations moved to org_admin namespace. DMPRoadmap/roadmap#1377 annotations_controller#(create\|update\|destroy) with test associated. DMPRoadmap/roadmap#1377 flash notice for successful action carried out. DMPRoadmap/roadmap#1377 flash notice for success actions. create? method for annotation policy. DMPRoadmap/roadmap#1377 started refactor of sections/questions fixed nil references. DMPRoadmap/roadmap#1462 annotations as fields_for nested attributes. DMPRoadmap/roadmap#1462 commented out version check on template update removed invalid test fixed reference to moved partials and family to family_id fixed question update updated guidances to work with modified themes form finished up questions fixed broken tests updated preview and customize fixed issue with sections index cleaned up remaining issues with template editing and customization added in check for nil phase to sections create any user with readable rights should see download tab for a plan. DMPRoadmap/roadmap#1483 updated history to use new template.draft? logic to determine when to show draft icon added latest check added check for default option added checks for historical and customization on preview page added redirect to show if template is customization added redirect to show if template is customization updated ajax success/error for section display fixed issues with create plan template selection and changing plan visibility forgot to include model change reverted schema.rb changes adding org to chained scope in order to have searchable and sortable templates. DMPRoadmap/roadmap#1495 improved customization template search against all funder templates. DMPRoadmap/roadmap#1499 started work on adding edit/show/new/cancel buttons for questions added toggle functionality between question show/edit removed whitespace made text area the default updated template statuses updated class to fix layout introducing event delegation for sections/questions/annotations. DMPRoadmap/roadmap#1502 removed console.log fixed JS for section/question annotation loading tinymce when section show only permits customisation. DMPRoadmap/roadmap#1502 fixed issue with customizating by adding a section/question removed reload set focus to first invalid form input fixed placement of focus for new validation.js Added joins for customizations table updated query fixed initial numbering for new phases/sections reverted referrer change made section fields required added ariatise to new section form fixed referrer check fixed inconsistent status message for transfer customization workflow fixed issue with csv download fixed csv header fixed links for customization on history page updated sections index so new section doesn't show unless its the current template Added joins for customizations table added includes to customisable query fixed issue with paginable history fixed merge conflicts in templates_controller and questions/_show.html.erb resolved additional rebase conflict briley committed on 23 May 2018
2018-04-06	7850aea Browse files » added base_template_org and updated write plan to show correct org in guidance tab ... updated example answers logic added missing code to answers conroller and fixed test Brian Riley committed on 6 Apr 2018
2018-04-04	bb28367 Browse files » added org abbreviation to 'Guidance' sections and added customized example answers ... updated locking logic briley committed on 4 Apr 2018
2018-03-06	b7192a4 Browse files » capture changes xsrust committed on 6 Mar 2018
2018-03-06	9c1aee9 Browse files » added questionformatscontroller, updated answers_controler to deal with rda_ques xsrust committed on 6 Mar 2018
2018-01-25	d6dcbff Browse files » Removed circular tick icon progress indicators from each section in write plan. DMPRoadmap/roadmap#867 ... Ensure the question text comes before an example answer. DMPRoadmap/roadmap#867 Made the "Answered X mins ago" alert smaller. DMPRoadmap/roadmap#867 drew a line between questions to visually demarcate one from another. DMPRoadmap/roadmap#867 Fixed accordion HTML elements hierarchy and optimised expandCollapseAll. DMPRoadmap/roadmap#867 Reinstate borders around active areas. DMPRoadmap/roadmap#867 Ensure edges are consistent throughout UI - sharp not curved. DMPRoadmap/roadmap#867 Ensure edges are consistent throughout UI - sharp not curved. DMPRoadmap/roadmap#867 example answer for plans tweaked. Answer status html refactored. DMPRoadmap/roadmap#867 fixes problem rendering tinymce when a stale answer is found. DMPRoadmap/roadmap#867 refactored styles into classes. DMPRoadmap/roadmap#867 . Jose Lloret committed on 25 Jan 2018
2017-12-05	ea5cfbc Browse files » removed after_create callback for answers since no longer is needed after introducing transactions. DMPRoadmap/roadmap#893 ... unit test for answer#is_valid?. DMPRoadmap/roadmap#893 answer#update based on current_user. input text for answer based on either answer.text or question.default_text. DMPRoadmap/roadmap#893 renamed answers#update to answers#create_or_update and added new tests. DMPRoadmap/roadmap#893 Jose Lloret committed on 5 Dec 2017
2017-11-16	232ccf8 Browse files » updating failing tests xsrust committed on 16 Nov 2017
2017-11-16	fa6ec53 Browse files » Fix conflicts with merging dev into CDL xsrust committed on 16 Nov 2017
2017-11-06	63974e9 Browse files » updated answers and notes controller for #798 xsrust committed on 6 Nov 2017
2017-10-26	e6664c4 Browse files » after_create plan callback for saving answers. TODO error handling at answers#update. DMPRoadmap/roadmap#530 ... error handling for when an answer does not exist. DMPRoadmap/roadmap#530 error handling for answering questions. DMPRoadmap/roadmap#530 optimistic locking fixed. DMPRoadmap/roadmap#530 fixed tests after create callback for answers. Refactored answers js file. DMPRoadmap/roadmap#530 Jose Lloret committed on 26 Oct 2017
2017-10-20	22190a6 Browse files » Plan progress changed in favour of phase from a plan progress. DMPRoadmap/roadmap753 Jose Lloret committed on 20 Oct 2017
2017-09-11	5b7b419 Browse files » DMPRoadmap/roadmap#562 ... edit phases using plan navigation layout bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor fixed broken test regarding answers_controller Jose Lloret committed on 11 Sep 2017
2017-06-02	509cbd2 Browse files » Added method to validate answer according to each question format. Partial view for section progress. Eager loading of resources needed to calculate plan and section progress. Refactoring of code for progress plan. DMPRoadmap/roadmap#382 ... Fixed merge conflict. DMPRoadmap/roadmap#382 onChange event for tinymce at plan answers. Removed unnecessary options passed to tinymce. DMPRoadmap/roadmap#382 Jose Lloret committed on 2 Jun 2017
2017-05-29	63d7c8c Browse files » Fixed timeago problem for when a new answer is created. Refactored JavaScript logic into its own file. Created a partial to handle answer status. DMPRoadmap/roadmap#355 Jose Lloret committed on 29 May 2017
2017-05-24	d79cb8c Browse files » Using touch for timestamp for when only answer.question_options is updated. DMPRoadmap/roadmap#355 Jose Lloret committed on 24 May 2017
2017-05-24	d894ad0 Browse files » Checkbox using rails FormHelper. Helper method at answer model for determining if an option should be selected. DMPRoadmap/roadmap#354 Jose Lloret committed on 24 May 2017
2017-05-23	647b1ba Browse files » radiobuttons question is now saving through its relation question_options rather than options. Added whitelisting attributes for mass assignment. DMPRoadmap/roadmap#302 Jose Lloret committed on 23 May 2017
2017-04-19	5d94291 Browse files » updated spacing in mailers based on @xsrust changes to the sharing notification briley committed on 19 Apr 2017
2017-04-14	5088efd Browse files » finished fixes for answer creation race condition DMPRoadmap/roadmap#241 Brian Riley committed on 14 Apr 2017
2017-04-13	bdb1298 Browse files » updates to locking mechanism because it ActiveRecord does not catch 2 creates DMPRoadmap/roadmap#241 briley committed on 13 Apr 2017
2017-04-13	fb11eff Browse files » updated answers controller so that user_id is not a part of the find_by DMPRoadmap/roadmap#241 briley committed on 13 Apr 2017
2017-03-29	436a250 Browse files » change how updating various status indicators are done fixes: https://github.com/DMPRoadmap/roadmap/issues/182 ray.carrick committed on 29 Mar 2017
2017-03-22	112db27 Browse files » fixes issues around answer text not saving properly; references https://github.com/DMPRoadmap/roadmap/issues/181 ... fixes issues around status spacing and adds in untranslated strings for status; references https://github.com/DMPRoadmap/roadmap/issues/182 ray.carrick committed on 22 Mar 2017
2017-03-14	facecda Browse files » change from serialized hash tp just using includes ray.carrick committed on 14 Mar 2017