| 2018-09-07 |
Remove old JS form validations (#1867)
...
* added new form validation error handling
added tests for orgs controller
converted over remaining controllers to new errors
enhanced message handlers in application controller
finished form validations
* fixed rubocop for all controllers
* Fix broken specs
- Factories needed to be updated to meet new validation requirements
- Spec was broken since error message had changed
* Fix errors and warnings from npm audit
Brian Riley
authored
on 7 Sep 2018
Gavin Morrice
committed
on 7 Sep 2018
|
| 2018-08-22 |
fixed issues with JS and updated other org selection areas to use new JS (#1805)
...
updates to JS for org selection cahnges in PR#1778
Brian Riley
authored
on 22 Aug 2018
Sam Rust
committed
on 22 Aug 2018
|
| 2018-07-13 |
Fix bug preventing users from updating email
Bodacious
committed
on 13 Jul 2018
|
| 2018-06-13 |
Add form validations (#1588)
...
removed formtastic
added required asterisks to create plan page and updated JS logic of Org selection
added namespaces to edit profile, sign in and create account forms to fix duplicate id issue
fixed JS behind links and their validation
fixed JS behind links and their validation
removed console.log statement and added rake tasks for data validation cleanup
Add form validations
removed formtastic
added required asterisks to create plan page and updated JS logic of Org selection
added namespaces to edit profile, sign in and create account forms to fix duplicate id issue
fixed JS behind links and their validation
fixed JS behind links and their validation
removed console.log statement and added rake tasks for data validation cleanup
made recommended adjustments
reverted schema.rb
removed unecessary other_org query
Brian Riley
authored
on 13 Jun 2018
Sam Rust
committed
on 13 Jun 2018
|
| 2018-03-09 |
added org change confirmation
...
finalized changes
briley
authored
on 8 Mar 2018
Brian Riley
committed
on 9 Mar 2018
|
| 2018-01-12 |
removed duplicate ids for elements. DMPRoadmap/roadmap#1009
...
sending hidden input when input checkbox is false. DMPRoadmap/roadmap#1009
fixed redirect to password-details when something wrong. fixed URL to show a href when a tab is clicked. DMPRoadmap/roadmap#1009
Jose Lloret
committed
on 12 Jan 2018
|
| 2017-11-16 |
update password confirmation modal to submit form
...
update password confirmation modal to submit form
made pwd-confirmation selector less explicit. removed JS that disabled org selecter if shib linked
fixed linter issue
briley
committed
on 16 Nov 2017
|
| 2017-11-01 |
Removed need to enter password on profile page except for email
...
started work on adding modal for password confirmation
added password field. devise requires both
removed debug statements and added comments
moved modal to form submission
Brian Riley
authored
on 20 Oct 2017
briley
committed
on 1 Nov 2017
|
| 2017-10-24 |
Created shared org autocomplete/other org control for Profile and Create Account pages
...
added js and css for autocomplete box and other org toggle
added logic to disable org change while account is linked. added warning for org admin about losing priveleges
tweaked css to work on both forms. added logic to hide link creds if no org
removed change to package-lock.json
fixed logic bug in display of shib link
removed check for nil allow_other_orgs
briley
committed
on 24 Oct 2017
|
| 2017-10-09 |
Merge pull request #671 from CDLUC3/issue568
...
Converted popovers and tooltips to Bootstrap tooltips
Bhavi
authored
on 9 Oct 2017
GitHub
committed
on 9 Oct 2017
|
| 2017-10-06 |

Converted popovers and tooltips to Bootstrap tooltips DMPRoadmap/roadmap#568
...
commented out import of old ES5 tooltip JS
added bootstrap tooltip wiring to application.js
removed boostrap tooltip/popover calls from devise/regisitrations/edit and updated html
added placement and animation rules to general tooltip init. converted edit plan details page to use tooltips
removed irrelevant data-placement from edit profile tooltips
converted guidance group popovers to tooltips
converted guidance popovers to tooltips
converted popovers on phase edit/add to tooltips
converted popoevers to bootstrap tooltips on sections and questions
removed popover references from annotations, and templates
boostrapped the shibboleth_ds page and converted ES5 to ES6
fixed linter issues with shib_ds. added tooltip functionality to autocomplete erb
updated tooltip on create account page
updated tooltips on table filter and grant permissions pages
removed redundant right placement on personal details form
fixed broken test
briley
authored
on 5 Oct 2017
Brian Riley
committed
on 6 Oct 2017
|
| 2017-10-04 |
Bootstrap Org Details Page (#647)
...
Bootstrap Org Details
Bootstrap Org Details Page
update js of Org Admin
udpate js to es6 (in progress)
include Tinymce function def
bhavi
committed
on 4 Oct 2017
|
| 2017-09-15 |

Bootstrapped Edit Profile page (#90)
...
* DMPRoadmap/roadmap#issue567
- Bootstrapped the Write Plan page accordions
- Rebased with latest from CDL-MVP
bootstrapped the phases accordion DMPRoadmap/roadmap#567
added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap/roadmap#567
finished Bootstrapping write plan accordions DMPRoadmap/roadmap#567
fixed linter issue DMPRoadmap/roadmap#issue567
fixed linter issue
* Bootstrapping and ES6 of the Plan Download page DMPRoadmap/roadmap#561.
- Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route)
- Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes)
- Bootstrapped page html
changed name of show_export to download to match UI terminology. Bootstrapped download page
Added ES6 JS for download page and made tweaks to the format
* DMPRoadmap/roadmap#562
edit phases using plan navigation layout
bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse
answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js
Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor
fixed broken test regarding answers_controller
* fixed linter issue with CRLF
* fixed tests broken by name change from show_export to download.
* Boostrapped the create plan page. DMPRoadmap/roadmap#632
- Converted JS for page over to ES6
- Added stub test and fixture
- Converted jquery autocomplete combobox to Bootstrap and ES6
TODO:
- Add in AJAX calls to retrieve template options based on org/funder selections
- Fix issue with the hidden id field being updated when combobox item is selected
- Finish tests for the autoComplete.js
Bootstrapped Plan Writing and Download pages (#88)
* DMPRoadmap/roadmap#issue567
* DMPRoadmap/roadmap#issue561
- Bootstrapped the Write Plan page accordions
- Rebased with latest from CDL-MVP
bootstrapped the phases accordion DMPRoadmap/roadmap#567
added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap/roadmap#567
finished Bootstrapping write plan accordions DMPRoadmap/roadmap#567
fixed linter issue DMPRoadmap/roadmap#issue567
fixed linter issue
* Bootstrapping and ES6 of the Plan Download page DMPRoadmap/roadmap#561.
- Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route)
- Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes)
- Bootstrapped page html
changed name of show_export to download to match UI terminology. Bootstrapped download page
Added ES6 JS for download page and made tweaks to the format
* DMPRoadmap/roadmap#562
edit phases using plan navigation layout
bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse
answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js
Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor
fixed broken test regarding answers_controller
* fixed linter issue with CRLF
* fixed tests broken by name change from show_export to download.
added JS tests for expandCollapseAll accordion functionality
fixed linter complaint about double vs single quotes in test
removed a few empty and unused views. removed old es5 js for create plan page. bootstrapped the create plan page
boostrapped the create plan page. converted jquery autocomplete to ES6 and bootstrap. started adding JS tests
removed unfinished tests for autocomplete, will finihs after demo. added comments to autoComplete.js
* Boostrapped the create plan page
* Bootstrap User profile page (#563) (#637)
* adding bootstrap classes to the form
* add bootstrap classes to user details and preferences tab
* add user profile page js file
* add other tabs form to js bundle as well
* import password validator js into user_profile
* Pulling in Bootstrap of Create Plan changes (#89)
* DMPRoadmap/roadmap#issue567
- Bootstrapped the Write Plan page accordions
- Rebased with latest from CDL-MVP
bootstrapped the phases accordion DMPRoadmap/roadmap#567
added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap/roadmap#567
finished Bootstrapping write plan accordions DMPRoadmap/roadmap#567
fixed linter issue DMPRoadmap/roadmap#issue567
fixed linter issue
* Bootstrapping and ES6 of the Plan Download page DMPRoadmap/roadmap#561.
- Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route)
- Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes)
- Bootstrapped page html
changed name of show_export to download to match UI terminology. Bootstrapped download page
Added ES6 JS for download page and made tweaks to the format
* DMPRoadmap/roadmap#562
edit phases using plan navigation layout
bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse
answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js
Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor
fixed broken test regarding answers_controller
* fixed linter issue with CRLF
* fixed tests broken by name change from show_export to download.
* Boostrapped the create plan page. DMPRoadmap/roadmap#632
- Converted JS for page over to ES6
- Added stub test and fixture
- Converted jquery autocomplete combobox to Bootstrap and ES6
TODO:
- Add in AJAX calls to retrieve template options based on org/funder selections
- Fix issue with the hidden id field being updated when combobox item is selected
- Finish tests for the autoComplete.js
Bootstrapped Plan Writing and Download pages (#88)
* DMPRoadmap/roadmap#issue567
* DMPRoadmap/roadmap#issue561
- Bootstrapped the Write Plan page accordions
- Rebased with latest from CDL-MVP
bootstrapped the phases accordion DMPRoadmap/roadmap#567
added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap/roadmap#567
finished Bootstrapping write plan accordions DMPRoadmap/roadmap#567
fixed linter issue DMPRoadmap/roadmap#issue567
fixed linter issue
* Bootstrapping and ES6 of the Plan Download page DMPRoadmap/roadmap#561.
- Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route)
- Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes)
- Bootstrapped page html
changed name of show_export to download to match UI terminology. Bootstrapped download page
Added ES6 JS for download page and made tweaks to the format
* DMPRoadmap/roadmap#562
edit phases using plan navigation layout
bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse
answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js
Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor
fixed broken test regarding answers_controller
* fixed linter issue with CRLF
* fixed tests broken by name change from show_export to download.
added JS tests for expandCollapseAll accordion functionality
fixed linter complaint about double vs single quotes in test
removed a few empty and unused views. removed old es5 js for create plan page. bootstrapped the create plan page
boostrapped the create plan page. converted jquery autocomplete to ES6 and bootstrap. started adding JS tests
removed unfinished tests for autocomplete, will finihs after demo. added comments to autoComplete.js
* Boostrapped the create plan page
* add user profile page js file
* add other tabs form to js bundle as well
import password validator js into user_profile
update the jquery to es6 for preferences
* fixing minor issues on user_profile related to forms
Brian Riley
authored
on 15 Sep 2017
GitHub
committed
on 15 Sep 2017
|

Bootstrap User profile page (#563) (#637)
...
* adding bootstrap classes to the form
* add bootstrap classes to user details and preferences tab
* add user profile page js file
* add other tabs form to js bundle as well
* import password validator js into user_profile
* Pulling in Bootstrap of Create Plan changes (#89)
* DMPRoadmap/roadmap#issue567
- Bootstrapped the Write Plan page accordions
- Rebased with latest from CDL-MVP
bootstrapped the phases accordion DMPRoadmap/roadmap#567
added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap/roadmap#567
finished Bootstrapping write plan accordions DMPRoadmap/roadmap#567
fixed linter issue DMPRoadmap/roadmap#issue567
fixed linter issue
* Bootstrapping and ES6 of the Plan Download page DMPRoadmap/roadmap#561.
- Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route)
- Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes)
- Bootstrapped page html
changed name of show_export to download to match UI terminology. Bootstrapped download page
Added ES6 JS for download page and made tweaks to the format
* DMPRoadmap/roadmap#562
edit phases using plan navigation layout
bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse
answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js
Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor
fixed broken test regarding answers_controller
* fixed linter issue with CRLF
* fixed tests broken by name change from show_export to download.
* Boostrapped the create plan page. DMPRoadmap/roadmap#632
- Converted JS for page over to ES6
- Added stub test and fixture
- Converted jquery autocomplete combobox to Bootstrap and ES6
TODO:
- Add in AJAX calls to retrieve template options based on org/funder selections
- Fix issue with the hidden id field being updated when combobox item is selected
- Finish tests for the autoComplete.js
Bootstrapped Plan Writing and Download pages (#88)
* DMPRoadmap/roadmap#issue567
* DMPRoadmap/roadmap#issue561
- Bootstrapped the Write Plan page accordions
- Rebased with latest from CDL-MVP
bootstrapped the phases accordion DMPRoadmap/roadmap#567
added es6 function to provide expand/collapse all functionality. bootstrapped several accordions DMPRoadmap/roadmap#567
finished Bootstrapping write plan accordions DMPRoadmap/roadmap#567
fixed linter issue DMPRoadmap/roadmap#issue567
fixed linter issue
* Bootstrapping and ES6 of the Plan Download page DMPRoadmap/roadmap#561.
- Renamed show_export.html.erb to download.html.erb (updated controller, policy, links and route)
- Renamed export_settings.js to download.js and dropped unused auto-save JS (no longer a part of wireframes)
- Bootstrapped page html
changed name of show_export to download to match UI terminology. Bootstrapped download page
Added ES6 JS for download page and made tweaks to the format
* DMPRoadmap/roadmap#562
edit phases using plan navigation layout
bootstrap plan progress. bootstrap sections header. added togglable section icons for expand/collapse
answers_controller returning a JSON with partial views rendered. Split question types in different partials. Started new answers/status.js
Rename view to edit_plan_answers.html.erb. Load tinymce through ES6 for question answers. Delete old status.js ES5. Added timeago to vendor
fixed broken test regarding answers_controller
* fixed linter issue with CRLF
* fixed tests broken by name change from show_export to download.
added JS tests for expandCollapseAll accordion functionality
fixed linter complaint about double vs single quotes in test
removed a few empty and unused views. removed old es5 js for create plan page. bootstrapped the create plan page
boostrapped the create plan page. converted jquery autocomplete to ES6 and bootstrap. started adding JS tests
removed unfinished tests for autocomplete, will finihs after demo. added comments to autoComplete.js
* Boostrapped the create plan page
* add user profile page js file
* add other tabs form to js bundle as well
import password validator js into user_profile
update the jquery to es6 for preferences
* fixing minor issues on user_profile related to forms
Bhavi
authored
on 15 Sep 2017
Brian Riley
committed
on 15 Sep 2017
|
| 2017-08-28 |
added ES6 JS for sign in and create account forms DMPRoadmap/roadmap#558
briley
committed
on 28 Aug 2017
|
| 2017-08-22 |
Resolve merge conflicts. DMPRoadmap/roadmap#587
Jose Lloret
committed
on 22 Aug 2017
|
| 2017-08-09 |
tinymce refactoring for notes using JS. DMPRoadmap/roadmap#571
...
tinymce refactoring for notes using JS. DMPRoadmap/roadmap#571
tinymce refactoring for answers using JS. TODO adding events. DMPRoadmap/roadmap#571
tinymce gem removed from any view. DMPRoadmap/roadmap#571
tinymce answer events for editor working. DMPRoadmap/roadmap#571
fixed typos in js.erb template. DMPRoadmap/roadmap#571
extend renamed to define since more appropiate. DMPRoadmap/roadmap#571
Jose Lloret
committed
on 9 Aug 2017
|
| 2017-08-07 |
front-end dependencies handled through npm. DMPRoadmap/roadmap#551
Jose Lloret
committed
on 7 Aug 2017
|
| 2017-07-21 |
Create Account: Fix styling/code issues for Organisation dropdown #518
Keith McGrellis
committed
on 21 Jul 2017
|
| 2017-07-17 |
Set focus to response messages #135
Keith McGrellis
committed
on 17 Jul 2017
|
| 2017-06-29 |
update the js on profile page
bhavi
committed
on 29 Jun 2017
|
| 2017-06-23 |
moved js and css files into structured directories
Brian Riley
committed
on 23 Jun 2017
|